New issue
Advanced search Search tips

Issue 611412 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 611410

Blocking:
issue 589460



Sign in to add a comment

[css-grid] Update <fixed-size> syntax

Project Member Reported by r...@igalia.com, May 12 2016

Issue description


This bug has been extracted from a comment in auto-repeat meta bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=589460#c11

However, the syntax has been changed again and now it's:
  <fixed-size> =
    <fixed-breadth> |
    minmax( <fixed-breadth> , <track-breadth> ) |
    minmax( <inflexible-breadth> , <fixed-breadth> )

We've to update the syntax but probably it's a good idea
to wait for  bug #611410  before working on this.
 

Comment 1 by r...@igalia.com, May 23 2016

Owner: r...@igalia.com
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e41b40417c0ba7a1f44a0cb6d636ffc76811d666

commit e41b40417c0ba7a1f44a0cb6d636ffc76811d666
Author: rego <rego@igalia.com>
Date: Tue May 24 07:06:35 2016

[css-grid] Update <fixed-size> syntax

The syntax for <fixed-size> has been updated on the spec:
https://drafts.csswg.org/css-grid/#typedef-fixed-size

New syntax is:
  <fixed-size> =
    <fixed-breadth> |
    minmax( <fixed-breadth> , <track-breadth> ) |
    minmax( <inflexible-breadth> , <fixed-breadth> )

This means that it's enough to have one <fixed-breadth>,
it doesn't matter if it's as minimum or maximum.
Before it was required that the minimum was fixed.

Updated test to check the new expected behavior.

BUG= 611412 
TEST=fast/css-grid-layout/grid-element-auto-repeat-get-set.html

Review-Url: https://codereview.chromium.org/2001113002
Cr-Commit-Position: refs/heads/master@{#395538}

[modify] https://crrev.com/e41b40417c0ba7a1f44a0cb6d636ffc76811d666/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-auto-repeat-get-set-expected.txt
[modify] https://crrev.com/e41b40417c0ba7a1f44a0cb6d636ffc76811d666/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-auto-repeat-get-set.html
[modify] https://crrev.com/e41b40417c0ba7a1f44a0cb6d636ffc76811d666/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/e41b40417c0ba7a1f44a0cb6d636ffc76811d666/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Comment 3 by r...@igalia.com, May 24 2016

Status: Fixed (was: Assigned)

Sign in to add a comment