As soon as caching of AudioOutputDevices is AudioRendererMixerManager is introduced, we can switch to using the cache to get the default output device parameters. It can reduce the number of required IPC.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b599cad423a58e34a49be04da7f197313e055e6 commit 5b599cad423a58e34a49be04da7f197313e055e6 Author: guidou <guidou@chromium.org> Date: Thu Jul 07 18:35:33 2016 Stop using GetAudioHardwareConfig to get audio parameters in WebRtcLocalAudioSourceProvider. BUG= 611404 Review-Url: https://codereview.chromium.org/2131563002 Cr-Commit-Position: refs/heads/master@{#404188} [modify] https://crrev.com/5b599cad423a58e34a49be04da7f197313e055e6/content/renderer/media/webrtc_local_audio_source_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1289f96885ccaa8949668391c8d6d33667b83973 commit 1289f96885ccaa8949668391c8d6d33667b83973 Author: guidou <guidou@chromium.org> Date: Wed Jul 13 02:08:04 2016 Use AudioDeviceFactory instead of GetAudioHardwareConfig to fetch audio output device parameters in Blink platform. This is in anticipation to the removal of RenderThreadImpl::GetAudioHardwareConfig() BUG= 611404 Review-Url: https://codereview.chromium.org/2128273003 Cr-Commit-Position: refs/heads/master@{#404889} [modify] https://crrev.com/1289f96885ccaa8949668391c8d6d33667b83973/content/renderer/renderer_blink_platform_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d commit a148aeb2bc27a99f25b97931dd94e28f2eab6f1d Author: olka <olka@chromium.org> Date: Fri Jul 15 10:24:10 2016 Getting rid of AudioHardwareConfig and its synchronous IPC. Switching to AudioDeviceFactory::GetOutputDeviceInfo() instead. BUG= 611404 , 549125 , 422522 Review-Url: https://codereview.chromium.org/2120273004 Cr-Commit-Position: refs/heads/master@{#405737} [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/content/browser/renderer_host/render_message_filter.cc [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/content/browser/renderer_host/render_message_filter.h [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/content/common/view_messages.h [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/content/renderer/media/audio_device_factory.h [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/content/renderer/media/audio_message_filter.h [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/content/renderer/media/audio_renderer_mixer_manager.cc [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/content/renderer/media/audio_renderer_sink_cache_impl.cc [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/content/renderer/media/media_stream_renderer_factory_impl.cc [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/content/renderer/pepper/pepper_platform_audio_output.cc [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/content/renderer/pepper/pepper_plugin_instance_impl.cc [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/content/renderer/render_thread_impl.cc [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/content/renderer/render_thread_impl.h [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/media/base/BUILD.gn [delete] https://crrev.com/3c109dd65c1984237444da93f7c7acc8b0bdcd92/media/base/audio_hardware_config.cc [delete] https://crrev.com/3c109dd65c1984237444da93f7c7acc8b0bdcd92/media/base/audio_hardware_config.h [delete] https://crrev.com/3c109dd65c1984237444da93f7c7acc8b0bdcd92/media/base/audio_hardware_config_unittest.cc [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/media/blink/webmediaplayer_impl.h [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/media/media.gyp [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/media/mojo/services/test_mojo_media_client.cc [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/media/mojo/services/test_mojo_media_client.h [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/media/renderers/audio_renderer_impl.h [modify] https://crrev.com/a148aeb2bc27a99f25b97931dd94e28f2eab6f1d/media/renderers/default_renderer_factory.h
Leaving the GetAudioHardwareConfig prototype in RenderThreadImpl is accidental, right?
Looks like that. Good catch. Feel free to remove it :) (together with https://cs.chromium.org/chromium/src/content/renderer/render_thread_impl.h?sq=package:chromium&dr=C&rcl=1470021470&l=79)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5895c7d04b29898b1f693e2ef6619ce5ad58274 commit c5895c7d04b29898b1f693e2ef6619ce5ad58274 Author: maxmorin <maxmorin@chromium.org> Date: Fri Aug 05 22:36:04 2016 Remove dead RenderThreadImpl::GetAudioHardwareConfig. BUG= 611404 Review-Url: https://codereview.chromium.org/2197903003 Cr-Commit-Position: refs/heads/master@{#410199} [modify] https://crrev.com/c5895c7d04b29898b1f693e2ef6619ce5ad58274/content/renderer/render_thread_impl.h
Comment 1 by olka@chromium.org
, May 12 2016