Issue metadata
Sign in to add a comment
|
14.8%-51.2% regression in browser_tests at 392452:392460 |
||||||||||||||||||||
Issue descriptionThe blame list is https://chromium.googlesource.com/chromium/src/+log/31c2d5a8cbeced5cb648ed5fea9a9e92efb13623..520ed318ae5da996aebc47f09bb1a13c2c0a301f and I suspect https://chromium.googlesource.com/chromium/src/+/f8ec6afcc3998e96bcaf0a7a7ac24c979b40a83f since that's a Mac specific change (this alert only triggered on Mac)
,
May 12 2016
,
May 12 2016
I see bitrate is much higher than before. I am currently waiting for https://codereview.chromium.org/1818903004/ to address it.
,
May 13 2016
,
May 14 2016
Issue 611398 has been merged into this issue.
,
May 23 2016
After the latest changes- see issue 597095 - it looks like goog_frame_rate_sent is fixed as it is stably on 30. However, the others are still different compared to before Hw encode. I don't have any explanation to why available_send_bw and available_recv_bw has went up from 2.6m to 3.0m. goog_jitter_buffer_ms and goog_target_delay_ms can be explained through the HW encoder behavior though.
,
May 23 2016
I think this is caused by timestamp inaccuracy. For hardware encoding we end up using the system clock for timestamps instead of the camera driver value. This adds inaccuracy in two ways: - The software clock is only accurate to 16ms - We timestamp the frame after encoding, adding more jitter. One thing it doesn't explain is the bandwidth estimation change, holmer@ any ideas?
,
May 23 2016
It might be explained by that the bitrate produced by the hw encoder varies more than the sw encoder. BWE will ramp-up to 1.5x the bitrate it receives, so assuming it receives 2 mbps at times, it will be able to ramp up to 3 mbps. Does that sound like how you've seen it behave?
,
May 24 2016
FYI there's finally a CL up for propagating the timestamp here, so hopefully that can land soon: https://codereview.chromium.org/1996453003/
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 9 2016
,
Jun 9 2016
Re #9, I landed the CL to use correct timestamps for Mac here: https://codereview.chromium.org/2039423002/ However, looking at the bots, it doesn't seem like it made the expected difference in goog_jitter_buffer_ms or goog_target_delay_ms. https://chromeperf.appspot.com/group_report?bug_id=611392
,
Jun 24 2016
Ping. The regression is not yet recovered.
,
Jun 24 2016
The correct timestamp usage got reverted here for all platforms: https://codereview.chromium.org/2071953003. I am waiting for it to see if goog_jitter_buffer_ms and goog_target_delay_ms values would change. goog_frame_rate_sent is back to stable 30 again. available_send_bw and available_recv_bw can be explained by the comment #8.
,
Jul 8 2016
Any update on this? The metrics have not recovered.
,
Jul 10 2016
This issue has been moved once and is lower than Pri-1. Removing the milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 2 2016
emircan: ping
,
Aug 2 2016
goog_frame_rate_sent: Fixed. available_send_bw and available_recv_bw: See comment #8. It is the expected behavior. goog_jitter_buffer_ms and goog_target_delay_ms: See comment #7. This behavior might change when we fix the timestamp mismatch. https://codereview.chromium.org/2205623002/ is the CL to address it which is tracked on issue 597087 .
,
Aug 29 2016
I landed the above CL to address the timestamp issue. Since then(08-26), the graphs started acting very inconsistently, see available_send_bw, available_recv_bw, goog_jitter_buffer_ms and goog_current_delay_ms. https://chromeperf.appspot.com/group_report?bug_id=611392 kjellander@ would you have any idea why this might be happening.
,
Aug 31 2016
With your CL (https://codereview.chromium.org/2205623002) many metrics start bouncing very randomly between builds (you have to move the mini-view window to the right a lot in the initial report link to see this). I really have no idea. The hardware has been the same and there are no machine changes that I'm aware of. holmer: can you figure out why the perf values became so unstable?
,
Aug 31 2016
I am going to revert that CL (and merge it to M54) to recover the stats.
,
Oct 11 2016
Perf sheriff ping
,
Oct 17 2016
emircan@: did you revert that CL, and do the graphs (https://chromeperf.appspot.com/group_report?bug_id=611392) look how you expect them to?
,
Oct 17 2016
I reverted that CL, see 641230. As I explained on #18, the metrics recovered except for the ones related to issue 597087 . I will mark this one as fixed and continue tracking timestamp issue there. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by kjellander@chromium.org
, May 12 2016