New issue
Advanced search Search tips

Issue 611350 link

Starred by 0 users
Status: Fixed
Owner:
grt@chromium.org
Closed: May 2016
Cc:
robertshield@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"test_installer (with patch)" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 12 2016 
"test_installer (with patch)" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJgsSBUZsYWtlIht0ZXN0X2luc3RhbGxlciAod2l0aCBwYXRjaCkM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by vasi...@chromium.org, May 13 2016

Labels: -Sheriff-Chromium
Owner: robertshield@chromium.org
This is reproduced only on try bots. Assigning to Robert for triaging.

[0512/130204:FATAL:thread_local_storage.cc(236)] Check failed: slot_ > 0 (0 vs. 0)
Backtrace:
	GetHandleVerifier [0x0021D747+56727]
	InjectDumpProcessWithoutCrash [0x001F6E51+194257]
	GetHandleVerifier [0x002252C5+88341]
	GetHandleVerifier [0x0021533B+22923]
	InjectDumpProcessWithoutCrash [0x001D35C5+48709]
	InjectDumpProcessWithoutCrash [0x001CBD53+17875]
	InjectDumpProcessWithoutCrash [0x001D3351+48081]
	(No symbol) [0x001B3512]
	(No symbol) [0x001B64EF]
	(No symbol) [0x001ACAB0]
	(No symbol) [0x001ACD3B]
	(No symbol) [0x001B0BE6]
	GetHandleVerifier [0x00259A5F+303279]
	BaseThreadInitThunk [0x7694338A+18]
	RtlInitializeExceptionChain [0x77E29F72+99]
	RtlInitializeExceptionChain [0x77E29F45+54]
Project Member

Comment 2 by chromium...@appspot.gserviceaccount.com, May 13 2016

Labels: Sheriff-Chromium
Detected 6 new flakes for test/step "test_installer (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJgsSBUZsYWtlIht0ZXN0X2luc3RhbGxlciAod2l0aCBwYXRjaCkM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 3 by vasi...@chromium.org, May 13 2016

Labels: -Sheriff-Chromium
Project Member

Comment 4 by chromium...@appspot.gserviceaccount.com, May 14 2016

Labels: Sheriff-Chromium
Detected 4 new flakes for test/step "test_installer (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJgsSBUZsYWtlIht0ZXN0X2luc3RhbGxlciAod2l0aCBwYXRjaCkM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 5 by chromium...@appspot.gserviceaccount.com, May 16 2016 

Detected 3 new flakes for test/step "test_installer (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJgsSBUZsYWtlIht0ZXN0X2luc3RhbGxlciAod2l0aCBwYXRjaCkM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 6 by chromium...@appspot.gserviceaccount.com, May 17 2016 

Detected 3 new flakes for test/step "test_installer (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJgsSBUZsYWtlIht0ZXN0X2luc3RhbGxlciAod2l0aCBwYXRjaCkM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 7 by finnur@chromium.org, May 18 2016

Labels: -Sheriff-Chromium
Status: Assigned (was: Untriaged)
Project Member

Comment 8 by chromium...@appspot.gserviceaccount.com, May 18 2016

Labels: Sheriff-Chromium
Detected 5 new flakes for test/step "test_installer (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJgsSBUZsYWtlIht0ZXN0X2luc3RhbGxlciAod2l0aCBwYXRjaCkM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 9 by hirosh...@chromium.org, May 19 2016

Labels: -Sheriff-Chromium
Already assigned, no need for Sheriff label.
Project Member

Comment 10 by chromium...@appspot.gserviceaccount.com, May 19 2016 

Detected 7 new flakes for test/step "test_installer (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJgsSBUZsYWtlIht0ZXN0X2luc3RhbGxlciAod2l0aCBwYXRjaCkM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 11 by grt@chromium.org, May 20 2016

Cc: robertshield@chromium.org
Owner: grt@chromium.org
I believe what has happened here is that this bot (vm835-m4 in my case) has a b0rked chrome install that can't be uninstalled. I'll add some smarts to test_installer.py to handle this failure and do the minimal cleanup so the test can proceed.
Project Member

Comment 12 by chromium...@appspot.gserviceaccount.com, May 20 2016 

Detected 7 new flakes for test/step "test_installer (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJgsSBUZsYWtlIht0ZXN0X2luc3RhbGxlciAod2l0aCBwYXRjaCkM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 13 by grt@chromium.org, May 21 2016

Status: Started (was: Assigned)
Project Member

Comment 14 by bugdroid1@chromium.org, May 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bd57c57b09b844151860758753bf0fb5075e676

commit 6bd57c57b09b844151860758753bf0fb5075e676
Author: grt <grt@chromium.org>
Date: Sat May 21 03:25:51 2016

Swallow exceptions from running Chrome's uninstaller in RunCleanCommand.

This should allow the test to proceed even if a previous install is so
badly broken that the uninstaller crashes or fails.

BUG= 611350 

Review-Url: https://codereview.chromium.org/1997173002
Cr-Commit-Position: refs/heads/master@{#395244}

[modify] https://crrev.com/6bd57c57b09b844151860758753bf0fb5075e676/chrome/test/mini_installer/test_installer.py

Comment 15 by grt@chromium.org, May 24 2016

Status: Fixed (was: Started)
No more flakes.
►

Sign in to add a comment