Issue 611343  has been merged into this issue.

Failing on mac_chromium_rel_ng, eg:

https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/226850

Some log output:

TopDocumentIsolationTest.FramesForSitesInHistory (run #1):
[ RUN      ] TopDocumentIsolationTest.FramesForSitesInHistory
[25607:1287:0512/145702:8523717495129:WARNING:vt_video_decode_accelerator_mac.cc(161)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "The operation couldn?t be completed. (OSStatus error -8973.)" (codecOpenErr) (-8973)
[25607:1287:0512/145702:8523718592132:WARNING:vt_video_decode_accelerator_mac.cc(196)] Failed to create hardware VideoToolbox session
[25607:1287:0512/145702:8523778281242:ERROR:vt_video_encode_accelerator_mac.cc(518)]  VTCompressionSessionCreate failed: -12908
[25606:1287:0512/145703:8524766906742:WARNING:render_frame_host_impl.cc(1825)] OnDidStopLoading was called twice.
[25606:1287:0512/145703:8524798880714:WARNING:render_frame_host_impl.cc(1825)] OnDidStopLoading was called twice.
[25606:1287:0512/145703:8524805834421:WARNING:render_frame_host_impl.cc(1825)] OnDidStopLoading was called twice.
../../content/browser/top_document_isolation_browsertest.cc:466: Failure
Value of: DepictFrameTree(root())
  Actual: " Site A ------------ proxies for B
Where A = http://a.com/
      B = http://b.com/"
Expected: " Site A
" "Where A = http://a.com/"
Which is: " Site A
Where A = http://a.com/"
With diff:
@@ -1,2 +1,3 @@
- Site A
+ Site A ------------ proxies for B
 Where A = http://a.com/
+      B = http://b.com/

[  FAILED  ] TopDocumentIsolationTest.FramesForSitesInHistory, where TypeParam =  and GetParam() =  (1937 ms)

TopDocumentIsolationTest.FramesForSitesInHistory (run #2):
[ RUN      ] TopDocumentIsolationTest.FramesForSitesInHistory
[26757:1287:0512/145835:8616802524385:WARNING:vt_video_decode_accelerator_mac.cc(161)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "The operation couldn?t be completed. (OSStatus error -8973.)" (codecOpenErr) (-8973)
[26757:1287:0512/145835:8616803380875:WARNING:vt_video_decode_accelerator_mac.cc(196)] Failed to create hardware VideoToolbox session
[26757:1287:0512/145835:8616857655256:ERROR:vt_video_encode_accelerator_mac.cc(518)]  VTCompressionSessionCreate failed: -12908
[26756:1287:0512/145836:8617626631367:WARNING:render_frame_host_impl.cc(1825)] OnDidStopLoading was called twice.
[26756:1287:0512/145836:8617649306336:WARNING:render_frame_host_impl.cc(1825)] OnDidStopLoading was called twice.
[26756:1287:0512/145836:8617654598372:WARNING:render_frame_host_impl.cc(1825)] OnDidStopLoading was called twice.
../../content/browser/top_document_isolation_browsertest.cc:456: Failure
Value of: DepictFrameTree(root())
  Actual: " Site B ------------ proxies for C
Where B = http://b.com/
      C = http://c.com/"
Expected: " Site B
" "Where B = http://b.com/"
Which is: " Site B
Where B = http://b.com/"
With diff:
@@ -1,2 +1,3 @@
- Site B
+ Site B ------------ proxies for C
 Where B = http://b.com/
+      C = http://c.com/

[  FAILED  ] TopDocumentIsolationTest.FramesForSitesInHistory, where TypeParam =  and GetParam() =  (1547 ms)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ab9185a90cd4801a8e80a50984a2d84cfa777da

commit 7ab9185a90cd4801a8e80a50984a2d84cfa777da
Author: tsergeant <tsergeant@chromium.org>
Date: Fri May 13 01:54:34 2016

Disable TopDocumentIsolationTest.FramesForSitesInHistory on Mac

The test is flaky on Mac, see
https://chromium-try-flakes.appspot.com/search?q=TopDocumentIsolationTest.FramesForSitesInHistory

BUG= 611344 
TBR=nick@chromium.org

Review-Url: https://codereview.chromium.org/1977503004
Cr-Commit-Position: refs/heads/master@{#393425}

[modify] https://crrev.com/7ab9185a90cd4801a8e80a50984a2d84cfa777da/content/browser/top_document_isolation_browsertest.cc

Presumably this flakiness is related to  issue 611300 .

Detected 3 new flakes for test/step "TopDocumentIsolationTest.FramesForSitesInHistory". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOwsSBUZsYWtlIjBUb3BEb2N1bWVudElzb2xhdGlvblRlc3QuRnJhbWVzRm9yU2l0ZXNJbkhpc3RvcnkM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

+alexmos

These failures appear to occurring because sometimes proxies are still around after navigating. I believe this can be explained by a recent behavior change to extend the lifetime of the proxy during unload https://codereview.chromium.org/1886413002

Consistent with this theory, if I add a slow unload handler to cross_process_iframe_factory, the failures become deterministic.

I would expect that any test that navigates cross-process, and then asserts on the proxy state via DepictFrameTree, might be exposed to this kind of flakiness now. Most of those are in SitePerProcessBrowserTest.

We can solve this by making our wait function wait for the old (pending delete) frames to go away.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a65c0019399f0a7052ab13bc73439acb116adb8

commit 7a65c0019399f0a7052ab13bc73439acb116adb8
Author: creis <creis@chromium.org>
Date: Sat Nov 05 00:23:04 2016

Fix flaky OOPIF tests by waiting for the old RenderFrame to be deleted.

This fixes:
SitePerProcessBrowserTest.CrossSiteIframe
SitePerProcessBrowserTest.NavigateRemoteFrame
SitePerProcessBrowserTest.RFPHDestruction
TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2
TopDocumentIsolationTest.FramesForSitesInHistory

BUG=662550, 629419,  611300 ,  611344 
TEST=Bots stay green.

Review-Url: https://codereview.chromium.org/2478933002
Cr-Commit-Position: refs/heads/master@{#430081}

[modify] https://crrev.com/7a65c0019399f0a7052ab13bc73439acb116adb8/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/7a65c0019399f0a7052ab13bc73439acb116adb8/content/browser/top_document_isolation_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6abe5bfc52cc830ee64a6277e19a8ad0fa71e2f

commit c6abe5bfc52cc830ee64a6277e19a8ad0fa71e2f
Author: mathp <mathp@chromium.org>
Date: Sat Nov 05 03:40:37 2016

Revert of Fix flaky OOPIF tests by waiting for the old RenderFrame to be deleted. (patchset #1 id:1 of https://codereview.chromium.org/2478933002/ )

Reason for revert:
Causing flakiness still:

https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/23876

Original issue's description:
> Fix flaky OOPIF tests by waiting for the old RenderFrame to be deleted.
>
> This fixes:
> SitePerProcessBrowserTest.CrossSiteIframe
> SitePerProcessBrowserTest.NavigateRemoteFrame
> SitePerProcessBrowserTest.RFPHDestruction
> TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2
> TopDocumentIsolationTest.FramesForSitesInHistory
>
> BUG=662550, 629419,  611300 ,  611344 
> TEST=Bots stay green.
>
> Committed: https://crrev.com/7a65c0019399f0a7052ab13bc73439acb116adb8
> Cr-Commit-Position: refs/heads/master@{#430081}

TBR=lukasza@chromium.org,creis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=662550, 629419,  611300 ,  611344 

Review-Url: https://codereview.chromium.org/2479863003
Cr-Commit-Position: refs/heads/master@{#430145}

[modify] https://crrev.com/c6abe5bfc52cc830ee64a6277e19a8ad0fa71e2f/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/c6abe5bfc52cc830ee64a6277e19a8ad0fa71e2f/content/browser/top_document_isolation_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29f856890eb1f7c96c3853314a10e782d53cb1eb

commit 29f856890eb1f7c96c3853314a10e782d53cb1eb
Author: creis <creis@chromium.org>
Date: Tue Nov 08 01:52:42 2016

Fix flaky OOPIF tests by waiting for the old RenderFrame to be deleted.

This fixes:
SitePerProcessBrowserTest.CrossSiteIframe
SitePerProcessBrowserTest.NavigateRemoteFrame
SitePerProcessBrowserTest.RFPHDestruction
TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2
TopDocumentIsolationTest.FramesForSitesInHistory

BUG=662550, 629419,  611300 ,  611344 
TEST=Bots stay green.

Committed: https://crrev.com/7a65c0019399f0a7052ab13bc73439acb116adb8
Review-Url: https://codereview.chromium.org/2478933002
Cr-Original-Commit-Position: refs/heads/master@{#430081}
Cr-Commit-Position: refs/heads/master@{#430474}

[modify] https://crrev.com/29f856890eb1f7c96c3853314a10e782d53cb1eb/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/29f856890eb1f7c96c3853314a10e782d53cb1eb/content/browser/top_document_isolation_browsertest.cc