Regression: The image overlaps on the open downloads button in chrome downloads.
Reported by
lpa...@etouch.net,
May 12 2016
|
|||||||
Issue descriptionChrome Version: 51.0.2704.47 (Official Build) 23ee1b3315bb84717e9a03a7f4a6dcc066823ee0-refs/branch-heads/2704@{#513} 32/64 bit OS: Windows(7,8,8.1,10), Linux (ubuntu 14.04 LTS), Mac (10.10.5)(10.11.4) Steps: 1. Launch chrome and navigate to chrome://downloads. 2. Resize chrome and drag the window from bottom to top. 3. Observe the "Nothing to see here" image. Actual Result: The image overlaps on the open download folder button. Expected Result: The image should not overlap on the open download folder button. This is a regression issue broken in 'M50' Manual Regression Range: Good Build: 50.0.2631.0 Bad Build: 50.0.2633.3 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/1e12ce9f124828d724656a8e113213acc39aa9cc..006b75cf40c873bcc386bf1ba99b8b63bc1818e9?pretty=fuller&n=1000 Suspecting: r371699
,
May 12 2016
,
May 12 2016
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5f745c1b2dfebd09e143a0388647f70d9e488a8 commit a5f745c1b2dfebd09e143a0388647f70d9e488a8 Author: cbiesinger <cbiesinger@chromium.org> Date: Thu May 12 21:13:06 2016 Give no-downloads a min-height to avoid overlapping the header. Without the min-height, we will flex-shrink the container of the image and center it outside its container, overlapping the header. BUG= 611334 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1978613002 Cr-Commit-Position: refs/heads/master@{#393356} [modify] https://crrev.com/a5f745c1b2dfebd09e143a0388647f70d9e488a8/chrome/browser/resources/md_downloads/manager.css [modify] https://crrev.com/a5f745c1b2dfebd09e143a0388647f70d9e488a8/chrome/browser/resources/md_downloads/vulcanized.html
,
May 12 2016
,
May 13 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00bee55721e37dd51e0665552750238588e7da59 commit 00bee55721e37dd51e0665552750238588e7da59 Author: Christian Biesinger <cbiesinger@chromium.org> Date: Fri May 13 20:25:13 2016 Give no-downloads a min-height to avoid overlapping the header. Without the min-height, we will flex-shrink the container of the image and center it outside its container, overlapping the header. BUG= 611334 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1978613002 Cr-Commit-Position: refs/heads/master@{#393356} (cherry picked from commit a5f745c1b2dfebd09e143a0388647f70d9e488a8) Review URL: https://codereview.chromium.org/1977993002 . Cr-Commit-Position: refs/branch-heads/2704@{#544} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/00bee55721e37dd51e0665552750238588e7da59/chrome/browser/resources/md_downloads/manager.css [modify] https://crrev.com/00bee55721e37dd51e0665552750238588e7da59/chrome/browser/resources/md_downloads/vulcanized.html
,
May 18 2016
Tested the same on win8.1, mac 10.11 and Linux 14.04 chrome version 51.0.2704.54 - observed that the image is not overlapping on the open download folder button in chrome://downloads Please find the screenshot Fix works as expected
,
May 18 2016
Correcting the typo in label. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by cbiesin...@chromium.org
, May 12 2016easiest fix: #no-downloads { min-height: min-content; } I initially expected that it would be the top that needs the min-height. No - that one already has it. This is a consequence of true centering in the bottom part!