Migrate page_cycler v1 benchmark to PCv2 |
||||||||
Issue descriptionNow PCv2 MVP is almost landed. Let's migrate benchmarks to use PCv2.
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7f63bfe8e95bfcdf1d1908c6191c6912ab7d808 commit d7f63bfe8e95bfcdf1d1908c6191c6912ab7d808 Author: kouhei <kouhei@chromium.org> Date: Wed May 18 14:54:56 2016 [PCv2] add benchmark page_cycler_v2.typical_25 This depends on PCv2 MVP to be landed on catapult repo, like: https://codereview.chromium.org/1963583005/ BUG= 611329 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Review-Url: https://codereview.chromium.org/1973953002 Cr-Commit-Position: refs/heads/master@{#394420} [add] https://crrev.com/d7f63bfe8e95bfcdf1d1908c6191c6912ab7d808/tools/perf/benchmarks/page_cycler_v2.py [modify] https://crrev.com/d7f63bfe8e95bfcdf1d1908c6191c6912ab7d808/tools/perf/page_sets/typical_25.py
,
May 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a8701c4bf7f89f251b660686b69b8099c64f55a commit 2a8701c4bf7f89f251b660686b69b8099c64f55a Author: skyostil <skyostil@chromium.org> Date: Thu May 19 11:15:49 2016 Revert of [PCv2] add benchmark page_cycler_v2.typical_25 (patchset #2 id:20001 of https://codereview.chromium.org/1973953002/ ) Reason for revert: This new benchmark seems to be failing on Android, Mac and Windows: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%20%281%29/builds/1100 https://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf%20%282%29/builds/8181 https://build.chromium.org/p/chromium.perf/builders/Mac%2010.11%20Perf%20%282%29/builds/1858 Original issue's description: > [PCv2] add benchmark page_cycler_v2.typical_25 > > This depends on PCv2 MVP to be landed on catapult repo, like: > https://codereview.chromium.org/1963583005/ > > BUG= 611329 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq > > Committed: https://crrev.com/d7f63bfe8e95bfcdf1d1908c6191c6912ab7d808 > Cr-Commit-Position: refs/heads/master@{#394420} TBR=eakuefner@chromium.org,kinuko@chromium.org,nednguyen@google.com,sullivan@chromium.org,kouhei@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 611329 Review-Url: https://codereview.chromium.org/1996553002 Cr-Commit-Position: refs/heads/master@{#394735} [delete] https://crrev.com/f15adc94e6c7c22940472feefcee2e59071fec0c/tools/perf/benchmarks/page_cycler_v2.py [modify] https://crrev.com/2a8701c4bf7f89f251b660686b69b8099c64f55a/tools/perf/page_sets/typical_25.py
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6be094854ca6d29a19898686ee25155030a48845 commit 6be094854ca6d29a19898686ee25155030a48845 Author: kouhei <kouhei@chromium.org> Date: Wed May 25 05:40:55 2016 [PCv2] add benchmark page_cycler_v2.typical_25 This depends on PCv2 MVP to be landed on catapult repo, like: https://codereview.chromium.org/1963583005/ BUG= 611329 Committed: https://crrev.com/d7f63bfe8e95bfcdf1d1908c6191c6912ab7d808 Cr-Commit-Position: refs/heads/master@{#394420} Review-Url: https://codereview.chromium.org/1973953002 Cr-Commit-Position: refs/heads/master@{#395807} [add] https://crrev.com/6be094854ca6d29a19898686ee25155030a48845/tools/perf/benchmarks/page_cycler_v2.py [modify] https://crrev.com/6be094854ca6d29a19898686ee25155030a48845/tools/perf/page_sets/typical_25.py
,
May 26 2016
,
May 26 2016
,
May 26 2016
,
Jul 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e902e6e9dd6919de0cacc0286bfa8cb54ebb3b0 commit 0e902e6e9dd6919de0cacc0286bfa8cb54ebb3b0 Author: kouhei <kouhei@chromium.org> Date: Thu Jul 07 03:13:01 2016 [PCv2] migrate page_cycler_v2.intl_ja_zh BUG= 611329 CQ_EXTRA_TRYBOTS omitted (relevant try bots passed) Review-Url: https://codereview.chromium.org/2097303002 Cr-Commit-Position: refs/heads/master@{#404057} [modify] https://crrev.com/0e902e6e9dd6919de0cacc0286bfa8cb54ebb3b0/tools/perf/benchmarks/page_cycler_v2.py [modify] https://crrev.com/0e902e6e9dd6919de0cacc0286bfa8cb54ebb3b0/tools/perf/page_sets/intl_ja_zh.py
,
Jul 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0f8c35e3d0d6bc3a83cd379a28adf10b92c8511 commit f0f8c35e3d0d6bc3a83cd379a28adf10b92c8511 Author: kouhei <kouhei@chromium.org> Date: Fri Jul 08 09:30:30 2016 [PCv2] migrate page_cycler_v2.intl_ar_fa_he BUG= 611329 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Review-Url: https://codereview.chromium.org/2132953002 Cr-Commit-Position: refs/heads/master@{#404322} [modify] https://crrev.com/f0f8c35e3d0d6bc3a83cd379a28adf10b92c8511/tools/perf/benchmarks/page_cycler_v2.py [modify] https://crrev.com/f0f8c35e3d0d6bc3a83cd379a28adf10b92c8511/tools/perf/page_sets/intl_ar_fa_he.py
,
Jul 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d7f91d6f392b09de362fa8c09c99dcd10c7b712 commit 2d7f91d6f392b09de362fa8c09c99dcd10c7b712 Author: kouhei <kouhei@chromium.org> Date: Mon Jul 11 10:49:49 2016 [PCv2] Migrate intl.es_fr_pt-BR page set BUG= 611329 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Review-Url: https://codereview.chromium.org/2137873002 Cr-Commit-Position: refs/heads/master@{#404630} [modify] https://crrev.com/2d7f91d6f392b09de362fa8c09c99dcd10c7b712/tools/perf/benchmarks/page_cycler_v2.py [modify] https://crrev.com/2d7f91d6f392b09de362fa8c09c99dcd10c7b712/tools/perf/page_sets/intl_es_fr_pt-BR.py
,
Jul 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/886268c2ef0f85b14c9b6e25fb6a7556e5faa8ab commit 886268c2ef0f85b14c9b6e25fb6a7556e5faa8ab Author: kouhei <kouhei@chromium.org> Date: Wed Jul 20 13:00:01 2016 [PCv2] Migrate intl.hi_ru page set BUG= 611329 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq Review-Url: https://codereview.chromium.org/2163093004 Cr-Commit-Position: refs/heads/master@{#406535} [modify] https://crrev.com/886268c2ef0f85b14c9b6e25fb6a7556e5faa8ab/tools/perf/benchmarks/page_cycler_v2.py [modify] https://crrev.com/886268c2ef0f85b14c9b6e25fb6a7556e5faa8ab/tools/perf/page_sets/intl_hi_ru.py
,
Jul 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f28066c555885a71ec315637b6d804fa59aff7e commit 9f28066c555885a71ec315637b6d804fa59aff7e Author: kouhei <kouhei@chromium.org> Date: Wed Jul 20 13:05:06 2016 [PCv2] Migrate intl.ko_th_vi page set BUG= 611329 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq Review-Url: https://codereview.chromium.org/2166723002 Cr-Commit-Position: refs/heads/master@{#406539} [modify] https://crrev.com/9f28066c555885a71ec315637b6d804fa59aff7e/tools/perf/benchmarks/page_cycler_v2.py [modify] https://crrev.com/9f28066c555885a71ec315637b6d804fa59aff7e/tools/perf/page_sets/intl_ko_th_vi.py
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/188b260fac1bfcc1951f09c403f18cfee3dd1910 commit 188b260fac1bfcc1951f09c403f18cfee3dd1910 Author: kouhei <kouhei@chromium.org> Date: Thu Jul 21 05:54:18 2016 [PCv2] Migrate top_10_mobile page set BUG= 611329 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq Review-Url: https://codereview.chromium.org/2167613002 Cr-Commit-Position: refs/heads/master@{#406774} [modify] https://crrev.com/188b260fac1bfcc1951f09c403f18cfee3dd1910/tools/perf/benchmarks/page_cycler_v2.py [modify] https://crrev.com/188b260fac1bfcc1951f09c403f18cfee3dd1910/tools/perf/page_sets/top_10_mobile.py
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/477b73c6fb1908b3fd8013f0c44c9e074a56971e commit 477b73c6fb1908b3fd8013f0c44c9e074a56971e Author: kouhei <kouhei@chromium.org> Date: Fri Jul 22 00:02:55 2016 [PCv2] Migrate tough_layout_cases page set BUG= 611329 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq Review-Url: https://codereview.chromium.org/2164903002 Cr-Commit-Position: refs/heads/master@{#406998} [modify] https://crrev.com/477b73c6fb1908b3fd8013f0c44c9e074a56971e/tools/perf/benchmarks/page_cycler_v2.py [modify] https://crrev.com/477b73c6fb1908b3fd8013f0c44c9e074a56971e/tools/perf/page_sets/tough_layout_cases.py
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6427de2921175dedd5d5b1f258211ea7ac70bbb0 commit 6427de2921175dedd5d5b1f258211ea7ac70bbb0 Author: kouhei <kouhei@chromium.org> Date: Fri Jul 22 03:42:52 2016 [PCv2] Migrate OopifBasicPageSet BUG= 611329 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq Review-Url: https://codereview.chromium.org/2164913002 Cr-Commit-Position: refs/heads/master@{#407038} [modify] https://crrev.com/6427de2921175dedd5d5b1f258211ea7ac70bbb0/tools/perf/benchmarks/page_cycler_v2.py [modify] https://crrev.com/6427de2921175dedd5d5b1f258211ea7ac70bbb0/tools/perf/page_sets/oopif_basic_page_set.py
,
Jul 22 2016
We now have a PCv2 benchmark corresponding to all PCv1 benchmarks. Let me start removing PCv1 benchmarks where we have >2 week of overlap.
,
Jul 22 2016
SGTM. Can you send an announcement to telemetry-announce@chromium.org?
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3cb77b5d7c94d201a94b72ebae383b9a0601b9f commit b3cb77b5d7c94d201a94b72ebae383b9a0601b9f Author: kouhei <kouhei@chromium.org> Date: Tue Jul 26 10:56:32 2016 Remove page_cycler.intl_{ja_zh,es_fr_pt-BR,ar_fa_he} PCv1 benchmarks The benchmarks have corresponding PCv2 benchmarks running >2 weeks. BUG= 611329 Review-Url: https://codereview.chromium.org/2181223002 Cr-Commit-Position: refs/heads/master@{#407763} [modify] https://crrev.com/b3cb77b5d7c94d201a94b72ebae383b9a0601b9f/tools/perf/benchmarks/page_cycler.py
,
Aug 1 2016
Note, before removing the old page cycler metrics, we should also get support for OS-level memory metric in memory-infra for Win and Mac.
,
Aug 1 2016
There is no need to keep the old memory metrics of page cycler v1 in page cycler v2, so what you said is nice but shouldn't block this effort.
,
Aug 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f00d65e14a65a308a1f7b9e07c96859fff8b5280 commit f00d65e14a65a308a1f7b9e07c96859fff8b5280 Author: kouhei <kouhei@chromium.org> Date: Tue Aug 02 01:08:44 2016 Re-enable some PCv1 benchmarks for CrOS This CL re-enables page_cycler.intl_{ja_zh,es_fr_pt-BR,ar_fa_he} PCv1 benchmarks for ChromeOS This is a temporary solution until crbug.com/632815 is resolved TBR=nednguyen@google.com BUG= 632815 , 611329 Review-Url: https://codereview.chromium.org/2203593002 Cr-Commit-Position: refs/heads/master@{#409108} [modify] https://crrev.com/f00d65e14a65a308a1f7b9e07c96859fff8b5280/tools/perf/benchmarks/page_cycler.py
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f535b4682cf74ffd1c3b1afd02df602e70519a6 commit 2f535b4682cf74ffd1c3b1afd02df602e70519a6 Author: petrcermak <petrcermak@chromium.org> Date: Fri Aug 05 13:42:18 2016 [perf] Disable legacy page_cycler on all platforms except for Chrome OS Rationale: It has been superseded by Page Cycler v2. BUG= 634310 , 611329 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq TBR=nednguyen@google.com Review-Url: https://codereview.chromium.org/2211673003 Cr-Commit-Position: refs/heads/master@{#410048} [modify] https://crrev.com/2f535b4682cf74ffd1c3b1afd02df602e70519a6/tools/perf/benchmarks/page_cycler.py
,
Aug 10 2016
,
Aug 11 2016
,
Aug 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8e83d9cc50f8a57c92a126d5a70280960c53fb4 commit a8e83d9cc50f8a57c92a126d5a70280960c53fb4 Author: nednguyen <nednguyen@google.com> Date: Fri Aug 12 08:32:06 2016 [tools/perf] Remove page_cycler benchmarks and measurement These page_cycler benchmarks are superseded by the page_cycler_v2 benchmarks. BUG= 611329 Review-Url: https://codereview.chromium.org/2243713002 Cr-Commit-Position: refs/heads/master@{#411582} [delete] https://crrev.com/a6835aa0d7bfc748ec58e088a82305c76094924b/tools/perf/benchmarks/page_cycler.py [delete] https://crrev.com/a6835aa0d7bfc748ec58e088a82305c76094924b/tools/perf/measurements/page_cycler.py [delete] https://crrev.com/a6835aa0d7bfc748ec58e088a82305c76094924b/tools/perf/measurements/page_cycler_unittest.py
,
Aug 12 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kouhei@chromium.org
, May 12 2016Components: Blink>Loader
Labels: -Type-Bug Test-Performance OS-All Type-Feature