New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611326 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Migrate WebRTC Chromium bots to GN

Project Member Reported by kjellander@chromium.org, May 12 2016

Issue description

Tracking bug for migrating along with Chromium for our bots in chromium.webrtc and chromium.webrtc.fyi.

We need to follow the flipping of bots in Chromium to ensure we're protected against breakages when rolling WebRTC in Chromium DEPS.
 
Project Member

Comment 2 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87782

------------------------------------------------------------------
r87782 | recipe-roller@chromium.org | 2016-05-12T09:42:54.005718Z

-----------------------------------------------------------------
Project Member

Comment 3 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d1997c3c08db52d2f6ea08da6415487dda64108

commit 3d1997c3c08db52d2f6ea08da6415487dda64108
Author: kjellander <kjellander@chromium.org>
Date: Fri May 13 08:58:13 2016

MB: Add configuration for chromium.webrtc waterfall.

Add the bots in the chromium.webrtc waterfall to make it possible
to enable MB for them.

Remove the no longer existing Android GN bots in chromium.webrtc.fyi

BUG= 611326 
NOTRY=True

Review-Url: https://codereview.chromium.org/1980443002
Cr-Commit-Position: refs/heads/master@{#393482}

[modify] https://crrev.com/3d1997c3c08db52d2f6ea08da6415487dda64108/tools/mb/mb_config.pyl

Project Member

Comment 4 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/4b216a3de6ad78f16e5b41c036782634a68f0f8c

commit 4b216a3de6ad78f16e5b41c036782634a68f0f8c
Author: kjellander@chromium.org <kjellander@chromium.org>
Date: Fri May 13 09:43:15 2016

WebRTC: Enable MB on our remaining Chromium builders.

MB needs to be used to flip to GN.

Remove the building of the 'chromium_builder_webrtc' target since
it doesn't exist in GN. It's just a legacy convenience target that used
to be needed to get the tools 'frame_analyzer' and 'rgba_to_i420_converter'
built. Today they're already built since configured for the bots in
https://code.google.com/p/chromium/codesearch#chromium/src/testing/buildbot/chromium.webrtc.json
https://code.google.com/p/chromium/codesearch#chromium/src/testing/buildbot/chromium.webrtc.fyi.json

MB configs are being added in https://codereview.chromium.org/1980443002/

BUG= 611326 

Review-Url: https://codereview.chromium.org/1968293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300572 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/4b216a3de6ad78f16e5b41c036782634a68f0f8c/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
[modify] https://crrev.com/4b216a3de6ad78f16e5b41c036782634a68f0f8c/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py
[modify] https://crrev.com/4b216a3de6ad78f16e5b41c036782634a68f0f8c/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Builder.json
[modify] https://crrev.com/4b216a3de6ad78f16e5b41c036782634a68f0f8c/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Mac_Builder.json
[modify] https://crrev.com/4b216a3de6ad78f16e5b41c036782634a68f0f8c/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win_Builder.json
[modify] https://crrev.com/4b216a3de6ad78f16e5b41c036782634a68f0f8c/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Linux_Builder.json
[modify] https://crrev.com/4b216a3de6ad78f16e5b41c036782634a68f0f8c/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_Builder.json
[modify] https://crrev.com/4b216a3de6ad78f16e5b41c036782634a68f0f8c/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_Builder.json

Project Member

Comment 5 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87834

------------------------------------------------------------------
r87834 | recipe-roller@chromium.org | 2016-05-13T10:03:09.144440Z

-----------------------------------------------------------------
Status: Fixed (was: Assigned)
This work was completed a while back.

Sign in to add a comment