New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 611315 link

Starred by 1 user
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Jul 2016
Cc:
rdevlin....@chromium.org
nyerramilli@chromium.org
dbeam@chromium.org
█ ashej...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Clear search (X) button is not working as intended in chrome://downloads page.

Reported by dchau...@etouch.net, May 12 2016 
Chrome Version:51.0.2704.47 (Official Build)23ee1b3315bb84717e9a03a7f4a6dcc066823ee0-refs/branch-heads/2704@{#513} 32/64-bit.
OS: Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux(Ubuntu 14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://downloads page.
2. Click on search icon at top RHS and type anything in search box.
3. Now, click on clear search (X) button and observe.

Unnecessary search box gets closed after clicking on close (X) button(only text should clear).
Only search text should clear after clicking on clear search (X) button.

Note: Instead of closing the search box, only search text should get cleared in search box.

This is a regression issue, seen from M-50 series, below is bisect info.

Good build: 50.0.2657.0
Bad build: 50.0.2658.0

Narrow bisect: 
https://chromium.googlesource.com/chromium/src/+log/e4fec04138c05a31edf8942afef26914e8b38e52..2798da0054168aacd32e6c51c5a87befe415b1eb?pretty=fuller&n=100

Suspecting: r376895

Kindly review the attached screen-cast for reference.
Actual_behavior.mp4
415 KB Download

Comment 1 by dbeam@chromium.org, May 12 2016

Cc: rdevlin....@chromium.org dbeam@chromium.org
Labels: -Pri-1 -hasbisect Needs-Bisect Needs-Feedback Pri-2
Owner: dchau...@etouch.net
not reproducing on stable nor canary (Windows, Linux) for me.

it's possible it was broken briefly in the middle of stable (50) and canary (52), but that seems odd to me.

also, I don't think your bisect was right (that's the CL that enables Material Design downloads).  you should re-run bisect-builds.py with "-- --enable-md-downloads" at the end.

Comment 2 by dchau...@etouch.net, May 13 2016

Labels: -Needs-Feedback -Needs-Bisect hasbisect
Owner: dbeam@chromium.org
With response to comment #1: Retested the above issue on Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux(Ubuntu 14.04 LTS) with latest canary chrome version: 52.0.2735.0 (Official Build), It's still reproducible.

Attaching screen-cast for reference.
 
Rebisected the above issue and found the range below.
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/f1311d7b09a63b1eb301892c468c712fdd6ba7fb..6e3d2360717f4b96d0172614f25fc81673cdf02f?pretty=fuller&n=100

Suspecting: r345732

Correction in Manual regression range:
Good build: 47.0.2494.0
Bad build:  47.0.2495.0
Latest Canary behavior.mp4
393 KB Download

Comment 3 by dbeam@chromium.org, Jul 26 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7638d4b996143a2e38869215426720de854dd818

commit 7638d4b996143a2e38869215426720de854dd818
Author: dbeam <dbeam@chromium.org>
Date: Tue Jul 26 17:09:56 2016

MD WebUI: rework how clearing search works

Previously, when clicking (X) to clear search text, the search field
closed / hid its UI. It should just clear the text, as it says.
Pressing Esc should continue to clear+close completely, though.

Additionally, we should only show (x) when there's text to hide.
We should also re-focus the search when (x) is clicked (otherwise
focus gets dropped).

R=tsergeant@chromium.org
BUG= 611315 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2182853002
Cr-Commit-Position: refs/heads/master@{#407836}

[modify] https://crrev.com/7638d4b996143a2e38869215426720de854dd818/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/7638d4b996143a2e38869215426720de854dd818/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/7638d4b996143a2e38869215426720de854dd818/ui/webui/resources/cr_elements/cr_search_field/cr_search_field.html
[modify] https://crrev.com/7638d4b996143a2e38869215426720de854dd818/ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js
[modify] https://crrev.com/7638d4b996143a2e38869215426720de854dd818/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

Comment 5 by dbeam@chromium.org, Jul 26 2016

Status: Fixed (was: Started)
►

Sign in to add a comment