New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611300 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2 is Flaky

Project Member Reported by tapted@chromium.org, May 12 2016

Issue description

in https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29?numbuilds=200

Failures at

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/23961
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/23973
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/23974

Looks like

TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2 (run #1):
[ RUN      ] TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2
[53374:1287:0511/174454:7378225237008:WARNING:vt_video_decode_accelerator_mac.cc(161)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "The operation couldn?t be completed. (OSStatus error -8973.)" (codecOpenErr) (-8973)
[53374:1287:0511/174454:7378226457528:WARNING:vt_video_decode_accelerator_mac.cc(196)] Failed to create hardware VideoToolbox session
[53374:1287:0511/174454:7378284408322:ERROR:vt_video_encode_accelerator_mac.cc(518)]  VTCompressionSessionCreate failed: -12908
[53371:1287:0511/174454:7378741085222:WARNING:render_frame_host_impl.cc(1825)] OnDidStopLoading was called twice.
[53371:1287:0511/174454:7378811143936:WARNING:render_frame_host_impl.cc(1825)] OnDidStopLoading was called twice.
[53371:1287:0511/174455:7379431958353:WARNING:render_frame_host_impl.cc(1825)] OnDidStopLoading was called twice.
[53371:1287:0511/174455:7379439715726:WARNING:render_frame_host_impl.cc(1825)] OnDidStopLoading was called twice.
../../content/browser/top_document_isolation_browsertest.cc:381: Failure
Value of: DepictFrameTree(root())
  Actual: " Site D ------------ proxies for C
Where C = http://c.com/
      D = http://d.com/"
Expected: " Site D
" "Where D = http://d.com/"
Which is: " Site D
Where D = http://d.com/"
With diff:
@@ -1,2 +1,3 @@
- Site D
-Where D = http://d.com/
+ Site D ------------ proxies for C
+Where C = http://c.com/
+      D = http://d.com/

[  FAILED  ] TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2, where TypeParam =  and GetParam() =  (1836 ms)
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fa5fb14fc313ba1d8c9b8a773c82c433ee18918

commit 5fa5fb14fc313ba1d8c9b8a773c82c433ee18918
Author: tapted <tapted@chromium.org>
Date: Thu May 12 08:44:48 2016

Disable flaky TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2 on Mac

TBR=nick@chromium.org
BUG= 611300 

Review-Url: https://codereview.chromium.org/1972043002
Cr-Commit-Position: refs/heads/master@{#393209}

[modify] https://crrev.com/5fa5fb14fc313ba1d8c9b8a773c82c433ee18918/content/browser/top_document_isolation_browsertest.cc

Comment 2 by tapted@chromium.org, May 12 2016

Cc: nick@chromium.org
 Issue 611313  has been merged into this issue.

Comment 3 by nick@chromium.org, May 12 2016

Thanks for the bug report.
Project Member

Comment 4 by chromium...@appspot.gserviceaccount.com, May 13 2016

Labels: Sheriff-Chromium
Detected 6 new flakes for test/step "TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRAsSBUZsYWtlIjlUb3BEb2N1bWVudElzb2xhdGlvblRlc3QuTmF2aWdhdGVUb1N1YmZyYW1lU2l0ZVdpdGhQb3B1cDIM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 5 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbfe0ebcc13fa160a634f3268167ec7d2aeb3220

commit cbfe0ebcc13fa160a634f3268167ec7d2aeb3220
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri May 13 12:08:37 2016

Disable flaky TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2 on Windows.

TBR=nick@chromium.org
BUG= 611300 

Review URL: https://codereview.chromium.org/1973283002 .

Cr-Commit-Position: refs/heads/master@{#393503}

[modify] https://crrev.com/cbfe0ebcc13fa160a634f3268167ec7d2aeb3220/content/browser/top_document_isolation_browsertest.cc

Labels: -Sheriff-Chromium OS-Windows
Summary: TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2 is Flaky (was: TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2 is Flaky on Mac10.9 Tests(dbg))
This test is flaky on Android and occasionally flaky on Linux (although it has flaked 3x in a row, just once or twice in a single test run):
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=NavigateToSubframeSiteWithPopup2

Disabling it on all platforms.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a59a076187e7f946fcf614077de1b482b2bceb91

commit a59a076187e7f946fcf614077de1b482b2bceb91
Author: twellington <twellington@chromium.org>
Date: Wed Aug 10 21:46:55 2016

Disable TopDocumentIsolationTest#NavigateToSubframeSiteWithPopup2

This test is flaky on all platforms.

BUG= 611300 
TBR=nick@chromium.org

Review-Url: https://codereview.chromium.org/2236023002
Cr-Commit-Position: refs/heads/master@{#411153}

[modify] https://crrev.com/a59a076187e7f946fcf614077de1b482b2bceb91/content/browser/top_document_isolation_browsertest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a65c0019399f0a7052ab13bc73439acb116adb8

commit 7a65c0019399f0a7052ab13bc73439acb116adb8
Author: creis <creis@chromium.org>
Date: Sat Nov 05 00:23:04 2016

Fix flaky OOPIF tests by waiting for the old RenderFrame to be deleted.

This fixes:
SitePerProcessBrowserTest.CrossSiteIframe
SitePerProcessBrowserTest.NavigateRemoteFrame
SitePerProcessBrowserTest.RFPHDestruction
TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2
TopDocumentIsolationTest.FramesForSitesInHistory

BUG=662550, 629419,  611300 ,  611344 
TEST=Bots stay green.

Review-Url: https://codereview.chromium.org/2478933002
Cr-Commit-Position: refs/heads/master@{#430081}

[modify] https://crrev.com/7a65c0019399f0a7052ab13bc73439acb116adb8/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/7a65c0019399f0a7052ab13bc73439acb116adb8/content/browser/top_document_isolation_browsertest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6abe5bfc52cc830ee64a6277e19a8ad0fa71e2f

commit c6abe5bfc52cc830ee64a6277e19a8ad0fa71e2f
Author: mathp <mathp@chromium.org>
Date: Sat Nov 05 03:40:37 2016

Revert of Fix flaky OOPIF tests by waiting for the old RenderFrame to be deleted. (patchset #1 id:1 of https://codereview.chromium.org/2478933002/ )

Reason for revert:
Causing flakiness still:

https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/23876

Original issue's description:
> Fix flaky OOPIF tests by waiting for the old RenderFrame to be deleted.
>
> This fixes:
> SitePerProcessBrowserTest.CrossSiteIframe
> SitePerProcessBrowserTest.NavigateRemoteFrame
> SitePerProcessBrowserTest.RFPHDestruction
> TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2
> TopDocumentIsolationTest.FramesForSitesInHistory
>
> BUG=662550, 629419,  611300 ,  611344 
> TEST=Bots stay green.
>
> Committed: https://crrev.com/7a65c0019399f0a7052ab13bc73439acb116adb8
> Cr-Commit-Position: refs/heads/master@{#430081}

TBR=lukasza@chromium.org,creis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=662550, 629419,  611300 ,  611344 

Review-Url: https://codereview.chromium.org/2479863003
Cr-Commit-Position: refs/heads/master@{#430145}

[modify] https://crrev.com/c6abe5bfc52cc830ee64a6277e19a8ad0fa71e2f/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/c6abe5bfc52cc830ee64a6277e19a8ad0fa71e2f/content/browser/top_document_isolation_browsertest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29f856890eb1f7c96c3853314a10e782d53cb1eb

commit 29f856890eb1f7c96c3853314a10e782d53cb1eb
Author: creis <creis@chromium.org>
Date: Tue Nov 08 01:52:42 2016

Fix flaky OOPIF tests by waiting for the old RenderFrame to be deleted.

This fixes:
SitePerProcessBrowserTest.CrossSiteIframe
SitePerProcessBrowserTest.NavigateRemoteFrame
SitePerProcessBrowserTest.RFPHDestruction
TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2
TopDocumentIsolationTest.FramesForSitesInHistory

BUG=662550, 629419,  611300 ,  611344 
TEST=Bots stay green.

Committed: https://crrev.com/7a65c0019399f0a7052ab13bc73439acb116adb8
Review-Url: https://codereview.chromium.org/2478933002
Cr-Original-Commit-Position: refs/heads/master@{#430081}
Cr-Commit-Position: refs/heads/master@{#430474}

[modify] https://crrev.com/29f856890eb1f7c96c3853314a10e782d53cb1eb/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/29f856890eb1f7c96c3853314a10e782d53cb1eb/content/browser/top_document_isolation_browsertest.cc

Comment 12 by creis@chromium.org, Nov 11 2016

Owner: creis@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment