New issue
Advanced search Search tips

Issue 611280 link

Starred by 1 user
Status: Fixed
Owner:
karandeepb@chromium.org
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 603373



Sign in to add a comment

MacViews: Permissions bubble button starts with focus even when full keyboard access is off

Project Member Reported by tapted@chromium.org, May 12 2016 
Chrome Version       : 52.0.2733.0
OS Version: OS X 10.11.4

Unlike http-auth and the bookmark bubble, this/these bubbles have no textfield that should be focused, so a button gets a focus ring. But really nothing should have one.

What steps will reproduce the problem?
1. chrome://flags/#mac-views-dialogs Enabled . Ensure OSX Full Keyboard Access is off.
2. Go to wwww.google.com and click the microphone 
3. Click the camera icon that appears next to the bookmark star to get a bubble

What is the expected result?

No control has a focus ring

What happens instead of that?

The Done/Finished default dialog button has a focus ring

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2733.0 Safari/537.36
Screen Shot 2016-05-12 at 1.00.20 PM.png
31.2 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b

commit 8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b
Author: karandeepb <karandeepb@chromium.org>
Date: Mon May 16 01:14:44 2016

Views: Change View::RequestFocus to respect keyboard accessibility.

This CL fixes some regressions introduced in http://crrev.com/1894383002/. These
regression are caused due to the change in View::RequestFocus() from
IsFocusable() to IsAccessibilityFocusable().

On a mouse click on a CustomButton, CustomButton::MousePressed() requests focus
on the button, if it has request_focus_on_press_ set to true. It turns out that
most button subclasses, do not explicitly set request_focus_on_press_ to false,
which has a default value of true. These custom buttons which are accessibility
focusable, can now gain focus on a mouse press, hence the bug.

This CL changes View::RequestFocus to use IsFocusable when keyboard
accessibility is off (i.e on Non-Mac platforms), hence fixing bugs  609701 ,
610186, 610235, 610740, 610802, 610664. This is how View::RequestFocus behaved
before crrev.com/1894383002 on Non-Mac platforms. Also, on Mac, since
View::RequestFocus now respects keyboard accessibility,  bug 611280  is also
fixed.

BUG= 609701 ,  610186 ,  610235 ,  610740 ,  610802 ,  610664 ,  564912 ,  611280 

Review-Url: https://codereview.chromium.org/1973073003
Cr-Commit-Position: refs/heads/master@{#393781}

[modify] https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b/chrome/browser/ui/views/tabs/tab_unittest.cc
[modify] https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b/ui/views/focus/focus_manager.cc
[modify] https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b/ui/views/focus/focus_manager_unittest.cc
[modify] https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b/ui/views/view.cc

Comment 2 by karandeepb@chromium.org, May 16 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment