New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611277 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

sheriff-o-matic should emphasize that chromium sheriffs should also deal w/ WebKit bot failures.

Project Member Reported by dpranke@chromium.org, May 12 2016

Issue description

It seems like we still have a number of Chromium sheriffs who don't realize that they should be dealing with failures on the Webkit/Blink bots, even if they are showing up
on the main Chromium tab.

Can we conditionally add an alert at the top of the tab that shows up if there are any failures on the chromium.webkit bots that says something like "Chromium sheriffs: you now need to handle WebKit bot failures too. See http://www.chromium.org/blink/sheriffing" ?
 

Comment 1 by jpar...@google.com, May 12 2016

Seems reasonable to me.

Comment 2 by ojan@chromium.org, May 12 2016

They are using sheriff-o-matic but ignoring certain failures in the chromium tab or they're not using sheriff-o-matic?
I believe most sheriffs know to use s-o-m but think they can or should ignore certain failures.

So, other suggestions that also help convey that "fix everything" is the job are also appropriate.

Comment 4 by tapted@chromium.org, May 12 2016

Ooh a link would be nice :). This was my first combined sheriff/gardener shift and it took me a long time to figure out how to deal with a flaky test on Webkit Leak.

http://www.chromium.org/blink/sheriffing goes to [the documentation of the Test Expectations files](https://sites.google.com/a/chromium.org/dev/developers/testing/webkit-layout-tests/testexpectations) which would have helped.

That says "If multiple expectations are listed, the test is considered "flaky"" but more helpful would be if it called out an example of how to suppress a flaky test.

Maybe some of this could even go at the top of the FooExpecations files. LeakExpecations even says at the top

# Gardeners are welcome to touch this file, but you can ignore the failures
# and wait for kouhei@ or hajimehoshi@ to maintain this file.

which is probably out of date :).


(https://sites.google.com/a/chromium.org/dev/developers/testing/webkit-layout-tests/testexpectations also says "We do not generally expect chromium sheriffs to spend time trying to address flakiness, though." which is perhaps also out of date, or a bit ambiguous.)

Comment 5 by ojan@chromium.org, May 13 2016

I think we need each failure to have a link to handle failures in that specific test suite. Each test suite has it's own way of disabling tests. Unless we fix that, we need to have per test suite documentaiton and sheriff-o-matic should link to it.
Seems fair.

Comment 7 by jpar...@google.com, Jun 22 2016

Cc: zhangtiff@google.com
Status: Assigned (was: Untriaged)
Tiffany, can you take this one?
Sure, I can work on this. 
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/418d7294a8c74b2ef50cb355b7f6832e050debc6

commit 418d7294a8c74b2ef50cb355b7f6832e050debc6
Author: zhangtiff <zhangtiff@google.com>
Date: Thu Jun 23 23:58:46 2016

SoM: Added notice about chromium webkit failures + documentation links.

Notices appear at the top for trees with chromium.webkit failures. [Help] links also now exist beside the title per Ojan's suggestion in the bug thread though these currently only appear for webkit failures.

BUG= 611277 

Review-Url: https://codereview.chromium.org/2081383004

[modify] https://crrev.com/418d7294a8c74b2ef50cb355b7f6832e050debc6/go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item.html
[modify] https://crrev.com/418d7294a8c74b2ef50cb355b7f6832e050debc6/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html

I've made the change originally requested and started working on the documentation links for test failures suggested by Ojan. 

Feel free to post suggestions if there are any specific pages that you think should be linked for certain kinds of test failures. 
Status: Available (was: Assigned)
Components: Infra>Sheriffing>SheriffOMatic
Components: -Infra>Sheriffing
Owner: zhangtiff@chromium.org
Status: Started (was: Available)
Status: Fixed (was: Started)
Marking this as fixed. 

Sign in to add a comment