New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611268 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

No "Language Settings" in Mac Translation Bubble

Project Member Reported by ftang@chromium.org, May 12 2016

Issue description

Version: 50.0.2661.94
OS: MacOS
What steps will reproduce the problem?
(1) Go to chrome://flags and change "New Translate UX" to "Enabled" and click "Relaunch"
(2) visit a foreign language page such as www.yahoo.co.jp and see the translation bubble. Click "option" to the advanced view.

What is the expected output?
A "language settings" link point to chrome://settings/languages
What do you see instead?
No such link on Mac Translation Bubble.


Please use labels and text to provide additional information.

 

Comment 1 by ftang@chromium.org, May 12 2016

screen shot per request
Screen Shot 2016-05-11 at 7.25.56 PM.png
151 KB View Download

Comment 2 by ftang@chromium.org, May 12 2016

Ignore the "Always translate" change to "Always do this" in the scrheenshot. That issue was fixed by 1963183002 yesterday but my Mac tree has not pull that change yet.

Comment 3 by ftang@chromium.org, May 12 2016

Components: UI>Browser>Translate

Comment 4 by ftang@chromium.org, May 20 2016

screenshot with Patchset 6.
Screen Shot 2016-05-20 at 10.36.32 AM.png
18.3 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e83e46d01ab24945c9e1e3b456e5ecdb2c2a373a

commit e83e46d01ab24945c9e1e3b456e5ecdb2c2a373a
Author: ftang <ftang@chromium.org>
Date: Thu Jun 23 17:11:15 2016

add 'langauge settings' link to the translate bubble advanced view

BUG= 611268 

Review-Url: https://codereview.chromium.org/1975653002
Cr-Commit-Position: refs/heads/master@{#401635}

[modify] https://crrev.com/e83e46d01ab24945c9e1e3b456e5ecdb2c2a373a/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

Comment 6 by ftang@chromium.org, Jun 29 2016

Status: Fixed (was: Assigned)
Components: -UI>Browser>Translate UI>Browser>Language>Translate

Sign in to add a comment