New issue
Advanced search Search tips

Issue 611259 link

Starred by 1 user
Status: Fixed
Owner:
karandeepb@chromium.org
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MacViews: Buttons should not receive focus on click.

Project Member Reported by karandeepb@chromium.org, May 12 2016 
Version: 52.0.2719.0
OS: Mac

On Cocoa, buttons generally don't receive focus on clicks. It needs to be checked whether there is any case for which buttons do receive focus on clicks.

MacViews should match Cocoa behavior for this case.
Project Member

Comment 1 by bugdroid1@chromium.org, May 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3963480dc371af9a4569ac91d982720b66783928

commit 3963480dc371af9a4569ac91d982720b66783928
Author: karandeepb <karandeepb@chromium.org>
Date: Fri May 20 02:59:46 2016

MacViews: Make buttons not request focus on mouse press.

On Cocoa, buttons never request focus on a mouse press. This CL changes
CustomButton::set_request_on_press to ensure buttons in MacViews also follow
this behavior.

BUG= 611259 

Review-Url: https://codereview.chromium.org/1994463002
Cr-Commit-Position: refs/heads/master@{#394971}

[modify] https://crrev.com/3963480dc371af9a4569ac91d982720b66783928/ui/views/controls/button/custom_button.h

Comment 2 by karandeepb@chromium.org, May 22 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment