New issue
Advanced search Search tips

Issue 611258 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 425627



Sign in to add a comment

Use vector icons for MD Settings > Internet

Project Member Reported by dschuyler@chromium.org, May 12 2016

Issue description

In the mocks for ChromeOS internet settings there is an icon for Wi-Fi, could we also get icon (decisions) for Ethernet, Cellular and VPN?

There are also some dot-icons elsewhere in the mocks that could get icons specified.

Link to mocks, for reference:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Internet%20Connection.png%3Fz=width&c=show

 

Comment 1 by bettes@chromium.org, May 16 2016

Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)
ethernet - icons:settings-ethernet
cellular - device:signal-cellular-0-bar (and the whole set) 
vpn - communication:vpn-key
Add connection - icons:add

Labels: Hotlist-MD-Settings-Internet
Blocking:
Owner: steve...@chromium.org
Steven, I think(?) this would be a better fit for your work with the network settings.
Feel free to set the owner back to me if not.
Labels: M-55
Labels: -M-55 -Pri-3 M-56 OS-Chrome Pri-2
Summary: Use vector icons for MD Settings > Internet (was: Which icons should be used for Internet settings)
Blocking: -521040 425627
Making this block  issue 425627  independent of "internet settings"

Labels: -M-56 57
Labels: -57 M-57
Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/538eb1d73a24d96237bc9f76bbc080f76916998f

commit 538eb1d73a24d96237bc9f76bbc080f76916998f
Author: stevenjb <stevenjb@chromium.org>
Date: Fri Jan 06 06:22:59 2017

MD Settings: Switch cr_network_icon to use svg icons

Note: This affects the sizing of the icons some, requiring a few layout changes, but they are mostly minor.

Tested in MD Settings, Options (old settiings), OOBE, and chrome://network.

BUG= 611258 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2592383003
Cr-Commit-Position: refs/heads/master@{#441889}

[modify] https://crrev.com/538eb1d73a24d96237bc9f76bbc080f76916998f/chrome/browser/resources/chromeos/network_ui/network_ui.css
[modify] https://crrev.com/538eb1d73a24d96237bc9f76bbc080f76916998f/chrome/browser/resources/options/browser_options.css
[modify] https://crrev.com/538eb1d73a24d96237bc9f76bbc080f76916998f/chrome/browser/resources/options/chromeos/network_list.js
[modify] https://crrev.com/538eb1d73a24d96237bc9f76bbc080f76916998f/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/538eb1d73a24d96237bc9f76bbc080f76916998f/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/538eb1d73a24d96237bc9f76bbc080f76916998f/chrome/browser/resources/settings/internet_page/network_summary_item.html
[modify] https://crrev.com/538eb1d73a24d96237bc9f76bbc080f76916998f/chromeos/dbus/fake_shill_manager_client.cc
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements/network/badge_1x.png
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements/network/badge_3g.png
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements/network/badge_4g.png
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements/network/badge_edge.png
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements/network/badge_evdo.png
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements/network/badge_gsm.png
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements/network/badge_hspa.png
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements/network/badge_hspa_plus.png
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements/network/badge_lte.png
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements/network/badge_lte_advanced.png
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements/network/badge_roaming.png
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements/network/badge_secure.png
[modify] https://crrev.com/538eb1d73a24d96237bc9f76bbc080f76916998f/ui/webui/resources/cr_elements/network/compiled_resources2.gyp
[modify] https://crrev.com/538eb1d73a24d96237bc9f76bbc080f76916998f/ui/webui/resources/cr_elements/network/cr_network_icon.html
[modify] https://crrev.com/538eb1d73a24d96237bc9f76bbc080f76916998f/ui/webui/resources/cr_elements/network/cr_network_icon.js
[modify] https://crrev.com/538eb1d73a24d96237bc9f76bbc080f76916998f/ui/webui/resources/cr_elements/network/cr_network_list_item.html
[modify] https://crrev.com/538eb1d73a24d96237bc9f76bbc080f76916998f/ui/webui/resources/cr_elements/network/cr_network_list_item.js
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements/network/ethernet.png
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements/network/mobile.png
[add] https://crrev.com/538eb1d73a24d96237bc9f76bbc080f76916998f/ui/webui/resources/cr_elements/network/network_icons.html
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements/network/vpn.png
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements/network/wifi.png
[delete] https://crrev.com/1c0d372b93e0271311c106b02e140b551530d47b/ui/webui/resources/cr_elements_images_chromeos.grdp
[modify] https://crrev.com/538eb1d73a24d96237bc9f76bbc080f76916998f/ui/webui/resources/cr_elements_resources.grdp
[modify] https://crrev.com/538eb1d73a24d96237bc9f76bbc080f76916998f/ui/webui/resources/webui_resources.grd

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment