New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 611236 link

Starred by 1 user
Status: Verified
Owner:
r...@chromium.org
Closed: May 2016
Cc:
snanda@chromium.org
█ kalq@chromium.org
r...@chromium.org
█ mcchou@chromium.org
puthik@chromium.org
█ scheib@chromium.org
█ ortuno@chromium.org
█ zelidrag@chromium.org
█ jleong@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Parse Descriptor permissions from the Chrome API.

Project Member Reported by r...@chromium.org, May 11 2016 
Currently we don't have a way to specify permissions when creating descriptors from the Chrome API. This leads to not being able to use descriptors since creating a descriptor with no permissions, a.) doesn't make any sense and b.) fails in BlueZ.

We need to add the permissions enum to the BluetoothLowEnergy Chrome API and then set the permissions correctly when creating a descriptor.

Comment 1 by r...@chromium.org, May 11 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f274924652e85ad4adf56bcebba3d6efbce5b3e

commit 2f274924652e85ad4adf56bcebba3d6efbce5b3e
Author: rkc <rkc@chromium.org>
Date: Thu May 12 22:42:11 2016

IDL changes for BLE GATT server support.

This CL adds some missing parts from the BTLE IDL required for GATT server
support.

.) It adds the permissions enum for descriptors. Without specifying this,
creating a descriptor has no point, since it can't be read from or written
to.
.) It adds the removeService and the notifyCharactersticValueChanged
functions that are there in the design but were missing from the IDL.

R=rdevlin.cronin@chromium.org
BUG=596742, 611236 

Review-Url: https://codereview.chromium.org/1966893003
Cr-Commit-Position: refs/heads/master@{#393381}

[modify] https://crrev.com/2f274924652e85ad4adf56bcebba3d6efbce5b3e/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc
[modify] https://crrev.com/2f274924652e85ad4adf56bcebba3d6efbce5b3e/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.h
[modify] https://crrev.com/2f274924652e85ad4adf56bcebba3d6efbce5b3e/chrome/common/extensions/api/bluetooth_low_energy.idl
[modify] https://crrev.com/2f274924652e85ad4adf56bcebba3d6efbce5b3e/chrome/test/data/extensions/api_test/bluetooth_low_energy/create_descriptor/runtest.js
[modify] https://crrev.com/2f274924652e85ad4adf56bcebba3d6efbce5b3e/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/2f274924652e85ad4adf56bcebba3d6efbce5b3e/tools/metrics/histograms/histograms.xml
Project Member

Comment 3 by bugdroid1@chromium.org, May 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ab68fd392b589b868e6e3c441e13a76dc38a448

commit 2ab68fd392b589b868e6e3c441e13a76dc38a448
Author: rkc <rkc@chromium.org>
Date: Thu May 12 23:20:12 2016

Add permission parsing and the removeService API.

This CL adds and fixes permission and property parsing for local GATT
characteristics and descriptors. It also implements and adds a test for
the removeService API.

R=xiyuan@chromium.org
BUG= 611236 

Review-Url: https://codereview.chromium.org/1976453002
Cr-Commit-Position: refs/heads/master@{#393391}

[modify] https://crrev.com/2ab68fd392b589b868e6e3c441e13a76dc38a448/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc
[modify] https://crrev.com/2ab68fd392b589b868e6e3c441e13a76dc38a448/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest_chromeos.cc
[modify] https://crrev.com/2ab68fd392b589b868e6e3c441e13a76dc38a448/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc
[modify] https://crrev.com/2ab68fd392b589b868e6e3c441e13a76dc38a448/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h
[add] https://crrev.com/2ab68fd392b589b868e6e3c441e13a76dc38a448/chrome/test/data/extensions/api_test/bluetooth_low_energy/remove_service/manifest.json
[add] https://crrev.com/2ab68fd392b589b868e6e3c441e13a76dc38a448/chrome/test/data/extensions/api_test/bluetooth_low_energy/remove_service/runtest.js

Comment 4 by r...@chromium.org, May 13 2016

Status: Fixed (was: Started)

Comment 5 by kathrelk...@chromium.org, May 19 2016

Status: Verified (was: Fixed)
bulk verify of io>bluetooth gatt server bugs
►

Sign in to add a comment