Chrome OS uses several nonexistent compositor flags |
|||
Issue description--enable-fixed-position-compositing was removed in Aug 2014: https://chromium.googlesource.com/chromium/src/+/3f196eb88893ffc9c9d4eecaf990f3451d75ec0a --enable-impl-side-painting was removed in Jan 2015: https://chromium.googlesource.com/chromium/src/+/27f39f26c1636f9f09c79ab44f86e91b114b9a61 --max-tiles-for-interest-area was removed in Jul 2015: https://chromium.googlesource.com/chromium/src/+/6c0087ba54947efa6dd3c9e8b7dd40ea644d9947 --ui-enable-per-tile-painting was removed in Feb 2014: https://chromium.googlesource.com/chromium/src/+/c6d0ba7d7e293c4898897bad1ebff9a6ca4c29ac Yet libchromeos-ui continues to pass them: https://chromium.googlesource.com/chromiumos/platform2/+/master/libchromeos-ui/chromeos/ui/chromium_command_builder.cc
,
May 11 2016
--ui-max-frames-pending=1 --enable-partial-swap as well maybe.
,
May 11 2016
Don't seem to be in chromium_command_builder.cc; sent to CQ.
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4665df3269d85c038e59a0e091a78e09b0b1c90e commit 4665df3269d85c038e59a0e091a78e09b0b1c90e Author: Jeremy Roman <jbroman@chromium.org> Date: Wed May 11 22:14:25 2016 libchromeos-ui: Remove obsolete compositor flags. --enable-fixed-position-compositing was removed in Aug 2014: https://chromium.googlesource.com/chromium/src/+/3f196eb88893ffc9c9d4eecaf990f3451d75ec0a --enable-impl-side-painting was removed in Jan 2015: https://chromium.googlesource.com/chromium/src/+/27f39f26c1636f9f09c79ab44f86e91b114b9a61 --max-tiles-for-interest-area was removed in Jul 2015: https://chromium.googlesource.com/chromium/src/+/6c0087ba54947efa6dd3c9e8b7dd40ea644d9947 --ui-enable-per-tile-painting was removed in Feb 2014: https://chromium.googlesource.com/chromium/src/+/c6d0ba7d7e293c4898897bad1ebff9a6ca4c29ac Also reformat one other line of code so that the upload hook passes. BUG= chromium:611226 TEST=None Change-Id: I111e97ec74b3b9085c49ff94ae460f5df5de4248 Reviewed-on: https://chromium-review.googlesource.com/344281 Commit-Ready: Jeremy Roman <jbroman@chromium.org> Tested-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/4665df3269d85c038e59a0e091a78e09b0b1c90e/libchromeos-ui/chromeos/ui/chromium_command_builder.cc
,
May 12 2016
,
May 23 2016
bulk verified |
|||
►
Sign in to add a comment |
|||
Comment 1 by danakj@chromium.org
, May 11 2016