https://www.chromium.org/developers/design-documents/mojo/type-mapping
Issue 611750 has been merged into this issue.
Assign to myself to evaluate how much work we have and how to proceed etc.
I'd highly recommend doing the "use_new_wrapper_types" migration first: https://cs.chromium.org/chromium/src/media/mojo/interfaces/BUILD.gn?rcl=0&l=38 (This made it easier to start using typemaps with chrome/browser/media/router/mojo/...)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6350fd61235fcee7ceb8fc610bc2a6b302c5d951 commit 6350fd61235fcee7ceb8fc610bc2a6b302c5d951 Author: xhwang <xhwang@chromium.org> Date: Wed Oct 12 16:26:46 2016 media: Use native BufferingState in media mojo interfaces BUG=611224 TEST=mojo_media_unittests still pass Review-Url: https://codereview.chromium.org/2386443002 Cr-Commit-Position: refs/heads/master@{#424759} [modify] https://crrev.com/6350fd61235fcee7ceb8fc610bc2a6b302c5d951/media/base/buffering_state.h [modify] https://crrev.com/6350fd61235fcee7ceb8fc610bc2a6b302c5d951/media/base/ipc/media_param_traits_macros.h [modify] https://crrev.com/6350fd61235fcee7ceb8fc610bc2a6b302c5d951/media/mojo/clients/mojo_renderer.cc [modify] https://crrev.com/6350fd61235fcee7ceb8fc610bc2a6b302c5d951/media/mojo/clients/mojo_renderer.h [modify] https://crrev.com/6350fd61235fcee7ceb8fc610bc2a6b302c5d951/media/mojo/clients/mojo_renderer_unittest.cc [modify] https://crrev.com/6350fd61235fcee7ceb8fc610bc2a6b302c5d951/media/mojo/common/media_type_converters.cc [modify] https://crrev.com/6350fd61235fcee7ceb8fc610bc2a6b302c5d951/media/mojo/interfaces/media_types.mojom [modify] https://crrev.com/6350fd61235fcee7ceb8fc610bc2a6b302c5d951/media/mojo/interfaces/media_types.typemap [modify] https://crrev.com/6350fd61235fcee7ceb8fc610bc2a6b302c5d951/media/mojo/services/media_mojo_unittest.cc [modify] https://crrev.com/6350fd61235fcee7ceb8fc610bc2a6b302c5d951/media/mojo/services/mojo_renderer_service.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f6b08cb25cebbc09e7b61859942c57c1895fb47 commit 7f6b08cb25cebbc09e7b61859942c57c1895fb47 Author: xhwang <xhwang@chromium.org> Date: Wed Oct 12 16:52:22 2016 media: Use new wrapper types for media mojo interfaces Now optional parameters are converted to base::Optional<>. I found it annoying for optional array or string which are converted to base::Optional<std::vector<T>> and base::Optional<std::string>: - It's confusing that it can be null and/or empty. In almost all cases we only need one type of "invalid" parameter. - In C++ we pass vector/string by const-ref so they cannot be null. So in this CL, I make array/string parameters mandatory, so that if they are not needed, we'll just pass empty array/string. This is easier to understand, more consistent with C++ code we have, and we don't need to deal with base::Optional. TBR=dkrahn@chromium.org BUG=611224 TEST=No functionality change Review-Url: https://codereview.chromium.org/2411573002 Cr-Commit-Position: refs/heads/master@{#424765} [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/chrome/browser/chromeos/attestation/platform_verification_impl.cc [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/chrome/browser/chromeos/attestation/platform_verification_impl.h [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/content/browser/media/android/provision_fetcher_impl.cc [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/content/browser/media/android/provision_fetcher_impl.h [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/base/media_keys.h [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/clients/mojo_cdm.cc [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/clients/mojo_cdm.h [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/clients/mojo_decryptor.cc [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/clients/mojo_decryptor.h [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/common/BUILD.gn [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/common/media_type_converters.cc [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/common/media_type_converters_unittest.cc [delete] https://crrev.com/f3798161a835bcfd9b257074093b4a44422d9a1a/media/mojo/common/mojo_type_trait.h [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/interfaces/BUILD.gn [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/interfaces/content_decryption_module.mojom [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/interfaces/decryptor.mojom [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/interfaces/media_types.mojom [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/interfaces/platform_verification.mojom [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/interfaces/provision_fetcher.mojom [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/services/mojo_cdm_promise.cc [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/services/mojo_cdm_promise.h [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/services/mojo_cdm_service.cc [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/services/mojo_cdm_service.h [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/services/mojo_decryptor_service.cc [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/services/mojo_provision_fetcher.cc [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/services/mojo_provision_fetcher.h [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/services/service_factory_impl.cc [modify] https://crrev.com/7f6b08cb25cebbc09e7b61859942c57c1895fb47/media/mojo/services/service_factory_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfcf085d7c1cbf5e0c3bcac5d06ed942c46af94d commit dfcf085d7c1cbf5e0c3bcac5d06ed942c46af94d Author: xhwang <xhwang@chromium.org> Date: Thu Oct 13 22:30:24 2016 media: Use native DecodeStatus in media mojo interfaces BUG=611224 TEST=mojo_media_unittests still pass Review-Url: https://codereview.chromium.org/2408063009 Cr-Commit-Position: refs/heads/master@{#425193} [modify] https://crrev.com/dfcf085d7c1cbf5e0c3bcac5d06ed942c46af94d/media/base/decode_status.h [modify] https://crrev.com/dfcf085d7c1cbf5e0c3bcac5d06ed942c46af94d/media/base/ipc/media_param_traits_macros.h [modify] https://crrev.com/dfcf085d7c1cbf5e0c3bcac5d06ed942c46af94d/media/mojo/clients/mojo_audio_decoder.cc [modify] https://crrev.com/dfcf085d7c1cbf5e0c3bcac5d06ed942c46af94d/media/mojo/clients/mojo_audio_decoder.h [modify] https://crrev.com/dfcf085d7c1cbf5e0c3bcac5d06ed942c46af94d/media/mojo/clients/mojo_video_decoder.cc [modify] https://crrev.com/dfcf085d7c1cbf5e0c3bcac5d06ed942c46af94d/media/mojo/clients/mojo_video_decoder.h [modify] https://crrev.com/dfcf085d7c1cbf5e0c3bcac5d06ed942c46af94d/media/mojo/common/media_type_converters.cc [modify] https://crrev.com/dfcf085d7c1cbf5e0c3bcac5d06ed942c46af94d/media/mojo/interfaces/media_types.mojom [modify] https://crrev.com/dfcf085d7c1cbf5e0c3bcac5d06ed942c46af94d/media/mojo/interfaces/media_types.typemap [modify] https://crrev.com/dfcf085d7c1cbf5e0c3bcac5d06ed942c46af94d/media/mojo/services/mojo_audio_decoder_service.cc [modify] https://crrev.com/dfcf085d7c1cbf5e0c3bcac5d06ed942c46af94d/media/mojo/services/mojo_video_decoder_service.cc [modify] https://crrev.com/dfcf085d7c1cbf5e0c3bcac5d06ed942c46af94d/media/mojo/services/mojo_video_decoder_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/057055f3bd77eb8de1b4c9cfd488d8854f91fb67 commit 057055f3bd77eb8de1b4c9cfd488d8854f91fb67 Author: xhwang <xhwang@chromium.org> Date: Fri Oct 14 05:34:27 2016 media: Use native audio enum types in media mojo interfaces BUG=611224 TEST=mojo_media_unittests still pass Review-Url: https://codereview.chromium.org/2421633003 Cr-Commit-Position: refs/heads/master@{#425258} [modify] https://crrev.com/057055f3bd77eb8de1b4c9cfd488d8854f91fb67/media/base/ipc/media_param_traits_macros.h [modify] https://crrev.com/057055f3bd77eb8de1b4c9cfd488d8854f91fb67/media/mojo/common/media_type_converters.cc [modify] https://crrev.com/057055f3bd77eb8de1b4c9cfd488d8854f91fb67/media/mojo/interfaces/media_types.mojom [modify] https://crrev.com/057055f3bd77eb8de1b4c9cfd488d8854f91fb67/media/mojo/interfaces/media_types.typemap
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aabcf38f71c28d32bdd6371d38dea38788f2779a commit aabcf38f71c28d32bdd6371d38dea38788f2779a Author: xhwang <xhwang@chromium.org> Date: Sat Oct 15 00:26:40 2016 media: Use native Decryptor enum types in media mojo interfaces This also fixes a bug in MojoDecryptor where DemuxerStream::Type and Decryptor::StreamType are mix-used with static_cast. BUG=611224, 656057 TEST=mojo_media_unittests still pass Review-Url: https://codereview.chromium.org/2416373002 Cr-Commit-Position: refs/heads/master@{#425517} [modify] https://crrev.com/aabcf38f71c28d32bdd6371d38dea38788f2779a/media/base/decryptor.h [modify] https://crrev.com/aabcf38f71c28d32bdd6371d38dea38788f2779a/media/base/ipc/media_param_traits_macros.h [modify] https://crrev.com/aabcf38f71c28d32bdd6371d38dea38788f2779a/media/mojo/clients/mojo_decryptor.cc [modify] https://crrev.com/aabcf38f71c28d32bdd6371d38dea38788f2779a/media/mojo/clients/mojo_decryptor.h [modify] https://crrev.com/aabcf38f71c28d32bdd6371d38dea38788f2779a/media/mojo/common/media_type_converters.cc [modify] https://crrev.com/aabcf38f71c28d32bdd6371d38dea38788f2779a/media/mojo/interfaces/decryptor.mojom [add] https://crrev.com/aabcf38f71c28d32bdd6371d38dea38788f2779a/media/mojo/interfaces/decryptor.typemap [modify] https://crrev.com/aabcf38f71c28d32bdd6371d38dea38788f2779a/media/mojo/interfaces/typemaps.gni [modify] https://crrev.com/aabcf38f71c28d32bdd6371d38dea38788f2779a/media/mojo/services/mojo_decryptor_service.cc [modify] https://crrev.com/aabcf38f71c28d32bdd6371d38dea38788f2779a/media/mojo/services/mojo_decryptor_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31c507ba784fd8dfbed42c9f02739cbe4a25ec57 commit 31c507ba784fd8dfbed42c9f02739cbe4a25ec57 Author: xhwang <xhwang@chromium.org> Date: Sat Oct 15 06:44:17 2016 media: Use native DemuxerStream enum types in media mojo interfaces BUG=611224 TEST=mojo_media_unittests still pass Review-Url: https://codereview.chromium.org/2416183002 Cr-Commit-Position: refs/heads/master@{#425551} [modify] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/base/decryptor.h [modify] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/base/demuxer_stream.h [modify] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/base/ipc/media_param_traits_macros.h [modify] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/base/stream_parser_buffer.cc [modify] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/base/stream_parser_unittest.cc [modify] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/filters/chunk_demuxer.cc [modify] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/filters/decoder_selector.cc [modify] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/filters/frame_processor_unittest.cc [modify] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/filters/source_buffer_state.cc [modify] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/mojo/clients/mojo_demuxer_stream_impl.cc [modify] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/mojo/clients/mojo_demuxer_stream_impl.h [modify] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/mojo/common/media_type_converters.cc [modify] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/mojo/interfaces/demuxer_stream.mojom [add] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/mojo/interfaces/demuxer_stream.typemap [modify] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/mojo/interfaces/typemaps.gni [modify] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/mojo/services/mojo_demuxer_stream_adapter.cc [modify] https://crrev.com/31c507ba784fd8dfbed42c9f02739cbe4a25ec57/media/mojo/services/mojo_demuxer_stream_adapter.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90b6ba65d65fe5cb01b137dbdee9e60b689d84e9 commit 90b6ba65d65fe5cb01b137dbdee9e60b689d84e9 Author: xhwang <xhwang@chromium.org> Date: Mon Oct 17 23:11:56 2016 media: Use native CipherMode enum type in media mojo interfaces BUG=611224 TEST=mojo_media_unittests still pass Review-Url: https://codereview.chromium.org/2423703002 Cr-Commit-Position: refs/heads/master@{#425806} [modify] https://crrev.com/90b6ba65d65fe5cb01b137dbdee9e60b689d84e9/media/base/ipc/media_param_traits_macros.h [modify] https://crrev.com/90b6ba65d65fe5cb01b137dbdee9e60b689d84e9/media/mojo/common/media_type_converters.cc [modify] https://crrev.com/90b6ba65d65fe5cb01b137dbdee9e60b689d84e9/media/mojo/interfaces/media_types.mojom [modify] https://crrev.com/90b6ba65d65fe5cb01b137dbdee9e60b689d84e9/media/mojo/interfaces/media_types.typemap
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/322c301a32ac10c6d374434e2642798ccf6c7bdb commit 322c301a32ac10c6d374434e2642798ccf6c7bdb Author: xhwang <xhwang@chromium.org> Date: Tue Oct 18 01:41:41 2016 media: Use native CDM enum types in media mojo interfaces Also: - Removed obsolete CDM IPC messages (see issue 581746 ) - Fixed some places missed in previsou CLs TBR=jam@chromium.org BUG= 417440 , 581746 ,611224 TEST=mojo_media_unittests still pass Review-Url: https://codereview.chromium.org/2425663003 Cr-Commit-Position: refs/heads/master@{#425850} [modify] https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb/content/common/BUILD.gn [modify] https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb/content/common/content_message_generator.h [delete] https://crrev.com/1ec709488535f68c662795128643be5eb32d4b1c/content/common/media/cdm_messages.h [delete] https://crrev.com/1ec709488535f68c662795128643be5eb32d4b1c/content/common/media/cdm_messages_enums.h [modify] https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb/media/base/eme_constants.h [modify] https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb/media/base/ipc/media_param_traits_macros.h [modify] https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb/media/mojo/clients/mojo_cdm.cc [modify] https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb/media/mojo/clients/mojo_cdm.h [modify] https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb/media/mojo/clients/mojo_decryptor.cc [modify] https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb/media/mojo/common/media_type_converters.cc [modify] https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb/media/mojo/interfaces/content_decryption_module.mojom [add] https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb/media/mojo/interfaces/content_decryption_module.typemap [modify] https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb/media/mojo/interfaces/typemaps.gni [modify] https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb/media/mojo/services/mojo_cdm_promise.cc [modify] https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb/media/mojo/services/mojo_cdm_service.cc [modify] https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb/media/mojo/services/mojo_cdm_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5476624b8b351bfc350ee29ea10a81ad53879134 commit 5476624b8b351bfc350ee29ea10a81ad53879134 Author: xhwang <xhwang@chromium.org> Date: Thu Oct 20 20:18:35 2016 media: Move pipeline_statistics_struct_traits.h This file is only used by the typemap located in media/mojo/interfaces. Move it there to be closer to where it's used. This is also consistent with how other *struct_traits.h files are organized. BUG=611224 Review-Url: https://chromiumcodereview.appspot.com/2439813002 Cr-Commit-Position: refs/heads/master@{#426579} [modify] https://crrev.com/5476624b8b351bfc350ee29ea10a81ad53879134/media/mojo/interfaces/OWNERS [modify] https://crrev.com/5476624b8b351bfc350ee29ea10a81ad53879134/media/mojo/interfaces/pipeline_statistics.typemap [rename] https://crrev.com/5476624b8b351bfc350ee29ea10a81ad53879134/media/mojo/interfaces/pipeline_statistics_struct_traits.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b97acd20738e59328440346a225b472e51b6daf5 commit b97acd20738e59328440346a225b472e51b6daf5 Author: sandersd <sandersd@chromium.org> Date: Sat Jun 03 03:32:37 2017 media: Create separate target for MojoSharedBufferVideoFrame. This is prepatory work for switching to StructTraits for VideoFrame, which will add a dependency from //media/mojo/interfaces to //media/mojo/common:mojo_shared_buffer_video_frame. BUG=611224 Review-Url: https://codereview.chromium.org/2919163003 Cr-Commit-Position: refs/heads/master@{#476882} [modify] https://crrev.com/b97acd20738e59328440346a225b472e51b6daf5/media/mojo/BUILD.gn [modify] https://crrev.com/b97acd20738e59328440346a225b472e51b6daf5/media/mojo/clients/BUILD.gn [modify] https://crrev.com/b97acd20738e59328440346a225b472e51b6daf5/media/mojo/common/BUILD.gn [modify] https://crrev.com/b97acd20738e59328440346a225b472e51b6daf5/media/mojo/services/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ad3de8f2d39653bdabf40403b1dc48ae92c8320 commit 5ad3de8f2d39653bdabf40403b1dc48ae92c8320 Author: sandersd <sandersd@chromium.org> Date: Fri Jun 09 21:06:26 2017 media: Create Mojo StructTraits for VideoFrame This replaces the existing TypeConverter code for VideoFrames. BUG=611224 Review-Url: https://codereview.chromium.org/2908303003 Cr-Commit-Position: refs/heads/master@{#478413} [modify] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/BUILD.gn [modify] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/clients/mojo_decryptor.cc [modify] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/clients/mojo_decryptor.h [modify] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/clients/mojo_video_decoder.cc [modify] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/clients/mojo_video_decoder.h [modify] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/common/media_type_converters_unittest.cc [modify] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/common/mojo_shared_buffer_video_frame.cc [modify] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/common/mojo_shared_buffer_video_frame.h [modify] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/interfaces/BUILD.gn [modify] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/interfaces/media_types.mojom [add] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/interfaces/traits_test_service.mojom [modify] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/interfaces/typemaps.gni [add] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/interfaces/video_frame.typemap [add] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/interfaces/video_frame_struct_traits.cc [add] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/interfaces/video_frame_struct_traits.h [add] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/interfaces/video_frame_struct_traits_unittest.cc [modify] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/services/mojo_cdm_allocator_unittest.cc [modify] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/services/mojo_decryptor_service.cc [modify] https://crrev.com/5ad3de8f2d39653bdabf40403b1dc48ae92c8320/media/mojo/services/mojo_video_decoder_service.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e986179979a89c8a2bdf55d139cd56baacd8573 commit 2e986179979a89c8a2bdf55d139cd56baacd8573 Author: sandersd <sandersd@chromium.org> Date: Wed Jun 14 20:29:15 2017 media: Followup changes to VideoFrame StructTraits. Included in this change: - Actually remove the TypeConverters. - Replace |end_of_stream| with a |data| union member. - Gentler handling of |visible_rect| problems. BUG=611224 Review-Url: https://codereview.chromium.org/2933573003 Cr-Commit-Position: refs/heads/master@{#479488} [modify] https://crrev.com/2e986179979a89c8a2bdf55d139cd56baacd8573/media/base/video_frame.cc [modify] https://crrev.com/2e986179979a89c8a2bdf55d139cd56baacd8573/media/mojo/common/media_type_converters.cc [modify] https://crrev.com/2e986179979a89c8a2bdf55d139cd56baacd8573/media/mojo/common/media_type_converters.h [modify] https://crrev.com/2e986179979a89c8a2bdf55d139cd56baacd8573/media/mojo/interfaces/media_types.mojom [modify] https://crrev.com/2e986179979a89c8a2bdf55d139cd56baacd8573/media/mojo/interfaces/video_frame_struct_traits.cc [modify] https://crrev.com/2e986179979a89c8a2bdf55d139cd56baacd8573/media/mojo/interfaces/video_frame_struct_traits.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a259fda816445e7597f3dde1913e510c6233e131 commit a259fda816445e7597f3dde1913e510c6233e131 Author: Chris Cunningham <chcunningham@chromium.org> Date: Sat Jul 08 02:37:49 2017 Define mojo type map for media::{Audio|Video}DecoderConfig Also includes type mapping for media::EncryptionScheme. Bug: 611224 Change-Id: I151aacd4ea2dfe9e02ff7c82c922bc5a982e1fd4 Reviewed-on: https://chromium-review.googlesource.com/544913 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#485133} [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/base/test_helpers.cc [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/base/test_helpers.h [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/base/video_decoder_config.cc [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/base/video_decoder_config.h [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/BUILD.gn [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/clients/mojo_audio_decoder.cc [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/clients/mojo_decryptor.cc [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/clients/mojo_demuxer_stream_impl.cc [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/clients/mojo_renderer_unittest.cc [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/clients/mojo_video_decoder.cc [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/common/media_type_converters.cc [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/common/media_type_converters.h [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/common/media_type_converters_unittest.cc [add] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/interfaces/audio_decoder_config.typemap [add] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/interfaces/audio_decoder_config_struct_traits.cc [add] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/interfaces/audio_decoder_config_struct_traits.h [add] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/interfaces/audio_decoder_config_struct_traits_unittest.cc [add] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/interfaces/encryption_scheme.typemap [add] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/interfaces/encryption_scheme_struct_traits.cc [add] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/interfaces/encryption_scheme_struct_traits.h [add] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/interfaces/encryption_scheme_struct_traits_unittest.cc [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/interfaces/typemaps.gni [add] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/interfaces/video_decoder_config.typemap [add] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/interfaces/video_decoder_config_struct_traits.cc [add] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/interfaces/video_decoder_config_struct_traits.h [add] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/interfaces/video_decoder_config_struct_traits_unittest.cc [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/services/mojo_audio_decoder_service.cc [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/services/mojo_audio_decoder_service.h [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/services/mojo_decryptor_service.cc [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/services/mojo_decryptor_service.h [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/services/mojo_demuxer_stream_adapter.cc [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/services/mojo_demuxer_stream_adapter.h [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/services/mojo_video_decoder_service.cc [modify] https://crrev.com/a259fda816445e7597f3dde1913e510c6233e131/media/mojo/services/mojo_video_decoder_service.h
Now we have only 5 types using TypeConverter. We should get this done at some point and say goodbye to TypeConverters.
Assign to jrummell@ for load balance...
The 5 remaining types in media_type_converter.cc DecryptConfig DecoderBuffer AudioDecoderConfig CdmKeyInformation AudioBuffer Interesting that #21 states that media::AudioDecoderConfig was changed. So only 4 to go.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36328a6c045a7c90c0631931f0fe9878502cc2a6 commit 36328a6c045a7c90c0631931f0fe9878502cc2a6 Author: John Rummell <jrummell@chromium.org> Date: Fri Apr 13 16:43:52 2018 Remove unused type converters AudioDecoderConfig was changed to a type map a while back. EncryptionPattern has no implementation anyway. BUG=611224 TEST=media_mojo_unittests passes Change-Id: I20a83d4ca20819447c563fd19207914fe04f0381 Reviewed-on: https://chromium-review.googlesource.com/1011360 Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#550644} [modify] https://crrev.com/36328a6c045a7c90c0631931f0fe9878502cc2a6/media/mojo/common/media_type_converters.cc [modify] https://crrev.com/36328a6c045a7c90c0631931f0fe9878502cc2a6/media/mojo/common/media_type_converters.h
Moving to M71.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88f68163a49c4958689dd1f153c8656497463576 commit 88f68163a49c4958689dd1f153c8656497463576 Author: John Rummell <jrummell@chromium.org> Date: Tue Dec 11 23:56:45 2018 Convert CdmKeyInformation to use a typemap. BUG=611224 TEST=new media_unittest passes Change-Id: I7feadd34ca77bcacd406b61783e43143bb593f7f Reviewed-on: https://chromium-review.googlesource.com/c/1338323 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#615729} [modify] https://crrev.com/88f68163a49c4958689dd1f153c8656497463576/media/base/ipc/media_param_traits_macros.h [modify] https://crrev.com/88f68163a49c4958689dd1f153c8656497463576/media/mojo/clients/mojo_cdm.cc [modify] https://crrev.com/88f68163a49c4958689dd1f153c8656497463576/media/mojo/clients/mojo_cdm.h [modify] https://crrev.com/88f68163a49c4958689dd1f153c8656497463576/media/mojo/common/media_type_converters.cc [modify] https://crrev.com/88f68163a49c4958689dd1f153c8656497463576/media/mojo/common/media_type_converters.h [modify] https://crrev.com/88f68163a49c4958689dd1f153c8656497463576/media/mojo/interfaces/BUILD.gn [add] https://crrev.com/88f68163a49c4958689dd1f153c8656497463576/media/mojo/interfaces/cdm_key_information.typemap [add] https://crrev.com/88f68163a49c4958689dd1f153c8656497463576/media/mojo/interfaces/cdm_key_information_mojom_traits.cc [add] https://crrev.com/88f68163a49c4958689dd1f153c8656497463576/media/mojo/interfaces/cdm_key_information_mojom_traits.h [add] https://crrev.com/88f68163a49c4958689dd1f153c8656497463576/media/mojo/interfaces/cdm_key_information_mojom_traits_unittest.cc [modify] https://crrev.com/88f68163a49c4958689dd1f153c8656497463576/media/mojo/interfaces/content_decryption_module.mojom [modify] https://crrev.com/88f68163a49c4958689dd1f153c8656497463576/media/mojo/interfaces/content_decryption_module.typemap [modify] https://crrev.com/88f68163a49c4958689dd1f153c8656497463576/media/mojo/interfaces/typemaps.gni [modify] https://crrev.com/88f68163a49c4958689dd1f153c8656497463576/media/mojo/services/mojo_cdm_service.cc
Comment 1 by dcheng@chromium.org
, May 11 2016