New issue
Advanced search Search tips

Issue 611223 link

Starred by 1 user
Status: Fixed
Owner:
se...@chromium.org
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Don't record the use of a profile after a merge with a new profile.

Project Member Reported by se...@chromium.org, May 11 2016 
We used to record the use of the profile after the merge because the use count of the new profile was 0 and the use date was the default value. Now that these are now set to 1 and Now() respectively for new profiles, the merging actually sets the right values to the merged profile ie. the use_count is incremented by one and the use_date is set to now.
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f25a299b4ae5855530c83dfcf7c4c6d854d533c8

commit f25a299b4ae5855530c83dfcf7c4c6d854d533c8
Author: sebsg <sebsg@chromium.org>
Date: Thu May 12 20:40:39 2016

Since the use_count and use_date of new profiles were changed to 1 and Now() respectively (were 0 and base::Time), there is no need to record the use of a newly merged profile. The merging logic will have set the usage statistics to the expected values.

BUG= 611223 
TEST=PersonalDataManagerTest

Review-Url: https://codereview.chromium.org/1974533003
Cr-Commit-Position: refs/heads/master@{#393344}

[modify] https://crrev.com/f25a299b4ae5855530c83dfcf7c4c6d854d533c8/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/f25a299b4ae5855530c83dfcf7c4c6d854d533c8/components/autofill/core/browser/personal_data_manager_unittest.cc

Comment 2 by se...@chromium.org, May 12 2016

Status: Fixed (was: Started)
►

Sign in to add a comment