New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 611205 link

Starred by 1 user
Status: Fixed
Owner:
emir...@chromium.org
Closed: May 2016
Cc:
█ dutton@chromium.org
mcasas@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

MediaRecorder does not record bursty streams such as CanvasCapture

Project Member Reported by emir...@chromium.org, May 11 2016 
MediaRecorder sometimes does not record bursty streams such as CanvasCapture.

On the below link, you can find an application that hooks up CanvasCapture to MediaRecorder. Once in ~5 tries, you can find that it records nothing and report an empty blob in console.
https://samdutton.github.io/webrtc/src/content/capture/canvas-record/

Digging down the problem shows that, bursty streams may be marked as ReadyStateMuted in the beginning and MediaRecorder does not record ReadyStateMuted streams.
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21a24223a6f5713de7b5cc162bade97c464ad8c4

commit 21a24223a6f5713de7b5cc162bade97c464ad8c4
Author: emircan <emircan@chromium.org>
Date: Wed May 11 22:53:13 2016

Allow MediaRecorder to record Muted streams

This CL tries to address the bug by letting MediaRecorder to start recording
even when the incoming stream is muted.
BUG= 611205 

Review-Url: https://codereview.chromium.org/1971533005
Cr-Commit-Position: refs/heads/master@{#393093}

[modify] https://crrev.com/21a24223a6f5713de7b5cc162bade97c464ad8c4/content/renderer/media/media_recorder_handler.cc

Comment 2 by emir...@chromium.org, May 11 2016

Labels: Merge-Request-51
Status: Fixed (was: Started)

Comment 3 by tin...@google.com, May 12 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 4 by bugdroid1@chromium.org, May 12 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/897a18a7eac68c0ea7d4fbcafffe00843f407f7e

commit 897a18a7eac68c0ea7d4fbcafffe00843f407f7e
Author: emircan <emircan@chromium.org>
Date: Thu May 12 22:32:38 2016

Allow MediaRecorder to record Muted streams

This CL tries to address the bug by letting MediaRecorder to start recording
even when the incoming stream is muted.
BUG= 611205 

Review-Url: https://codereview.chromium.org/1971533005
Cr-Commit-Position: refs/heads/master@{#393093}
(cherry picked from commit 21a24223a6f5713de7b5cc162bade97c464ad8c4)

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1973143002
Cr-Commit-Position: refs/branch-heads/2704@{#527}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/897a18a7eac68c0ea7d4fbcafffe00843f407f7e/content/renderer/media/media_recorder_handler.cc

Comment 5 by sshru...@google.com, May 24 2016

Components: -Blink>MediaCaptureFromElement Blink>MediaStream>CaptureFromElement
Renamed Blink>MediaCaptureFromElement to Blink>MediaStream>CaptureFromElement. Moving issues to the new component.

Comment 6 by sshru...@google.com, May 24 2016

Components: -Blink>MediaStreamRecording Blink>MediaStream>Recording
Renamed component Blink>MediaStreamRecording to Blink>MediaStream>Recording. Moving issues to the new component.

Comment 7 by mcasas@chromium.org, Jan 18 2017

Components: Blink>MediaRecording

Comment 8 by mcasas@chromium.org, Jan 18 2017

Components: -Blink>MediaStream>Recording
►

Sign in to add a comment