GYP fails for Chromium tarballs. |
|||
Issue descriptionOn a Linux machine known to be able to build Chromium: 1) Download https://gsdview.appspot.com/chromium-browser-official/chromium-50.0.2661.102.tar.xz 2) Unpack the tarball, rename the unpacked directory to src 3) cd src 4) ./build/gyp_chromium -Duse_sysroot=0 Expected: GYP runs to completion Actual: Error processing node <?xml version="1.0" encoding="UTF-8"?> <include allowexternalscript="true" file="webui/i18n_process_css_test.html" flattenhtml="true" name="IDR_WEBUI_TEST_I18N_PROCESS_CSS_TEST" type="BINDATA" /> Exception: Failed to open test/data/webui/i18n_process_css_test.html while trying to flatten test/data/webui/i18n_process_css_test.html. (No such file or directory) The missing file is in normal checkouts, but the tarball strips out files from chrome/test/data. It's easy to work around this problem by just creating a dummy file. Shall we make this change to tools/export_tarball/export_tarball.py?
,
May 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/96504cf83f1e51a3957ea70a33211f2d202300c0 commit 96504cf83f1e51a3957ea70a33211f2d202300c0 Author: thestig@chromium.org <thestig@chromium.org> Date: Mon May 16 18:41:02 2016 Update export_tarball.py - Exclude .git directories only. Stop mentioning SVN. - Exclude the out directory. - Remove obsolete non-essential directories from the list. - Move some non-essential directories to the test data list. - Add a list of essential files to override the non-essential dir list. BUG= 611199 Review-Url: https://codereview.chromium.org/1981553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300596 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/96504cf83f1e51a3957ea70a33211f2d202300c0/scripts/slave/recipe_modules/chromium/resources/export_tarball.py
,
May 16 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87921 ------------------------------------------------------------------ r87921 | recipe-roller@chromium.org | 2016-05-16T18:43:09.922850Z -----------------------------------------------------------------
,
May 16 2016
,
May 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/670cfbf429b57ace933431d95d2c2863c6fd2efb commit 670cfbf429b57ace933431d95d2c2863c6fd2efb Author: qyearsley@chromium.org <qyearsley@chromium.org> Date: Tue May 17 16:55:09 2016 Revert of Update export_tarball.py (patchset #1 id:1 of https://codereview.chromium.org/1981553002/ ) Reason for revert: Failure in the export_tarball step Example build: https://build.chromium.org/p/chromium.infra.cron/builders/publish_tarball/builds/3466 Traceback (most recent call last): File "/b/build/scripts/slave/recipe_modules/chromium/resources/export_tarball.py", line 191, in <module> sys.exit(main(sys.argv[1:])) File "/b/build/scripts/slave/recipe_modules/chromium/resources/export_tarball.py", line 167, in main archive.add(options.src_dir, arcname=output_basename) File "/b/build/scripts/slave/recipe_modules/chromium/resources/export_tarball.py", line 100, in add rel_name = os.path.relpath(name, GetSourceDirectory()) NameError: global name 'GetSourceDirectory' is not defined Original issue's description: > Update export_tarball.py > > - Exclude .git directories only. Stop mentioning SVN. > - Exclude the out directory. > - Remove obsolete non-essential directories from the list. > - Move some non-essential directories to the test data list. > - Add a list of essential files to override the non-essential dir list. > > BUG= 611199 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300596 TBR=phajdan.jr@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 611199 Review-Url: https://codereview.chromium.org/1984053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300630 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/670cfbf429b57ace933431d95d2c2863c6fd2efb/scripts/slave/recipe_modules/chromium/resources/export_tarball.py
,
May 17 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87975 ------------------------------------------------------------------ r87975 | recipe-roller@chromium.org | 2016-05-17T17:03:58.144010Z -----------------------------------------------------------------
,
May 17 2016
,
May 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/46ec4c5ab66c1c18f29ff018548d6be3c8b5ee2c commit 46ec4c5ab66c1c18f29ff018548d6be3c8b5ee2c Author: thestig@chromium.org <thestig@chromium.org> Date: Tue May 17 21:02:27 2016 Update export_tarball.py (try 2) - Exclude .git directories only. Stop mentioning SVN. - Exclude the out directory. - Remove obsolete non-essential directories from the list. - Move some non-essential directories to the test data list. - Add a list of essential files to override the non-essential dir list. BUG= 611199 Previous CL: https://codereview.chromium.org/1981553002/ Review-Url: https://codereview.chromium.org/1988883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300632 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/46ec4c5ab66c1c18f29ff018548d6be3c8b5ee2c/scripts/slave/recipe_modules/chromium/resources/export_tarball.py
,
May 17 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87990 ------------------------------------------------------------------ r87990 | recipe-roller@chromium.org | 2016-05-17T21:23:28.490154Z -----------------------------------------------------------------
,
May 17 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by thestig@chromium.org
, May 12 2016Status: Started (was: Untriaged)