New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611188 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 425627



Sign in to add a comment

Switch MD settings to $i18n from i18n-content replacement

Project Member Reported by dschuyler@chromium.org, May 11 2016

Issue description

Update the MD settings pages from using 
i18n-content and i18n-values to using
$i18n for text replacement. This avoids some
flicker in the UI.

(It's also a tiny bit faster, but that's not
the main point).

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00a261827077cdfe04f3acb7f341c69d23d3ceab

commit 00a261827077cdfe04f3acb7f341c69d23d3ceab
Author: dschuyler <dschuyler@chromium.org>
Date: Wed May 11 22:14:35 2016

[MD settings] update i18n replacements in a11y, privacy, reset, and search

This CL has mechanical changes to convert from the i18n-content and
i18n-values to $i18n{}.

BUG= 611188 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1971443003
Cr-Commit-Position: refs/heads/master@{#393085}

[modify] https://crrev.com/00a261827077cdfe04f3acb7f341c69d23d3ceab/chrome/browser/resources/settings/a11y_page/a11y_page.html
[modify] https://crrev.com/00a261827077cdfe04f3acb7f341c69d23d3ceab/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/00a261827077cdfe04f3acb7f341c69d23d3ceab/chrome/browser/resources/settings/reset_page/powerwash_dialog.html
[modify] https://crrev.com/00a261827077cdfe04f3acb7f341c69d23d3ceab/chrome/browser/resources/settings/reset_page/reset_page.html
[modify] https://crrev.com/00a261827077cdfe04f3acb7f341c69d23d3ceab/chrome/browser/resources/settings/reset_page/reset_profile_banner.html
[modify] https://crrev.com/00a261827077cdfe04f3acb7f341c69d23d3ceab/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
[modify] https://crrev.com/00a261827077cdfe04f3acb7f341c69d23d3ceab/chrome/browser/resources/settings/search_page/search_page.html

Project Member

Comment 3 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05cf209ba38a2a1083883bc38f91bed7b6633e69

commit 05cf209ba38a2a1083883bc38f91bed7b6633e69
Author: dschuyler <dschuyler@chromium.org>
Date: Thu May 12 01:16:42 2016

[MD settings] cleanup &nbsp; use

This CL removes &nbsp; added while changing i18n-content
entries to $i18n.

This a correction for CL 1971443003.
BUG= 611188 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1967323002
Cr-Commit-Position: refs/heads/master@{#393131}

[modify] https://crrev.com/05cf209ba38a2a1083883bc38f91bed7b6633e69/chrome/browser/resources/settings/a11y_page/a11y_page.html
[modify] https://crrev.com/05cf209ba38a2a1083883bc38f91bed7b6633e69/chrome/browser/resources/settings/reset_page/powerwash_dialog.html
[modify] https://crrev.com/05cf209ba38a2a1083883bc38f91bed7b6633e69/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html

Project Member

Comment 4 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23ecf06e5064f55c9f0e93306b82fd1edb58ba2a

commit 23ecf06e5064f55c9f0e93306b82fd1edb58ba2a
Author: dschuyler <dschuyler@chromium.org>
Date: Thu May 12 02:02:39 2016

[MD settings] i18n-content to $i18n switch in the settings menu

This is a mechanical change from using i18n-content to using $i18n
replacements in the settings menu (the side nav).

BUG= 611188 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1975583002
Cr-Commit-Position: refs/heads/master@{#393145}

[modify] https://crrev.com/23ecf06e5064f55c9f0e93306b82fd1edb58ba2a/chrome/browser/resources/settings/settings_menu/settings_menu.html

Project Member

Comment 5 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e031cc226e978981fb1589eaa20d3b635968d46

commit 4e031cc226e978981fb1589eaa20d3b635968d46
Author: dschuyler <dschuyler@chromium.org>
Date: Fri May 13 18:29:10 2016

[MD settings] change i18n() use in html to $i18n

This CL switches i18n('') behavior use in html files to use $i18n
instead. The i18n('') is still used in JavaScript files.

These changes are mechanical changes.

(Bonus, there a few i18n-content/i18n-values changes as well).

BUG= 611188 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1976003002
Cr-Commit-Position: refs/heads/master@{#393587}

[modify] https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46/chrome/browser/resources/settings/advanced_page/advanced_page.html
[modify] https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
[modify] https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46/chrome/browser/resources/settings/date_time_page/date_time_page.html
[modify] https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46/chrome/browser/resources/settings/default_browser_page/default_browser_page.html
[modify] https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46/chrome/browser/resources/settings/people_page/change_picture.html
[modify] https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46/chrome/browser/resources/settings/settings.html
[modify] https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46/chrome/browser/resources/settings/system_page/system_page.html

Project Member

Comment 6 by bugdroid1@chromium.org, May 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7f33accb0472956f348a72a33667addf2e18b1a

commit c7f33accb0472956f348a72a33667addf2e18b1a
Author: dschuyler <dschuyler@chromium.org>
Date: Sat May 14 00:50:26 2016

[MD settings] remove unneeded use of I18nBehavior

This CL removes the import and behavior or I18nBehavior from
files that don't use the this.i18n().

BUG= 611188 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1973973004
Cr-Commit-Position: refs/heads/master@{#393711}

[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/advanced_page/advanced_page.html
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/advanced_page/advanced_page.js
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/advanced_page/compiled_resources2.gyp
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/basic_page/basic_page.js
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/basic_page/compiled_resources2.gyp
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/controls/compiled_resources2.gyp
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/controls/settings_dropdown_menu.js
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/default_browser_page/default_browser_page.html
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/default_browser_page/default_browser_page.js
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/internet_page/compiled_resources2.gyp
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/people_page/camera.html
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/people_page/camera.js
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/people_page/compiled_resources2.gyp
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/c7f33accb0472956f348a72a33667addf2e18b1a/chrome/browser/resources/settings/search_page/search_page.js

Project Member

Comment 7 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f6c70d4f1281f3b29f425f2b680c5236dfe91ea

commit 6f6c70d4f1281f3b29f425f2b680c5236dfe91ea
Author: dbeam <dbeam@chromium.org>
Date: Wed May 18 00:38:11 2016

MD Settings: convert some bluetooth i18n-content to $i18n{}

Based on https://codereview.chromium.org/1970923002/
by Dave Schuyler <dschuyler@chromium.org>

R=dschuyler@chromium.org
BUG= 611188 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1987443002
Cr-Commit-Position: refs/heads/master@{#394292}

[modify] https://crrev.com/6f6c70d4f1281f3b29f425f2b680c5236dfe91ea/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html

Status: Fixed (was: Started)

Sign in to add a comment