Our top user complaint for the iOS app is audio support. We should ensure that the iOS app is at parity with the web app and Android app with audio support.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eea69600e07c1d402758d8dd03f5579caddde736 commit eea69600e07c1d402758d8dd03f5579caddde736 Author: nicholss <nicholss@chromium.org> Date: Mon Jun 20 21:03:33 2016 Adding an interface to allow extension of the audio player for CRD and iOS. This CL changes the audio player for CRD into a consumer of audio packets. The choice of consumer is based on a consumer/provider pattern, the intent is to create a new class that will be used in iOS in a following CL that acts as a middle buffer between the CRD Client and the iOS audio player which will extend both AudioConsumer and AudioProvider(not in this CL). Because of this change, I needed the current usage of audio player to extend from a more generic interface (AudioConsumer) which could apply to either this future buffer or audio player. BUG= 611181 TEST=Manual tested webapp client. R=lambroslambrou@chromium.org Review-Url: https://codereview.chromium.org/2052723002 Cr-Commit-Position: refs/heads/master@{#400776} [modify] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/BUILD.gn [add] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/audio_consumer.h [modify] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/audio_decode_scheduler.cc [modify] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/audio_decode_scheduler.h [add] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/audio_decode_scheduler_unittest.cc [modify] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/audio_player.cc [modify] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/audio_player.h [modify] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/audio_player_android.cc [modify] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/audio_player_android.h [modify] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/chromoting_client.cc [modify] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/chromoting_client.h [add] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/fake_audio_consumer.cc [add] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/fake_audio_consumer.h [modify] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/jni/chromoting_jni_instance.cc [modify] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/jni/chromoting_jni_instance.h [modify] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/plugin/chromoting_instance.cc [modify] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/plugin/chromoting_instance.h [modify] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/plugin/pepper_audio_player.cc [modify] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/client/plugin/pepper_audio_player.h [modify] https://crrev.com/eea69600e07c1d402758d8dd03f5579caddde736/remoting/remoting_srcs.gypi
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79d9f91451cbec77bbd6bfbba95ba6da3bc8908f commit 79d9f91451cbec77bbd6bfbba95ba6da3bc8908f Author: nicholss <nicholss@chromium.org> Date: Wed Jun 22 17:39:27 2016 Adding an interface to allow extension of the audio player for CRD and iOS. This CL changes the audio player for CRD into a consumer of audio packets. The choice of consumer is based on a consumer/provider pattern, the intent is to create a new class that will be used in iOS in a following CL that acts as a middle buffer between the CRD Client and the iOS audio player which will extend both AudioConsumer and AudioProvider(not in this CL). Because of this change, I needed the current usage of audio player to extend from a more generic interface (AudioConsumer) which could apply to either this future buffer or audio player. This is a followup to https://codereview.chromium.org/2052723002, I missed the last upload for the CL changes. R=sergeyu@chromium.org BUG= 611181 Review-Url: https://codereview.chromium.org/2084123002 Cr-Commit-Position: refs/heads/master@{#401332} [modify] https://crrev.com/79d9f91451cbec77bbd6bfbba95ba6da3bc8908f/remoting/BUILD.gn [modify] https://crrev.com/79d9f91451cbec77bbd6bfbba95ba6da3bc8908f/remoting/client/audio_consumer.h [modify] https://crrev.com/79d9f91451cbec77bbd6bfbba95ba6da3bc8908f/remoting/client/audio_decode_scheduler.cc [modify] https://crrev.com/79d9f91451cbec77bbd6bfbba95ba6da3bc8908f/remoting/client/audio_decode_scheduler.h [modify] https://crrev.com/79d9f91451cbec77bbd6bfbba95ba6da3bc8908f/remoting/client/audio_decode_scheduler_unittest.cc [modify] https://crrev.com/79d9f91451cbec77bbd6bfbba95ba6da3bc8908f/remoting/client/audio_player.cc [modify] https://crrev.com/79d9f91451cbec77bbd6bfbba95ba6da3bc8908f/remoting/client/audio_player.h [modify] https://crrev.com/79d9f91451cbec77bbd6bfbba95ba6da3bc8908f/remoting/client/audio_player_unittest.cc [modify] https://crrev.com/79d9f91451cbec77bbd6bfbba95ba6da3bc8908f/remoting/client/fake_audio_consumer.cc [modify] https://crrev.com/79d9f91451cbec77bbd6bfbba95ba6da3bc8908f/remoting/client/fake_audio_consumer.h [modify] https://crrev.com/79d9f91451cbec77bbd6bfbba95ba6da3bc8908f/remoting/client/jni/chromoting_jni_runtime.cc
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2375a32a7573b9c404885fa4a33d3e02bace676 commit d2375a32a7573b9c404885fa4a33d3e02bace676 Author: Scott Nichols <nicholss@chromium.org> Date: Wed Aug 23 22:47:14 2017 Moving client audio files to a audio directory for easy orginization. Bug: 611181 Change-Id: I43665832cd85fc71cf9c8a90659771897b7cc17e Reviewed-on: https://chromium-review.googlesource.com/627635 Commit-Queue: Scott Nichols <nicholss@chromium.org> Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#496840} [modify] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/BUILD.gn [modify] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/client/BUILD.gn [add] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/client/audio/BUILD.gn [rename] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/client/audio/audio_player.cc [rename] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/client/audio/audio_player.h [rename] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/client/audio/audio_player_android.cc [rename] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/client/audio/audio_player_android.h [rename] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/client/audio/audio_player_unittest.cc [modify] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/client/chromoting_session.cc [modify] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/client/jni/jni_client.cc [modify] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/client/plugin/BUILD.gn [modify] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/client/plugin/pepper_audio_player.h [modify] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/codec/audio_decoder.h [modify] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/host/audio_capturer_chromeos.cc [modify] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/test/BUILD.gn [modify] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/test/protocol_perftest.cc [modify] https://crrev.com/d2375a32a7573b9c404885fa4a33d3e02bace676/remoting/test/test_chromoting_client.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/565106b4e643be1d181958320b3ed9d8fc78c330 commit 565106b4e643be1d181958320b3ed9d8fc78c330 Author: Scott Nichols <nicholss@chromium.org> Date: Mon Aug 28 22:45:01 2017 Adding interfaces for future client audio work. Bug: 611181 Change-Id: I91f38c489f7b3d9791c50ae9e7ee64a9aad1fb68 Reviewed-on: https://chromium-review.googlesource.com/627241 Commit-Queue: Scott Nichols <nicholss@chromium.org> Reviewed-by: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#497913} [modify] https://crrev.com/565106b4e643be1d181958320b3ed9d8fc78c330/remoting/client/audio/BUILD.gn [add] https://crrev.com/565106b4e643be1d181958320b3ed9d8fc78c330/remoting/client/audio/async_audio_frame_supplier.h [add] https://crrev.com/565106b4e643be1d181958320b3ed9d8fc78c330/remoting/client/audio/audio_frame_supplier.h [add] https://crrev.com/565106b4e643be1d181958320b3ed9d8fc78c330/remoting/client/audio/audio_stream_consumer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb754cc9313afa87032928438e9ffbdcc6e269d5 commit fb754cc9313afa87032928438e9ffbdcc6e269d5 Author: Scott Nichols <nicholss@chromium.org> Date: Fri Sep 08 15:53:35 2017 Adding the impl of the audio player buffer. Bug: 611181 Change-Id: Ic0602aa6b255d94e3debabaea43530599ab4bc33 Reviewed-on: https://chromium-review.googlesource.com/627520 Commit-Queue: Scott Nichols <nicholss@chromium.org> Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#500600} [modify] https://crrev.com/fb754cc9313afa87032928438e9ffbdcc6e269d5/remoting/client/audio/BUILD.gn [modify] https://crrev.com/fb754cc9313afa87032928438e9ffbdcc6e269d5/remoting/client/audio/async_audio_frame_supplier.h [modify] https://crrev.com/fb754cc9313afa87032928438e9ffbdcc6e269d5/remoting/client/audio/audio_frame_supplier.h [modify] https://crrev.com/fb754cc9313afa87032928438e9ffbdcc6e269d5/remoting/client/audio/audio_player.cc [modify] https://crrev.com/fb754cc9313afa87032928438e9ffbdcc6e269d5/remoting/client/audio/audio_player.h [add] https://crrev.com/fb754cc9313afa87032928438e9ffbdcc6e269d5/remoting/client/audio/audio_player_buffer.cc [add] https://crrev.com/fb754cc9313afa87032928438e9ffbdcc6e269d5/remoting/client/audio/audio_player_buffer.h [add] https://crrev.com/fb754cc9313afa87032928438e9ffbdcc6e269d5/remoting/client/audio/audio_player_buffer_unittest.cc [modify] https://crrev.com/fb754cc9313afa87032928438e9ffbdcc6e269d5/remoting/client/audio/audio_player_unittest.cc [add] https://crrev.com/fb754cc9313afa87032928438e9ffbdcc6e269d5/remoting/client/audio/audio_stream_consumer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77a375aa4b6b5e229f9a0d7e914970dbe4fa75ce commit 77a375aa4b6b5e229f9a0d7e914970dbe4fa75ce Author: Scott Nichols <nicholss@chromium.org> Date: Tue Sep 19 20:49:02 2017 Implementation of the iOS audio player for CRD. Bug: 611181 Change-Id: Ie1e5d658455ac553ece2417cd3b11e86fbbafe61 Reviewed-on: https://chromium-review.googlesource.com/630336 Commit-Queue: Scott Nichols <nicholss@chromium.org> Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#502943} [modify] https://crrev.com/77a375aa4b6b5e229f9a0d7e914970dbe4fa75ce/remoting/client/audio/audio_player_buffer.cc [modify] https://crrev.com/77a375aa4b6b5e229f9a0d7e914970dbe4fa75ce/remoting/client/audio/audio_player_buffer.h [modify] https://crrev.com/77a375aa4b6b5e229f9a0d7e914970dbe4fa75ce/remoting/client/audio/audio_stream_consumer.h [modify] https://crrev.com/77a375aa4b6b5e229f9a0d7e914970dbe4fa75ce/remoting/client/chromoting_client.cc [modify] https://crrev.com/77a375aa4b6b5e229f9a0d7e914970dbe4fa75ce/remoting/client/chromoting_client.h [modify] https://crrev.com/77a375aa4b6b5e229f9a0d7e914970dbe4fa75ce/remoting/client/chromoting_client_runtime.cc [modify] https://crrev.com/77a375aa4b6b5e229f9a0d7e914970dbe4fa75ce/remoting/client/chromoting_client_runtime.h [modify] https://crrev.com/77a375aa4b6b5e229f9a0d7e914970dbe4fa75ce/remoting/ios/app/BUILD.gn [add] https://crrev.com/77a375aa4b6b5e229f9a0d7e914970dbe4fa75ce/remoting/ios/audio/BUILD.gn [add] https://crrev.com/77a375aa4b6b5e229f9a0d7e914970dbe4fa75ce/remoting/ios/audio/audio_player_ios.h [add] https://crrev.com/77a375aa4b6b5e229f9a0d7e914970dbe4fa75ce/remoting/ios/audio/audio_player_ios.mm [add] https://crrev.com/77a375aa4b6b5e229f9a0d7e914970dbe4fa75ce/remoting/ios/audio/audio_stream_consumer_proxy.cc [add] https://crrev.com/77a375aa4b6b5e229f9a0d7e914970dbe4fa75ce/remoting/ios/audio/audio_stream_consumer_proxy.h [modify] https://crrev.com/77a375aa4b6b5e229f9a0d7e914970dbe4fa75ce/remoting/ios/session/remoting_client.mm
Verified Fixed in 64.0.3216.0
Comment 1 by jamiewa...@chromium.org
, May 12 2016Owner: nicho...@chromium.org
Status: Assigned (was: Untriaged)