New issue
Advanced search Search tips

Issue 611162 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

SSLUITest.TestUnsafeContents doesn't properly check iframe contents

Project Member Reported by mea...@chromium.org, May 11 2016

Issue description

This test loads an iframe over broken SSL, but it doesn't check iframe contents properly (because IsShowingWebContentsModalDialog it uses is broken).
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/416ca89721fe8b3f3559d121d0025b0df5bcbb44

commit 416ca89721fe8b3f3559d121d0025b0df5bcbb44
Author: meacer <meacer@chromium.org>
Date: Thu May 12 23:24:42 2016

Fix checking of iframe contents in SSLUITest.TestUnsafeContents.

This test attempts to check if iframe contents served over bad SSL are blocked, but it has
several problems:
- The page iframed in the test (bad_iframe.html) doesn't actually attempt to open a popup.
- Even if it did, it wouldn't be able to because it doesn't run inside a user gesture.
- The test uses IsShowingWebContentsModalDialog function to check if the popup opened, but
that function doesn't work properly.

This CL adds popup code to bad_iframe.html, allows popups without a user gesture and properly
checks if the popup opened or was blocked. It also adds a sanity check to make sure
subresources served over good SSL aren't blocked.

BUG= 611162 

Review-Url: https://codereview.chromium.org/1970893002
Cr-Commit-Position: refs/heads/master@{#393394}

[modify] https://crrev.com/416ca89721fe8b3f3559d121d0025b0df5bcbb44/chrome/browser/ssl/ssl_browser_tests.cc
[modify] https://crrev.com/416ca89721fe8b3f3559d121d0025b0df5bcbb44/chrome/test/data/ssl/bad_iframe.html
[modify] https://crrev.com/416ca89721fe8b3f3559d121d0025b0df5bcbb44/chrome/test/data/ssl/page_with_unsafe_contents.html

Comment 2 by mea...@chromium.org, May 12 2016

Status: Fixed (was: Started)
Components: -Security>UX
Labels: Team-Security-UX
Security>UX component is deprecated in favor of the Team-Security-UX label

Sign in to add a comment