Issue 611161 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	mdjones@chromium.org
Closed:	Feb 2018
Components:	UI>Browser>ReaderMode
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug

Extra navigations in desktop reader mode

Project Member Reported by wychen@chromium.org, May 11 2016

Issue description

Version: M51

What steps will reproduce the problem?
(1) Enable dom distiller on desktop
(2) Visit any web page and distill it
(3) Go back in history

What is the expected output?
We should go back to the original page.

What do you see instead?
We need to hit back for 3 times to go to the original page.
The culprit is https://codereview.chromium.org/1575473002/, which added #loaded up to twice to the location.

Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80ef02b21fe174b3c6a4588b1f6984b13f4d88f4

commit 80ef02b21fe174b3c6a4588b1f6984b13f4d88f4
Author: mdjones <mdjones@chromium.org>
Date: Wed May 11 21:36:14 2016

Only trigger navigation in distiller if in print preview

BUG= 605432 ,  611161 

Review-Url: https://codereview.chromium.org/1920563002
Cr-Commit-Position: refs/heads/master@{#393065}

[modify] https://crrev.com/80ef02b21fe174b3c6a4588b1f6984b13f4d88f4/chrome/browser/ui/webui/print_preview/print_preview_distiller.cc
[modify] https://crrev.com/80ef02b21fe174b3c6a4588b1f6984b13f4d88f4/components/dom_distiller/core/javascript/dom_distiller_viewer.js

Comment 2 by wychen@chromium.org, May 16 2016

Labels: Merge-Request-51

Comment 3 by tin...@google.com, May 16 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved

Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 4 by wychen@chromium.org, May 16 2016

Labels: -Hotlist-Merge-Approved -Merge-Approved-51

The culprit CL https://codereview.chromium.org/1575473002/ is after 2704. No need to merge.

Comment 5 by mdjones@chromium.org, Feb 8 2018

Status: Fixed (was: Untriaged)

►

Issue 611161 link

Issue metadata

Extra navigations in desktop reader mode

Issue description

Comment 1 by bugdroid1@chromium.org, May 11 2016

Comment 1 Deleted

Comment 2 by wychen@chromium.org, May 16 2016

Comment 2 Deleted

Comment 3 by tin...@google.com, May 16 2016

Comment 3 Deleted

Comment 4 by wychen@chromium.org, May 16 2016

Comment 4 Deleted

Comment 5 by mdjones@chromium.org, Feb 8 2018

Comment 5 Deleted

Sign in to add a comment