New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611149 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Swarming API swarming.task.result does not have include_performance_stats option

Project Member Reported by bore...@google.com, May 11 2016

Issue description

Swarming API swarming.task.result does not have include_performance_stats option

This is needed for obtaining the performance stats of a single task.
 

Comment 1 by mar...@chromium.org, May 12 2016

It has
https://apis-explorer.appspot.com/apis-explorer/?base=https://chromium-swarm.appspot.com/_ah/api#p/swarming/v1/swarming.task.result

It's a flag to pass as a GET query (since this request is ultimately cacheable when the task is completed).

Here's an example:
https://apis-explorer.appspot.com/apis-explorer/?base=https://chromium-swarm.appspot.com/_ah/api#p/swarming/v1/swarming.task.result?task_id=2ebe1ebf3b15e010&include_performance_stats=true&_h=2&

There's no flag in the client tool to specify this. Is that the request here?

Comment 2 by bore...@google.com, May 12 2016

Great!  So yes, it looks like the client just needs to be updated to add the flag, eg. https://github.com/luci/luci-go/blob/master/common/api/swarming/swarming/v1/swarming-gen.go#L2455

Comment 3 by mar...@chromium.org, May 12 2016

Cc: rogerta@chromium.org no...@chromium.org
Yes, I was waiting for https://codereview.chromium.org/1946253003/ to be committed first be you can regenerate the files right away with //tools/cmd/apigen.

Comment 5 by bore...@google.com, May 20 2016

Owner: borenet@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment