New issue
Advanced search Search tips

Issue 611125 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Smooth progress bar behavior completely erratic on JellyBean

Project Member Reported by mdjones@chromium.org, May 11 2016

Issue description

1. Enable smooth progress bar animation in chrome://flags.
2. Load any page on Android JellyBean and watch the insanity in the progress bar.

 
This appears to be the result of ValueAnimator and TimeAnimator sending an initial huge value for deltaTime on JellyBean. Newer platforms send 0 for the first update.
Project Member

Comment 2 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f8f44e6740bda7e9015e252db16cc869721e3a8

commit 2f8f44e6740bda7e9015e252db16cc869721e3a8
Author: mdjones <mdjones@chromium.org>
Date: Thu May 12 00:14:15 2016

Fix smooth progress behavior on JellyBean

The animators in JellyBean send a delta time fom the last time an
animation played instead of 0 for the first frame after an animation
starts. A combination of this and a misplaced "max" function
completely derailed the smooth progress bar animation.

This change also addresses a crash that only occures on JellyBean
that involves early cancellation of a running animation. After the
animation is canceled, the animator tries to run doAnimationFrame
with an empty list of updates. The animation is now allowed to run
itself out. (This should have no visible affect on the animation
since it becomes transparent near completion).

BUG= 611125 , 610522

Review-Url: https://codereview.chromium.org/1966943004
Cr-Commit-Position: refs/heads/master@{#393113}

[modify] https://crrev.com/2f8f44e6740bda7e9015e252db16cc869721e3a8/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java
[modify] https://crrev.com/2f8f44e6740bda7e9015e252db16cc869721e3a8/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java

Comment 3 by ram...@chromium.org, May 12 2016

Not able to repro with latest build.
Status: Fixed (was: Assigned)

Sign in to add a comment