LocationBarViewMac::UpdateLocationIcon() calls OmniboxView::GetVectorIcon(), and so will receive the new security icons when they land.

The ev_bubble_decoration receives its icon via LocationBarViewMac::UpdateLocationIcon(), which sets it to gfx::VectorIconId::LOCATION_BAR_HTTPS_VALID_IN_CHIP, which should also automatically receive the new icon.

https://codereview.chromium.org/1935663002/

FYI, the launch bug for new omnibox chip (ev + keyword search + popup) is here Issue 609929 and has been LGTM by UI review via email

Thank you for the info.

Note that Issue 604520 may have some helpful info (images, etc.).

Hello spqchan@, here is the Omnibox security state bug. This bug covers updates to the following:

    * Omnibox lock icons
    * EV cert update
    * Keyword search
    * Popup blocking

As noted in #4, the existing MD code should just pick up the new Omnibox lock icons.

Please see #1 in Issue 609929 for the Drive link to a folder that contains specs for changes 2-4. The ones you want to look at are:

    * Non-Touch-EV-Chip-Updated-200
    * Non-Touch-Keyword-Search-200
    * Non-Touch-Chip-Popup-blocked-200

You can ignore everything else in there.

Please feel free to create separate bugs for each of these changes. And let me know if you have any questions.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a76a3173e38bb3fab808ce5cdbf651d169f9194f

commit a76a3173e38bb3fab808ce5cdbf651d169f9194f
Author: spqchan <spqchan@chromium.org>
Date: Fri May 20 17:47:52 2016

Updated the EV cert update, Keyword search, and Popup blocking
decorations with the new specs

BUG= 611113 

Review-Url: https://codereview.chromium.org/1990703002
Cr-Commit-Position: refs/heads/master@{#395108}

[modify] https://crrev.com/a76a3173e38bb3fab808ce5cdbf651d169f9194f/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[modify] https://crrev.com/a76a3173e38bb3fab808ce5cdbf651d169f9194f/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm
[modify] https://crrev.com/a76a3173e38bb3fab808ce5cdbf651d169f9194f/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm
[modify] https://crrev.com/a76a3173e38bb3fab808ce5cdbf651d169f9194f/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h
[modify] https://crrev.com/a76a3173e38bb3fab808ce5cdbf651d169f9194f/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
[modify] https://crrev.com/a76a3173e38bb3fab808ce5cdbf651d169f9194f/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Hey Jayson, this looks great!

I talked with UI, and we actually don't need the colon in the chip (since we have the gray vertical bar for visual separation)

Could you remove the colon please?

Thanks!

Deleted: colon.png 13.4 KB

	colon.png 13.4 KB View Download

Should be no problem. spqchan@ - can you remove the colon from the text in keyword search?

spqchan -- take note of https://codereview.chromium.org/1998493002/ which adds a no-colon string for this.

That's great. We just need it to get cherry-picked back to M52.

It looks like the lock dances (movement in X and Y) a bit when you move between normal and EV. Not sure if this is a fix that needs to happen here or with the icon rendering (bug 604520) WDYT?

Deleted: dancing icon.gif 101 KB

	dancing icon.gif 101 KB View Download

It's also a different shape and a different color, unless this is due to rendering over top itself at an offset without erasing.

Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7de0ca5b7f66e36c74df676b9c0fbe2dc10364dd

commit 7de0ca5b7f66e36c74df676b9c0fbe2dc10364dd
Author: spqchan <spqchan@chromium.org>
Date: Fri Jun 03 17:11:33 2016

[Material][Mac] Adjustments to the Omnibox decorations

BUG= 613788 , 611113 

Review-Url: https://codereview.chromium.org/2002103003
Cr-Commit-Position: refs/heads/master@{#397734}

[modify] https://crrev.com/7de0ca5b7f66e36c74df676b9c0fbe2dc10364dd/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[modify] https://crrev.com/7de0ca5b7f66e36c74df676b9c0fbe2dc10364dd/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Your change meets the bar and is auto-approved for M52 (branch: 2743)

spqchan@ - would you work on cherry-picking this change tomorrow (Wednesday)? Thank you.

In progress

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2ec6ca0d527ce67090b6c7c7de05e2572022d51

commit a2ec6ca0d527ce67090b6c7c7de05e2572022d51
Author: spqchan <spqchan@chromium.org>
Date: Wed Jun 08 18:31:51 2016

[Material][Mac] Adjustments to the Omnibox decorations

BUG= 613788 , 611113 

Review-Url: https://codereview.chromium.org/2002103003
Cr-Commit-Position: refs/heads/master@{#397734}
(cherry picked from commit 7de0ca5b7f66e36c74df676b9c0fbe2dc10364dd)

Review URL: https://codereview.chromium.org/2050623004 .

Cr-Commit-Position: refs/branch-heads/2743@{#282}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/a2ec6ca0d527ce67090b6c7c7de05e2572022d51/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[modify] https://crrev.com/a2ec6ca0d527ce67090b6c7c7de05e2572022d51/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2ec6ca0d527ce67090b6c7c7de05e2572022d51

commit a2ec6ca0d527ce67090b6c7c7de05e2572022d51
Author: spqchan <spqchan@chromium.org>
Date: Wed Jun 08 18:31:51 2016

[Material][Mac] Adjustments to the Omnibox decorations

BUG= 613788 , 611113 

Review-Url: https://codereview.chromium.org/2002103003
Cr-Commit-Position: refs/heads/master@{#397734}
(cherry picked from commit 7de0ca5b7f66e36c74df676b9c0fbe2dc10364dd)

Review URL: https://codereview.chromium.org/2050623004 .

Cr-Commit-Position: refs/branch-heads/2743@{#282}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/a2ec6ca0d527ce67090b6c7c7de05e2572022d51/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[modify] https://crrev.com/a2ec6ca0d527ce67090b6c7c7de05e2572022d51/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

spqchan@ : Referring to the issue 604520 mocks tested the issue on Mac 10.11.5(MacBook Air).Could you please take a look into the screen shot attached here and let us know if its fine.

Deleted: 611113_June_16.png 147 KB

	611113_June_16.png 147 KB View Download

This doesn't look right, the bubbles shouldn't have a white background in incognito. What version did you tested this on?

Sorry forgot to mention the version, Its Beta # 52.0.2743.41.
The Lock icon is fine on Canary 53.0.2769.0.

Deleted: Screen Shot 2016-06-16 at 9.34.46 PM.png 142 KB

	Screen Shot 2016-06-16 at 9.34.46 PM.png 142 KB View Download

spqchan@ - it looks like the patch in #11 wasn't cherry-picked, so the beta still contains the old evcert, among other things. I'm going to check with tinazh@ to see if we need to request a merge again for this bug.

spqchan@ - the word from tinazh@ is we should be fine to merge #11 with the existing labels. So please cherry-pick this change back to M52 (changing from fixed to started to note that there's more to do on this issue).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b560782934efaa126709ed18ece370e90dbcf5b

commit 2b560782934efaa126709ed18ece370e90dbcf5b
Author: spqchan <spqchan@chromium.org>
Date: Fri Jun 17 22:21:00 2016

Updated the EV cert update, Keyword search, and Popup blocking decorations with the new specs

BUG= 611113 

Review-Url: https://codereview.chromium.org/1990703002
Cr-Commit-Position: refs/heads/master@{#395108}
(cherry picked from commit a76a3173e38bb3fab808ce5cdbf651d169f9194f)

Review URL: https://codereview.chromium.org/2075293002 .

Cr-Commit-Position: refs/branch-heads/2743@{#385}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/2b560782934efaa126709ed18ece370e90dbcf5b/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[modify] https://crrev.com/2b560782934efaa126709ed18ece370e90dbcf5b/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm
[modify] https://crrev.com/2b560782934efaa126709ed18ece370e90dbcf5b/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm
[modify] https://crrev.com/2b560782934efaa126709ed18ece370e90dbcf5b/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h
[modify] https://crrev.com/2b560782934efaa126709ed18ece370e90dbcf5b/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
[modify] https://crrev.com/2b560782934efaa126709ed18ece370e90dbcf5b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Thanks! My Chrome beta still says updated @ Version 52.0.2743.41 beta (64-bit) so I can't test. Could you let me know any instructions for how to test this? (Maybe I have to wait for them to cut a new beta?)

I believe the next beta will appear on 6/22.

Tested the issue on Mac 10.11.5 using 52.0.2743.49 as per bug 604520.
Please find attached screenshots of lock icon of chrome normal and incognito window.

spqchan@Could you please confirm if this is the expected behavior.

Deleted: 611113.jpg 223 KB

	611113.jpg 223 KB View Download

For HTTPS (non EV), the lock should be green in regular mode and gray in Incognito - see attached mock.

Deleted: Non-Touch-Secure-100.png 125 KB

	Non-Touch-Secure-100.png 125 KB View Download

spqchan@ - I discovered yesterday that at least some of the icon colors don't match the security icon spec. I'm thinking it might be good to create a separate bug to fix the issue in #38 and to bring the other colors inline with the spec, which I've attached. Note that the top icon (100% opaque white) is the icon color for Incognito.

Deleted: Non-Touch-Colors.png 57.2 KB

	Non-Touch-Colors.png 57.2 KB View Download

Maybe that separate bug should just be  Issue 621068 .

Yeah, it's missing the 80% opacity. I'll investigate this.