New issue
Advanced search Search tips

Issue 611112 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 621644

Blocking:
issue 405845



Sign in to add a comment

DevTools: Console - Entering large object in console slows experience

Project Member Reported by l...@chromium.org, May 11 2016

Issue description

When entering in a huge, plain object into the JS console, it takes a really long time to render the input with <span>'s.  The experience could be improved by rendering objects longer than X characters as text instead of DOM elements.

Test object: https://gist.github.com/anonymous/11c6d73205c43f72e53ae347489e5d28


What steps will reproduce the problem?
(1) Copy and paste the test object into the JS console
(2) Press Enter and observe slowdown

 

Comment 1 by l...@chromium.org, May 11 2016

Summary: DevTools: Console - Entering large object in console slows experience (was: Entering large object in console slows experience)
Yup!

We already disable our regex for hyperlinks with long strings. We should follow a similar mechanism for disabling codemirror formatting.

Comment 3 by l...@chromium.org, Jun 13 2016

Status: Started (was: Assigned)
CL in review
https://codereview.chromium.org/2058513003/
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f222f707cf66be00de0cec49cd86323884206b8

commit 9f222f707cf66be00de0cec49cd86323884206b8
Author: luoe <luoe@chromium.org>
Date: Mon Jun 20 23:42:56 2016

DevTools: max length limit for formatting commands

This CL makes sure that any console output is < 10000 characters before we try
to apply syntax highlighting to it. Otherwise, it becomes really slow.

BUG= 611112 

Review-Url: https://codereview.chromium.org/2058513003
Cr-Commit-Position: refs/heads/master@{#400836}

[modify] https://crrev.com/9f222f707cf66be00de0cec49cd86323884206b8/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
[modify] https://crrev.com/9f222f707cf66be00de0cec49cd86323884206b8/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Comment 5 by l...@chromium.org, Jun 20 2016

Blockedon: 621644
The CL above should avoid syntax highlighting when pasting large text.  However, once you start typing, it still feels sluggish due to #621644.

Comment 6 by l...@chromium.org, Jun 29 2016

Status: Fixed (was: Started)

Sign in to add a comment