[Bulk edit]

Setting tracking label Blimp-M53-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-53 scope, or remove this bug from M-53 scope.

Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

[Bulk edit]

Setting tracking label Blimp-M54-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-54 scope, or remove this bug from M-54 scope.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0842c2375c6039cd96a0f3bc44296f35cf1df1b8

commit 0842c2375c6039cd96a0f3bc44296f35cf1df1b8
Author: shaktisahu <shaktisahu@chromium.org>
Date: Fri Aug 19 21:47:18 2016

blimp: Moved ImeFeature to blimp/client/core/contents

BUG= 611111 

Review-Url: https://codereview.chromium.org/2251223002
Cr-Commit-Position: refs/heads/master@{#413257}

[modify] https://crrev.com/0842c2375c6039cd96a0f3bc44296f35cf1df1b8/blimp/client/BUILD.gn
[modify] https://crrev.com/0842c2375c6039cd96a0f3bc44296f35cf1df1b8/blimp/client/app/android/web_input_box.cc
[modify] https://crrev.com/0842c2375c6039cd96a0f3bc44296f35cf1df1b8/blimp/client/app/android/web_input_box.h
[modify] https://crrev.com/0842c2375c6039cd96a0f3bc44296f35cf1df1b8/blimp/client/app/linux/blimp_client_session_linux.h
[modify] https://crrev.com/0842c2375c6039cd96a0f3bc44296f35cf1df1b8/blimp/client/core/contents/BUILD.gn
[rename] https://crrev.com/0842c2375c6039cd96a0f3bc44296f35cf1df1b8/blimp/client/core/contents/ime_feature.cc
[rename] https://crrev.com/0842c2375c6039cd96a0f3bc44296f35cf1df1b8/blimp/client/core/contents/ime_feature.h
[rename] https://crrev.com/0842c2375c6039cd96a0f3bc44296f35cf1df1b8/blimp/client/core/contents/mock_ime_feature_delegate.cc
[rename] https://crrev.com/0842c2375c6039cd96a0f3bc44296f35cf1df1b8/blimp/client/core/contents/mock_ime_feature_delegate.h
[modify] https://crrev.com/0842c2375c6039cd96a0f3bc44296f35cf1df1b8/blimp/client/session/blimp_client_session.cc
[modify] https://crrev.com/0842c2375c6039cd96a0f3bc44296f35cf1df1b8/blimp/engine/browser_tests/engine_browsertest.cc

Leaving this at M-54.  Looks like we have one more patch to tie this into BlimpContentsAndroid.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4cf3a5402141314ca69bf9406a3061fc56f891f

commit b4cf3a5402141314ca69bf9406a3061fc56f891f
Author: shaktisahu <shaktisahu@chromium.org>
Date: Fri Aug 26 19:46:22 2016

Added features to BlimpClientContext and BlimpContents

This CL instantiates ImeFeature and NavigationFeature inside
BlimpClientContext. BlimpClientContext owns these features and passes
raw pointers to BlimpContents during construction.

BUG= 611111 

Review-Url: https://codereview.chromium.org/2258563003
Cr-Commit-Position: refs/heads/master@{#414786}

[modify] https://crrev.com/b4cf3a5402141314ca69bf9406a3061fc56f891f/blimp/client/core/blimp_client_context_impl.cc
[modify] https://crrev.com/b4cf3a5402141314ca69bf9406a3061fc56f891f/blimp/client/core/blimp_client_context_impl.h
[modify] https://crrev.com/b4cf3a5402141314ca69bf9406a3061fc56f891f/blimp/client/core/contents/blimp_contents_impl.cc
[modify] https://crrev.com/b4cf3a5402141314ca69bf9406a3061fc56f891f/blimp/client/core/contents/blimp_contents_impl.h
[modify] https://crrev.com/b4cf3a5402141314ca69bf9406a3061fc56f891f/blimp/client/core/contents/blimp_contents_impl_unittest.cc
[modify] https://crrev.com/b4cf3a5402141314ca69bf9406a3061fc56f891f/blimp/client/core/contents/blimp_contents_manager.cc
[modify] https://crrev.com/b4cf3a5402141314ca69bf9406a3061fc56f891f/blimp/client/core/contents/blimp_contents_manager.h
[modify] https://crrev.com/b4cf3a5402141314ca69bf9406a3061fc56f891f/blimp/client/core/contents/blimp_contents_manager_unittest.cc
[modify] https://crrev.com/b4cf3a5402141314ca69bf9406a3061fc56f891f/blimp/client/core/contents/blimp_contents_observer_unittest.cc
[modify] https://crrev.com/b4cf3a5402141314ca69bf9406a3061fc56f891f/blimp/client/core/contents/blimp_navigation_controller_impl.cc
[modify] https://crrev.com/b4cf3a5402141314ca69bf9406a3061fc56f891f/blimp/client/core/contents/blimp_navigation_controller_impl.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10a8e63afa2ca6e91671293fa6c2781c32ea1162

commit 10a8e63afa2ca6e91671293fa6c2781c32ea1162
Author: shaktisahu <shaktisahu@chromium.org>
Date: Thu Sep 01 00:28:42 2016

Changed Blimp IME to use PopUp

Blimp IME currently shows an EditText on the top of the soft keyboard.
This CL changes it to use a popup instead based on an AlertDialog.
WebInputBox was renamed to ImeHelperDialog which contains an ImeEditText.
This change also fixes the issue of view resize due to IME.

BUG= 611111 

Review-Url: https://codereview.chromium.org/2261853002
Cr-Commit-Position: refs/heads/master@{#415819}

[modify] https://crrev.com/10a8e63afa2ca6e91671293fa6c2781c32ea1162/blimp/client/BUILD.gn
[modify] https://crrev.com/10a8e63afa2ca6e91671293fa6c2781c32ea1162/blimp/client/app/android/blimp_app_jni_registrar.cc
[rename] https://crrev.com/10a8e63afa2ca6e91671293fa6c2781c32ea1162/blimp/client/app/android/ime_helper_dialog.cc
[rename] https://crrev.com/10a8e63afa2ca6e91671293fa6c2781c32ea1162/blimp/client/app/android/ime_helper_dialog.h
[modify] https://crrev.com/10a8e63afa2ca6e91671293fa6c2781c32ea1162/blimp/client/app/android/java/res/layout/blimp_main.xml
[add] https://crrev.com/10a8e63afa2ca6e91671293fa6c2781c32ea1162/blimp/client/app/android/java/res/layout/text_input_popup.xml
[modify] https://crrev.com/10a8e63afa2ca6e91671293fa6c2781c32ea1162/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java
[add] https://crrev.com/10a8e63afa2ca6e91671293fa6c2781c32ea1162/blimp/client/app/android/java/src/org/chromium/blimp/input/ImeEditText.java
[add] https://crrev.com/10a8e63afa2ca6e91671293fa6c2781c32ea1162/blimp/client/app/android/java/src/org/chromium/blimp/input/ImeHelperDialog.java
[delete] https://crrev.com/34ca6f6990519850bd0831d0da74bf511d056290/blimp/client/app/android/java/src/org/chromium/blimp/input/WebInputBox.java
[modify] https://crrev.com/10a8e63afa2ca6e91671293fa6c2781c32ea1162/blimp/client/app/android/java/strings/android_blimp_strings.grd
[modify] https://crrev.com/10a8e63afa2ca6e91671293fa6c2781c32ea1162/build/android/lint/suppressions.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbc30df32da8a742e26ac283114d8c72291e2347

commit dbc30df32da8a742e26ac283114d8c72291e2347
Author: shaktisahu <shaktisahu@chromium.org>
Date: Thu Sep 01 03:08:00 2016

Hooking up Blimp IME with BlimpContents

This CL hooks up the ImeFeature and its delegate with BlimpContents.
The IME is an Android AlertDialog driven by ImeHelperDialog in native
which implements the ImeFeature's delegate interface and is owned in
native by the BlimpContentsView. The methods from ImeFeature for
sending text to engine is passed to the delegate as a callback which
binds the appropriate tab ID along with it.

BUG= 611111 

Review-Url: https://codereview.chromium.org/2292343002
Cr-Commit-Position: refs/heads/master@{#415867}

[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/BUILD.gn
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/app/android/AndroidManifest.xml.jinja2
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/app/android/blimp_app_jni_registrar.cc
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/app/android/blimp_client_session_android.cc
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/app/android/blimp_client_session_android.h
[delete] https://crrev.com/ebf057e94cd8ca83476f8780ae7419f7ba8746cf/blimp/client/app/android/ime_helper_dialog.cc
[delete] https://crrev.com/ebf057e94cd8ca83476f8780ae7419f7ba8746cf/blimp/client/app/android/ime_helper_dialog.h
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/app/android/java/res/layout/text_input_popup.xml
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/app/android/java/src/org/chromium/blimp/session/BlimpClientSession.java
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/app/linux/blimp_client_session_linux.cc
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/BUILD.gn
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/android/blimp_contents_jni_registrar.cc
[add] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/android/ime_helper_dialog.cc
[add] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/android/ime_helper_dialog.h
[rename] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/input/ImeEditText.java
[rename] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/input/ImeHelperDialog.java
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/blimp_contents_impl.cc
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/blimp_contents_impl.h
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/blimp_contents_impl_unittest.cc
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/blimp_contents_manager_unittest.cc
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/blimp_contents_observer_unittest.cc
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/blimp_contents_view.h
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/blimp_contents_view_android.cc
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/blimp_contents_view_android.h
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/blimp_contents_view_aura.cc
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/blimp_contents_view_aura.h
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/ime_feature.cc
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/ime_feature.h
[modify] https://crrev.com/dbc30df32da8a742e26ac283114d8c72291e2347/blimp/client/core/contents/mock_ime_feature_delegate.h

Blimp IME was changed into a popup dialog and owned by BlimpContents.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1677c09d3a29f04fc873b9c0d3188f72eb22e16d

commit 1677c09d3a29f04fc873b9c0d3188f72eb22e16d
Author: shaktisahu <shaktisahu@chromium.org>
Date: Wed Sep 07 06:15:49 2016

blimp: Fix for multiple show IME messages

Some websites trigger multiple Show IME messages for the same textbox
which generates multiple popups superimposed one over another. This CL
avoids creating multiple popups.

BUG= 611111 

Review-Url: https://codereview.chromium.org/2303263003
Cr-Commit-Position: refs/heads/master@{#416860}

[modify] https://crrev.com/1677c09d3a29f04fc873b9c0d3188f72eb22e16d/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/input/ImeHelperDialog.java