New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 611105 link

Starred by 1 user
Status: Fixed
Owner:
khushals...@chromium.org
Closed: Sep 2016
Cc:
█ nyquist@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocked on:
issue 639950
Blocking:
issue 597756
issue 599621



Sign in to add a comment

Implement compositor output sharing using a ViewAndroid.

Project Member Reported by dtrainor@chromium.org, May 11 2016 
- Build a BlimpHostView to replace the BlimpCompositor in v0.5.
- Multiple instances of these can be alive at any time for a particular tab (see v0.5 code).
- Create the blimp compositor instance, have it render to a layer instead of directly to a SurfaceView surface as it does now.

Comment 1 by dtrainor@chromium.org, May 11 2016 

The BlimpHostView needs to basically replace the RenderWidgetHostViewAndroid in ContentViewCore.

Comment 2 by haibinlu@chromium.org, May 16 2016 

with site isolation, Engine will have multiple render frames per tab. Does this affect BlimpHostView?

Comment 3 by amineer@chromium.org, May 25 2016

Labels: Blimp-M53-Proj-Scope
[Bulk edit]

Setting tracking label Blimp-M53-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-53 scope, or remove this bug from M-53 scope.
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 10 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by dtrainor@chromium.org, Jul 18 2016

Cc: khushals...@chromium.org

Comment 6 by dtrainor@chromium.org, Jul 18 2016

Cc: -khushals...@chromium.org nyquist@chromium.org
Owner: khushals...@chromium.org

Comment 7 by amineer@chromium.org, Jul 26 2016

Labels: Blimp-M54-Proj-Scope
[Bulk edit]

Setting tracking label Blimp-M54-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-54 scope, or remove this bug from M-54 scope.

Comment 8 by khushals...@chromium.org, Aug 22 2016

Summary: Implement compositor output sharing using a ViewAndroid. (was: Create BlimpHostView)

Comment 9 by khushals...@chromium.org, Aug 22 2016

Blockedon: 639950

Comment 10 by dtrainor@chromium.org, Aug 23 2016

Labels: -M-54 M-55
Moving to M-55.  This should be implemented (although maybe in a slightly different form) soon.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/030bd21d33b79c73c3f5376f7ed0a976660e8b33

commit 030bd21d33b79c73c3f5376f7ed0a976660e8b33
Author: khushalsagar <khushalsagar@chromium.org>
Date: Tue Aug 30 03:51:48 2016

blimp: Hook up the layer holding the tab content into Chrome.

Introduce a BlimpContentsView to blimp which abstracts the platform
dependent view needs. Have it own the ViewAndroid and expose it to the
embedder using the BlimpContents. Have Chrome attach the cc::Layer
holding the delegated content from Blimp to the tab's content layer.

BUG= 611105 

Review-Url: https://codereview.chromium.org/2279403003
Cr-Commit-Position: refs/heads/master@{#415061}

[modify] https://crrev.com/030bd21d33b79c73c3f5376f7ed0a976660e8b33/blimp/client/DEPS
[modify] https://crrev.com/030bd21d33b79c73c3f5376f7ed0a976660e8b33/blimp/client/core/contents/BUILD.gn
[modify] https://crrev.com/030bd21d33b79c73c3f5376f7ed0a976660e8b33/blimp/client/core/contents/blimp_contents_impl.cc
[modify] https://crrev.com/030bd21d33b79c73c3f5376f7ed0a976660e8b33/blimp/client/core/contents/blimp_contents_impl.h
[add] https://crrev.com/030bd21d33b79c73c3f5376f7ed0a976660e8b33/blimp/client/core/contents/blimp_contents_view.h
[add] https://crrev.com/030bd21d33b79c73c3f5376f7ed0a976660e8b33/blimp/client/core/contents/blimp_contents_view_android.cc
[add] https://crrev.com/030bd21d33b79c73c3f5376f7ed0a976660e8b33/blimp/client/core/contents/blimp_contents_view_android.h
[add] https://crrev.com/030bd21d33b79c73c3f5376f7ed0a976660e8b33/blimp/client/core/contents/blimp_contents_view_aura.cc
[add] https://crrev.com/030bd21d33b79c73c3f5376f7ed0a976660e8b33/blimp/client/core/contents/blimp_contents_view_aura.h
[modify] https://crrev.com/030bd21d33b79c73c3f5376f7ed0a976660e8b33/blimp/client/public/BUILD.gn
[modify] https://crrev.com/030bd21d33b79c73c3f5376f7ed0a976660e8b33/blimp/client/public/contents/blimp_contents.h
[modify] https://crrev.com/030bd21d33b79c73c3f5376f7ed0a976660e8b33/chrome/browser/android/tab_android.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915

commit 7cb0bd5a02b78ac0b8631a1329baafe89e1ff915
Author: dtrainor <dtrainor@chromium.org>
Date: Tue Aug 30 04:31:25 2016

Expose Blimp dependencies to the embedder

Move Blimp compositor dependencies out to an interface that can be
implemented by the embedder.  Update blimp/client/app to use this
interface.

BUG= 611105 

Review-Url: https://codereview.chromium.org/2274323002
Cr-Commit-Position: refs/heads/master@{#415097}

[modify] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/BUILD.gn
[delete] https://crrev.com/c7e292ea58a76fe27c6c247bc640054bcf4cb6aa/blimp/client/app/android/blimp_compositor_manager_android.cc
[delete] https://crrev.com/c7e292ea58a76fe27c6c247bc640054bcf4cb6aa/blimp/client/app/android/blimp_compositor_manager_android.h
[modify] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/app/android/blimp_view.cc
[modify] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/app/android/blimp_view.h
[modify] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/app/compositor/browser_compositor.cc
[modify] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/app/compositor/browser_compositor.h
[modify] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/app/linux/blimp_display_manager.cc
[modify] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/app/linux/blimp_display_manager.h
[modify] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/core/compositor/BUILD.gn
[add] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/core/compositor/blimp_compositor_dependencies.cc
[add] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/core/compositor/blimp_compositor_dependencies.h
[modify] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/feature/compositor/blimp_compositor.cc
[modify] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/feature/compositor/blimp_compositor.h
[modify] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/feature/compositor/blimp_compositor_manager.cc
[modify] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/feature/compositor/blimp_compositor_manager.h
[modify] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/feature/compositor/blimp_compositor_manager_unittest.cc
[modify] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/feature/compositor/blimp_compositor_unittest.cc
[add] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/feature/compositor/mock_compositor_dependencies.cc
[add] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/feature/compositor/mock_compositor_dependencies.h
[modify] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/public/BUILD.gn
[add] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/public/compositor/compositor_dependencies.h
[add] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/support/BUILD.gn
[add] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/support/compositor/BUILD.gn
[rename] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/support/compositor/blimp_context_provider.cc
[rename] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/support/compositor/blimp_context_provider.h
[rename] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/support/compositor/blimp_gpu_memory_buffer_manager.cc
[rename] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/support/compositor/blimp_gpu_memory_buffer_manager.h
[rename] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/support/compositor/blimp_layer_tree_settings.cc
[rename] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/support/compositor/blimp_layer_tree_settings.h
[add] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/support/compositor/compositor_dependencies_impl.cc
[add] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/client/support/compositor/compositor_dependencies_impl.h
[modify] https://crrev.com/7cb0bd5a02b78ac0b8631a1329baafe89e1ff915/blimp/common/BUILD.gn
[delete] https://crrev.com/c7e292ea58a76fe27c6c247bc640054bcf4cb6aa/blimp/common/compositor/blimp_task_graph_runner.cc
[delete] https://crrev.com/c7e292ea58a76fe27c6c247bc640054bcf4cb6aa/blimp/common/compositor/blimp_task_graph_runner.h
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4699d62ad6d10c58b26e71dce4f459f6ab967b4f

commit 4699d62ad6d10c58b26e71dce4f459f6ab967b4f
Author: dtrainor <dtrainor@chromium.org>
Date: Wed Aug 31 15:51:55 2016

Move remaining Blimp feature code to core.

Migrate the last two features (render widget and settings) from blimp/client/features to blimp/client/core.  This required adding support for BlimpCompositorDependencies throughout blimp/client/core and exposing a CompositorDependencies class in the constructor of BlimpClientContext as well.

BUG= 611105 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2292723003
Cr-Commit-Position: refs/heads/master@{#415642}

[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/BUILD.gn
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/BUILD.gn
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/app/android/blimp_client_session_android.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/app/android/blimp_view.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/app/android/blimp_view.h
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/app/linux/blimp_display_manager.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/BUILD.gn
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/android/blimp_client_context_impl_android.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/android/blimp_client_context_impl_android.h
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/blimp_client_context_impl.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/blimp_client_context_impl.h
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/blimp_client_context_impl_unittest.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/compositor/BUILD.gn
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/compositor/blimp_compositor.cc
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/compositor/blimp_compositor.h
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/compositor/blimp_compositor_manager.cc
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/compositor/blimp_compositor_manager.h
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/compositor/blimp_compositor_manager_unittest.cc
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/compositor/blimp_compositor_unittest.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/compositor/blob_image_serialization_processor.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/compositor/blob_image_serialization_processor.h
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/contents/BUILD.gn
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/contents/android/blimp_contents_impl_android.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/contents/android/blimp_contents_impl_android.h
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpContentsImpl.java
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/contents/blimp_contents_impl.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/contents/blimp_contents_impl.h
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/contents/blimp_contents_impl_unittest.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/contents/blimp_contents_manager.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/contents/blimp_contents_manager.h
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/contents/blimp_contents_manager_unittest.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/contents/blimp_contents_observer_unittest.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/contents/blimp_contents_view.h
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/contents/blimp_contents_view_android.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/contents/blimp_contents_view_android.h
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/contents/blimp_contents_view_aura.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/dummy_blimp_client_context.cc
[add] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/input/BUILD.gn
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/input/blimp_input_handler_wrapper.cc
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/input/blimp_input_handler_wrapper.h
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/input/blimp_input_manager.cc
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/input/blimp_input_manager.h
[add] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/render_widget/BUILD.gn
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/render_widget/mock_render_widget_feature_delegate.cc
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/render_widget/mock_render_widget_feature_delegate.h
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/render_widget/render_widget_feature.cc
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/render_widget/render_widget_feature.h
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/render_widget/render_widget_feature_unittest.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/settings/BUILD.gn
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/settings/settings_feature.cc
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/core/settings/settings_feature.h
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContents.java
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/public/blimp_client_context.h
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/public/contents/blimp_contents.h
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/session/blimp_client_session.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/support/BUILD.gn
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/support/compositor/BUILD.gn
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/support/compositor/mock_compositor_dependencies.cc
[rename] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/client/support/compositor/mock_compositor_dependencies.h
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/engine/BUILD.gn
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/blimp/engine/browser_tests/engine_browsertest.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/cc/blimp/image_serialization_processor.h
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/cc/layers/picture_layer.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/cc/trees/layer_tree_host.h
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/4699d62ad6d10c58b26e71dce4f459f6ab967b4f/chrome/browser/android/blimp/blimp_client_context_factory.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9

commit 8ecea2e7082ed06d138d5b74f8a6cff2873b6af9
Author: khushalsagar <khushalsagar@chromium.org>
Date: Fri Sep 02 20:25:57 2016

blimp: Set up the CompositorDependencies for blimp in Chrome.

Add ChromeCompositorDependencies to implement the CompositorDependencies
for blimp in Chrome. The class passes through to the
ui::ContextProviderFactory to create the contexts.

TBR=jochen

BUG= 611105 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2297933002
Cr-Commit-Position: refs/heads/master@{#416333}

[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/blimp/client/app/compositor/browser_compositor.cc
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/blimp/client/core/compositor/BUILD.gn
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/blimp/client/core/compositor/blimp_compositor.cc
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/blimp/client/core/compositor/blimp_compositor.h
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/blimp/client/core/compositor/blimp_compositor_dependencies.cc
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/blimp/client/core/compositor/blimp_compositor_dependencies.h
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/blimp/client/public/blimp_client_context.h
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/blimp/client/public/compositor/compositor_dependencies.h
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/blimp/client/support/compositor/blimp_context_provider.cc
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/blimp/client/support/compositor/blimp_context_provider.h
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/blimp/client/support/compositor/blimp_layer_tree_settings.cc
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/blimp/client/support/compositor/compositor_dependencies_impl.cc
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/blimp/client/support/compositor/compositor_dependencies_impl.h
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/blimp/client/support/compositor/mock_compositor_dependencies.cc
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/blimp/client/support/compositor/mock_compositor_dependencies.h
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/chrome/browser/BUILD.gn
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/chrome/browser/android/DEPS
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/chrome/browser/android/blimp/blimp_client_context_factory.cc
[add] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/chrome/browser/android/blimp/chrome_compositor_dependencies.cc
[add] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/chrome/browser/android/blimp/chrome_compositor_dependencies.h
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/content/browser/browser_main_loop.cc
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/content/browser/renderer_host/compositor_impl_android.h
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/content/browser/renderer_host/context_provider_factory_impl_android.cc
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/content/browser/renderer_host/context_provider_factory_impl_android.h
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/content/content_tests.gypi
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/content/public/test/test_renderer_host.cc
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/content/public/test/test_renderer_host.h
[add] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/content/test/mock_gpu_channel_establish_factory.cc
[add] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/content/test/mock_gpu_channel_establish_factory.h
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/content/test/test_render_view_host.cc
[modify] https://crrev.com/8ecea2e7082ed06d138d5b74f8a6cff2873b6af9/ui/android/context_provider_factory.h

Comment 15 by nyquist@chromium.org, Sep 3 2016

Status: Fixed (was: Assigned)
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 1 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7f3b2678c1edbc889b2af9444bc2051413fe101

commit f7f3b2678c1edbc889b2af9444bc2051413fe101
Author: Khushal <khushalsagar@google.com>
Date: Sat Oct 01 01:10:59 2016

blimp: Set up the CompositorDependencies for blimp in Chrome.

Add ChromeCompositorDependencies to implement the CompositorDependencies
for blimp in Chrome. The class passes through to the
ui::ContextProviderFactory to create the contexts.

TBR=jochen

BUG= 611105 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2297933002
Cr-Commit-Position: refs/heads/master@{#416333}
(cherry picked from commit 8ecea2e7082ed06d138d5b74f8a6cff2873b6af9)

# Conflicts:
#	blimp/client/app/compositor/browser_compositor.cc
#	blimp/client/core/compositor/BUILD.gn
#	blimp/client/core/compositor/blimp_compositor.cc
#	blimp/client/core/compositor/blimp_compositor.h
#	blimp/client/core/compositor/blimp_compositor_dependencies.cc
#	blimp/client/core/compositor/blimp_compositor_dependencies.h
#	blimp/client/public/blimp_client_context.h
#	blimp/client/public/compositor/compositor_dependencies.h
#	blimp/client/support/compositor/blimp_context_provider.cc
#	blimp/client/support/compositor/blimp_context_provider.h
#	blimp/client/support/compositor/blimp_layer_tree_settings.cc
#	blimp/client/support/compositor/compositor_dependencies_impl.cc
#	blimp/client/support/compositor/compositor_dependencies_impl.h
#	blimp/client/support/compositor/mock_compositor_dependencies.cc
#	blimp/client/support/compositor/mock_compositor_dependencies.h
#	chrome/browser/BUILD.gn
#	chrome/browser/android/DEPS
#	chrome/browser/android/blimp/blimp_client_context_factory.cc

Cr-Commit-Position: refs/branch-heads/2840@{#613}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/browser/browser_main_loop.cc
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/browser/renderer_host/compositor_impl_android.h
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/browser/renderer_host/context_provider_factory_impl_android.cc
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/browser/renderer_host/context_provider_factory_impl_android.h
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/content_tests.gypi
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/public/test/test_renderer_host.cc
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/public/test/test_renderer_host.h
[add] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/test/mock_gpu_channel_establish_factory.cc
[add] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/test/mock_gpu_channel_establish_factory.h
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/test/test_render_view_host.cc
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/ui/android/context_provider_factory.h
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7f3b2678c1edbc889b2af9444bc2051413fe101

commit f7f3b2678c1edbc889b2af9444bc2051413fe101
Author: Khushal <khushalsagar@google.com>
Date: Sat Oct 01 01:10:59 2016

blimp: Set up the CompositorDependencies for blimp in Chrome.

Add ChromeCompositorDependencies to implement the CompositorDependencies
for blimp in Chrome. The class passes through to the
ui::ContextProviderFactory to create the contexts.

TBR=jochen

BUG= 611105 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2297933002
Cr-Commit-Position: refs/heads/master@{#416333}
(cherry picked from commit 8ecea2e7082ed06d138d5b74f8a6cff2873b6af9)

# Conflicts:
#	blimp/client/app/compositor/browser_compositor.cc
#	blimp/client/core/compositor/BUILD.gn
#	blimp/client/core/compositor/blimp_compositor.cc
#	blimp/client/core/compositor/blimp_compositor.h
#	blimp/client/core/compositor/blimp_compositor_dependencies.cc
#	blimp/client/core/compositor/blimp_compositor_dependencies.h
#	blimp/client/public/blimp_client_context.h
#	blimp/client/public/compositor/compositor_dependencies.h
#	blimp/client/support/compositor/blimp_context_provider.cc
#	blimp/client/support/compositor/blimp_context_provider.h
#	blimp/client/support/compositor/blimp_layer_tree_settings.cc
#	blimp/client/support/compositor/compositor_dependencies_impl.cc
#	blimp/client/support/compositor/compositor_dependencies_impl.h
#	blimp/client/support/compositor/mock_compositor_dependencies.cc
#	blimp/client/support/compositor/mock_compositor_dependencies.h
#	chrome/browser/BUILD.gn
#	chrome/browser/android/DEPS
#	chrome/browser/android/blimp/blimp_client_context_factory.cc

Cr-Commit-Position: refs/branch-heads/2840@{#613}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/browser/browser_main_loop.cc
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/browser/renderer_host/compositor_impl_android.h
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/browser/renderer_host/context_provider_factory_impl_android.cc
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/browser/renderer_host/context_provider_factory_impl_android.h
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/content_tests.gypi
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/public/test/test_renderer_host.cc
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/public/test/test_renderer_host.h
[add] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/test/mock_gpu_channel_establish_factory.cc
[add] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/test/mock_gpu_channel_establish_factory.h
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/content/test/test_render_view_host.cc
[modify] https://crrev.com/f7f3b2678c1edbc889b2af9444bc2051413fe101/ui/android/context_provider_factory.h

Comment 18 by amineer@chromium.org, Dec 9 2016

Labels: Archive-Blimp
►

Sign in to add a comment