New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611103 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Traveling - Back 2/6
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 597756
issue 599621



Sign in to add a comment

Build BlimpContents for Tab

Project Member Reported by dtrainor@chromium.org, May 11 2016

Issue description

- Add a BlimpContents object that gets created by Tab for Blimp tabs.
- Tie this into the BlimpClientSession and notify the engine of the tab and build the feature connections.
- Rework Tab to not 'die' if a WebContents is missing but a BlimpContents is present.


 
Labels: Blimp-M53-Proj-Scope
[Bulk edit]

Setting tracking label Blimp-M53-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-53 scope, or remove this bug from M-53 scope.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94759c2202550721d3e49d7f7869e2952954748e

commit 94759c2202550721d3e49d7f7869e2952954748e
Author: nyquist <nyquist@chromium.org>
Date: Fri Jun 17 18:07:14 2016

Add BlimpContents[,Observer] and BlimpNavigationController

This CL adds the public API for //blimp/client/core and adds a simple
implementation with a test for the core functionality.

The setup of BlimpContents and related classes is intentionally
similar to how the //content API is organized.

Users of this API are supposed to depend on the code in
//blimp/client/core/public, and not the implementation which lives
in //blimp/client/core directly.

BUG= 611103 

Review-Url: https://codereview.chromium.org/2040813004
Cr-Commit-Position: refs/heads/master@{#400456}

[modify] https://crrev.com/94759c2202550721d3e49d7f7869e2952954748e/blimp/BUILD.gn
[modify] https://crrev.com/94759c2202550721d3e49d7f7869e2952954748e/blimp/client/BUILD.gn
[add] https://crrev.com/94759c2202550721d3e49d7f7869e2952954748e/blimp/client/core/BUILD.gn
[add] https://crrev.com/94759c2202550721d3e49d7f7869e2952954748e/blimp/client/core/blimp_contents_impl.cc
[add] https://crrev.com/94759c2202550721d3e49d7f7869e2952954748e/blimp/client/core/blimp_contents_impl.h
[add] https://crrev.com/94759c2202550721d3e49d7f7869e2952954748e/blimp/client/core/blimp_contents_impl_unittest.cc
[add] https://crrev.com/94759c2202550721d3e49d7f7869e2952954748e/blimp/client/core/blimp_navigation_controller_delegate.h
[add] https://crrev.com/94759c2202550721d3e49d7f7869e2952954748e/blimp/client/core/blimp_navigation_controller_impl.cc
[add] https://crrev.com/94759c2202550721d3e49d7f7869e2952954748e/blimp/client/core/blimp_navigation_controller_impl.h
[add] https://crrev.com/94759c2202550721d3e49d7f7869e2952954748e/blimp/client/core/blimp_navigation_controller_impl_unittest.cc
[add] https://crrev.com/94759c2202550721d3e49d7f7869e2952954748e/blimp/client/core/public/BUILD.gn
[add] https://crrev.com/94759c2202550721d3e49d7f7869e2952954748e/blimp/client/core/public/blimp_contents.h
[add] https://crrev.com/94759c2202550721d3e49d7f7869e2952954748e/blimp/client/core/public/blimp_contents_observer.h
[add] https://crrev.com/94759c2202550721d3e49d7f7869e2952954748e/blimp/client/core/public/blimp_navigation_controller.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca

commit 986f860c8fc6361d727a9ccd3c8cd44727b6f5ca
Author: nyquist <nyquist@chromium.org>
Date: Wed Jun 22 02:23:10 2016

Add BlimpContents[,Observer] and BlimpNavigationController

This CL adds the public API for //blimp/client/core and adds a simple
implementation with a test for the core functionality for Java.

The setup of BlimpContents and related classes is intentionally
similar to how the Java version of the //content API is organized.

Users of this API are supposed to depend on the code in
//blimp/client/core/public, and not the implementation which lives
in //blimp/client/core directly.

An extra class compared to the C++ version is added for creating
BlimpContents, the BlimpContentsFactory. This sets up all the pointers
and references in the same ways as a BlimpContents created in native
code, but adds the requirement for Java code to invoke the destroy()
method of a BlimpContents.

BUG= 611103 

Review-Url: https://codereview.chromium.org/2059443002
Cr-Commit-Position: refs/heads/master@{#401170}

[modify] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/BUILD.gn
[modify] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/app/android/blimp_jni_registrar.cc
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/app/android/javatests/src/org/chromium/blimp/BlimpNativeInstrumentationTestCase.java
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/app/android/javatests/src/org/chromium/blimp/core/BlimpContentsTest.java
[modify] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/BUILD.gn
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/android/blimp_contents_factory.cc
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/android/blimp_contents_factory.h
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/android/blimp_contents_impl_android.cc
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/android/blimp_contents_impl_android.h
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/android/blimp_contents_observer_proxy.cc
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/android/blimp_contents_observer_proxy.h
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/android/blimp_navigation_controller_impl_android.cc
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/android/blimp_navigation_controller_impl_android.h
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpContentsFactory.java
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpContentsImpl.java
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpContentsObserverProxy.java
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpNavigationControllerImpl.java
[modify] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/blimp_contents_impl.cc
[modify] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/blimp_contents_impl.h
[modify] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/public/BUILD.gn
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/public/android/java/src/org/chromium/blimp/core_public/BlimpContents.java
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/public/android/java/src/org/chromium/blimp/core_public/BlimpContentsObserver.java
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/public/android/java/src/org/chromium/blimp/core_public/BlimpNavigationController.java
[add] https://crrev.com/986f860c8fc6361d727a9ccd3c8cd44727b6f5ca/blimp/client/core/public/android/java/src/org/chromium/blimp/core_public/EmptyBlimpContentsObserver.java

Project Member

Comment 4 by sheriffbot@chromium.org, Jul 10 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Blimp-M54-Proj-Scope
[Bulk edit]

Setting tracking label Blimp-M54-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-54 scope, or remove this bug from M-54 scope.
Status: Fixed (was: Assigned)
BlimpContents is created.  Marking as fixed.  Reopen if I'm incorrect thanks!
Labels: Archive-Blimp

Sign in to add a comment