New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 611100 link

Starred by 1 user
Status: Fixed
Owner:
shaktisahu@chromium.org
Closed: Aug 2016
Cc:
█ nyquist@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 597756
issue 599621



Sign in to add a comment

Build 0.6 Blimp Navigation Controller

Project Member Reported by dtrainor@chromium.org, May 11 2016 
- Create a basic NavigationController with the same functionality as the 0.5 version.
- This just needs to implement the correct methods to allow swapping of this one and the one that currently is created by the content layer.
- Does not need full state sync at this time.

Comment 1 by dtrainor@chromium.org, May 11 2016

Labels: OS-Android

Comment 2 by dtrainor@chromium.org, May 16 2016

Cc: -shaktisahu@chromium.org nyquist@chromium.org
Owner: shaktisahu@chromium.org
Some additional notes:
- Should be owned by the BlimpContents.
- Should have both a Java and native component, the Java component needs to share an interface with the existing NavigationController (could either use the same interface or make one that has a subset).
- Tie into the Clank front end anywhere you see NavigationController used in Java from a Tab.

Comment 3 by amineer@chromium.org, May 25 2016

Labels: Blimp-M53-Proj-Scope
[Bulk edit]

Setting tracking label Blimp-M53-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-53 scope, or remove this bug from M-53 scope.
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 10 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by amineer@chromium.org, Jul 26 2016

Labels: Blimp-M54-Proj-Scope
[Bulk edit]

Setting tracking label Blimp-M54-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-54 scope, or remove this bug from M-54 scope.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07de74f02ced93bc52625ee8f50f9d9a3f40a841

commit 07de74f02ced93bc52625ee8f50f9d9a3f40a841
Author: shaktisahu <shaktisahu@chromium.org>
Date: Thu Aug 04 01:07:08 2016

Tied up BlimpNavigationController to NavigationFeature

Added some necessary navigation methods to BlimpNavigationController
Java interface and hooked it up all the way to navigation_feature.cc.
Added C++ unit tests for the same.

BUG= 611100 

Review-Url: https://codereview.chromium.org/2058263002
Cr-Commit-Position: refs/heads/master@{#409689}

[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/BUILD.gn
[delete] https://crrev.com/86606e25496fd4a016cacb21331067eefd71d8b2/blimp/client/app/android/javatests/src/org/chromium/blimp/core/contents/BlimpContentsTest.java
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/app/android/toolbar.h
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/app/linux/blimp_client_session_linux.h
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/app/linux/blimp_main.cc
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/BUILD.gn
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/android/blimp_contents_observer_proxy.cc
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/android/blimp_contents_observer_proxy.h
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/android/blimp_navigation_controller_impl_android.h
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpContentsObserverProxy.java
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpNavigationControllerImpl.java
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/blimp_contents_impl.cc
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/blimp_contents_impl.h
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/blimp_contents_impl_unittest.cc
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/blimp_navigation_controller_delegate.h
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/blimp_navigation_controller_impl.cc
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/blimp_navigation_controller_impl.h
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc
[add] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/fake_navigation_feature.cc
[add] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/fake_navigation_feature.h
[rename] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/mock_navigation_feature_delegate.cc
[rename] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/mock_navigation_feature_delegate.h
[rename] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/navigation_feature.cc
[rename] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/navigation_feature.h
[rename] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/core/contents/navigation_feature_unittest.cc
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContentsObserver.java
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpNavigationController.java
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/public/android/java/src/org/chromium/blimp_public/contents/EmptyBlimpContentsObserver.java
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/public/contents/blimp_contents.h
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/public/contents/blimp_contents_observer.h
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/public/contents/blimp_navigation_controller.h
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/client/session/blimp_client_session.cc
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/engine/BUILD.gn
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/blimp/engine/browser_tests/engine_browsertest.cc
[modify] https://crrev.com/07de74f02ced93bc52625ee8f50f9d9a3f40a841/tools/android/eclipse/.classpath

Comment 7 by shaktisahu@chromium.org, Aug 17 2016

Status: Started (was: Assigned)

Comment 8 by dtrainor@chromium.org, Aug 23 2016

Status: Fixed (was: Started)
Looks like this is finished?  We have the NavigationController.

Comment 9 by dtrainor@chromium.org, Aug 23 2016 

Reopen if I'm mistaken please!
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4

commit 26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4
Author: shaktisahu <shaktisahu@chromium.org>
Date: Wed Aug 24 01:24:37 2016

Adding BlimpNavigationController to Tab

Added blimp navigation controller to tab so that tab can route the
navigation calls to the correct navigation controller depending on
blimp mode. A TabObserver was created to be notified about the blimp
navigation events. Also changed ToolbarModelImpl to reflect the
correct url in blimp mode.

Also moved the blimp client context delegate initialization to an
early life cycle method in ChromeActivity.

Added a method to get the Java object from native BlimpContents.

BUG= 611100 

Review-Url: https://codereview.chromium.org/2233023002
Cr-Commit-Position: refs/heads/master@{#413924}

[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/blimp/client/core/android/blimp_client_context_impl_android.cc
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/blimp/client/core/contents/android/blimp_navigation_controller_impl_android.h
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpNavigationControllerImpl.java
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/blimp/client/core/contents/blimp_contents_impl.cc
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/blimp/client/core/contents/blimp_contents_impl.h
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/blimp/client/core/contents/blimp_navigation_controller_impl.cc
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/blimp/client/core/contents/blimp_navigation_controller_impl.h
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpNavigationController.java
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/blimp/client/public/contents/blimp_contents.h
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[add] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/chrome/android/java/src/org/chromium/chrome/browser/tab/TabBlimpContentsObserver.java
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/chrome/android/java_sources.gni
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/chrome/browser/android/blimp/blimp_client_context_factory.cc
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/chrome/browser/android/blimp/blimp_client_context_factory.h
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/26a1d3f241bfaeaf32db9a3b10d3b10a0d9817b4/chrome/browser/android/tab_android.h

Comment 11 by amineer@chromium.org, Dec 9 2016

Labels: Archive-Blimp
►

Sign in to add a comment