[Bulk edit]

Setting tracking label Blimp-M53-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-53 scope, or remove this bug from M-53 scope.

Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f0f0534e9be73b50afde189218160cf45648884

commit 3f0f0534e9be73b50afde189218160cf45648884
Author: nyquist <nyquist@chromium.org>
Date: Mon Jul 18 21:23:48 2016

Move blimp switches to core

Currently the command line switches for blimp are in the app directory,
but the code that will be using it will need to live in
//blimp/client/core. This means that the switches should be made
available to that code.

It is not moved to the public directory because for now it should not
be necessary for embedders to use them, and we should aim for the
configurations there to be made available as real runtime APIs instead.

BUG= 611097 

Review-Url: https://codereview.chromium.org/2154363002
Cr-Commit-Position: refs/heads/master@{#406100}

[modify] https://crrev.com/3f0f0534e9be73b50afde189218160cf45648884/blimp/client/BUILD.gn
[modify] https://crrev.com/3f0f0534e9be73b50afde189218160cf45648884/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java
[modify] https://crrev.com/3f0f0534e9be73b50afde189218160cf45648884/blimp/client/core/BUILD.gn
[rename] https://crrev.com/3f0f0534e9be73b50afde189218160cf45648884/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientSwitches.java
[rename] https://crrev.com/3f0f0534e9be73b50afde189218160cf45648884/blimp/client/core/blimp_client_switches.cc
[rename] https://crrev.com/3f0f0534e9be73b50afde189218160cf45648884/blimp/client/core/blimp_client_switches.h
[modify] https://crrev.com/3f0f0534e9be73b50afde189218160cf45648884/blimp/client/session/assignment_source.cc
[modify] https://crrev.com/3f0f0534e9be73b50afde189218160cf45648884/blimp/client/session/assignment_source_unittest.cc
[modify] https://crrev.com/3f0f0534e9be73b50afde189218160cf45648884/blimp/client/session/blimp_client_session.cc
[modify] https://crrev.com/3f0f0534e9be73b50afde189218160cf45648884/blimp/engine/BUILD.gn
[modify] https://crrev.com/3f0f0534e9be73b50afde189218160cf45648884/blimp/engine/DEPS
[add] https://crrev.com/3f0f0534e9be73b50afde189218160cf45648884/blimp/engine/browser_tests/DEPS
[modify] https://crrev.com/3f0f0534e9be73b50afde189218160cf45648884/blimp/engine/browser_tests/blimp_browser_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/149198074adf37cbda2f834901059728d3ad6342

commit 149198074adf37cbda2f834901059728d3ad6342
Author: nyquist <nyquist@chromium.org>
Date: Tue Jul 19 22:29:18 2016

Move blimp AssignmentSource to core

The assignment source is an internal detail of Blimp and does not have
to have a public API. It is used by the BlimpClientSession, and in the
process of converting that to have a public API, moving the source
to the internal core folder is one step on the way towards that goal.

This temporarily splits up the session-target in blimp, as the
BlimpClientSession continues to stay in //blimp/client/session.

BUG= 611097 

Review-Url: https://codereview.chromium.org/2157133003
Cr-Commit-Position: refs/heads/master@{#406399}

[modify] https://crrev.com/149198074adf37cbda2f834901059728d3ad6342/blimp/BUILD.gn
[modify] https://crrev.com/149198074adf37cbda2f834901059728d3ad6342/blimp/client/BUILD.gn
[modify] https://crrev.com/149198074adf37cbda2f834901059728d3ad6342/blimp/client/app/android/blimp_client_session_android.cc
[modify] https://crrev.com/149198074adf37cbda2f834901059728d3ad6342/blimp/client/app/android/java/src/org/chromium/blimp/session/BlimpClientSession.java
[modify] https://crrev.com/149198074adf37cbda2f834901059728d3ad6342/blimp/client/app/linux/blimp_main.cc
[modify] https://crrev.com/149198074adf37cbda2f834901059728d3ad6342/blimp/client/core/BUILD.gn
[add] https://crrev.com/149198074adf37cbda2f834901059728d3ad6342/blimp/client/core/session/BUILD.gn
[rename] https://crrev.com/149198074adf37cbda2f834901059728d3ad6342/blimp/client/core/session/assignment_source.cc
[rename] https://crrev.com/149198074adf37cbda2f834901059728d3ad6342/blimp/client/core/session/assignment_source.h
[rename] https://crrev.com/149198074adf37cbda2f834901059728d3ad6342/blimp/client/core/session/assignment_source_unittest.cc
[rename] https://crrev.com/149198074adf37cbda2f834901059728d3ad6342/blimp/client/core/session/test_selfsigned_cert.pem
[modify] https://crrev.com/149198074adf37cbda2f834901059728d3ad6342/blimp/client/session/blimp_client_session.h
[modify] https://crrev.com/149198074adf37cbda2f834901059728d3ad6342/blimp/engine/BUILD.gn
[modify] https://crrev.com/149198074adf37cbda2f834901059728d3ad6342/blimp/engine/browser_tests/blimp_browser_test.cc
[modify] https://crrev.com/149198074adf37cbda2f834901059728d3ad6342/blimp/engine/browser_tests/engine_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50130784a7a599bc33427b5ffc19d1277b556a59

commit 50130784a7a599bc33427b5ffc19d1277b556a59
Author: nyquist <nyquist@chromium.org>
Date: Tue Jul 19 22:40:04 2016

Split //blimp/client/core to relevant parts.

Currently //blimp/client/core is a target that contains everything
that exists in that directory and subdirectories.

This CL changes the structure so that only the BlimpClientContextImpl
and the command line switches are left in the top-level core directory.

In addition to moving files to their own directories, the change
also adds BUILD.gn files to their respective directories, both for
C++ and Java.

BUG= 611097 

Review-Url: https://codereview.chromium.org/2166563003
Cr-Commit-Position: refs/heads/master@{#406402}

[modify] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/BUILD.gn
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/app/android/javatests/src/org/chromium/blimp/core/contents/BlimpContentsTest.java
[modify] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/BUILD.gn
[modify] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/android/blimp_client_context_impl_android.cc
[modify] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/android/blimp_jni_registrar.cc
[modify] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
[modify] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java
[modify] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/blimp_client_context_impl.cc
[modify] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/blimp_client_context_impl.h
[modify] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/blimp_client_context_impl_unittest.cc
[add] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/BUILD.gn
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/android/blimp_contents_factory.cc
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/android/blimp_contents_factory.h
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/android/blimp_contents_impl_android.cc
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/android/blimp_contents_impl_android.h
[add] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/android/blimp_contents_jni_registrar.cc
[add] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/android/blimp_contents_jni_registrar.h
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/android/blimp_contents_observer_proxy.cc
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/android/blimp_contents_observer_proxy.h
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/android/blimp_navigation_controller_impl_android.h
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpContentsFactory.java
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpContentsImpl.java
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpContentsObserverProxy.java
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpNavigationControllerImpl.java
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/blimp_contents_impl.cc
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/blimp_contents_impl.h
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/blimp_contents_impl_unittest.cc
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/blimp_navigation_controller_delegate.h
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/blimp_navigation_controller_impl.cc
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/blimp_navigation_controller_impl.h
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc
[modify] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/core/dummy_blimp_client_context.h
[modify] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/public/BUILD.gn
[modify] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContents.java
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContentsObserver.java
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpNavigationController.java
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/public/android/java/src/org/chromium/blimp_public/contents/EmptyBlimpContentsObserver.java
[modify] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/public/blimp_client_context.h
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/public/contents/blimp_contents.h
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/public/contents/blimp_contents_observer.h
[rename] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/blimp/client/public/contents/blimp_navigation_controller.h
[modify] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/chrome/browser/android/blimp/blimp_contents_profile_attachment.cc
[modify] https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59/chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e

commit 28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e
Author: nyquist <nyquist@chromium.org>
Date: Tue Jul 19 23:06:18 2016

Move ImageSerializationProcessor code to blimp/client/core

The ImageSerializationProcessor and related code is necessary to move
to //blimp/client/core/compositor, since the BlimpClientSession needs
it, and it will itself move to //blimp/client/core/session in an
upcoming CL.

BUG= 611097 

Review-Url: https://codereview.chromium.org/2160363002
Cr-Commit-Position: refs/heads/master@{#406407}

[modify] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/BUILD.gn
[modify] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/app/blimp_startup.cc
[modify] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/core/BUILD.gn
[add] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/core/compositor/BUILD.gn
[rename] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/core/compositor/blimp_client_picture_cache.cc
[rename] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/core/compositor/blimp_client_picture_cache.h
[rename] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/core/compositor/blimp_client_picture_cache_unittest.cc
[rename] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/core/compositor/blimp_image_decoder.cc
[rename] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/core/compositor/blimp_image_decoder.h
[rename] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/core/compositor/blob_image_serialization_processor.cc
[rename] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/core/compositor/blob_image_serialization_processor.h
[rename] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/core/compositor/decoding_image_generator.cc
[rename] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/core/compositor/decoding_image_generator.h
[modify] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/feature/compositor/blimp_compositor_manager.cc
[modify] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/feature/compositor/blimp_compositor_manager.h
[modify] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/feature/compositor/blimp_compositor_unittest.cc
[modify] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/client/session/blimp_client_session.h
[modify] https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e/blimp/test/BUILD.gn

[Bulk edit]

Setting tracking label Blimp-M54-Proj-Scope.  This label is for scope tracking purposes only and should not be added / removed from any bugs, even if we add additional bugs to M-54 scope, or remove this bug from M-54 scope.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14014dc154affce8602b0c81934b8a3718abd938

commit 14014dc154affce8602b0c81934b8a3718abd938
Author: nyquist <nyquist@chromium.org>
Date: Fri Jul 29 23:22:22 2016

Move more client network code to //blimp/client/core/session.

The BlimpClientSession will be going away, so this CL takes part of it
and splits it up into smaller parts and moves them to
//blimp/client/core/session. They will be used by the
BlimpClientContextImpl.

BUG= 611097 

Review-Url: https://codereview.chromium.org/2187893002
Cr-Commit-Position: refs/heads/master@{#408802}

[modify] https://crrev.com/14014dc154affce8602b0c81934b8a3718abd938/blimp/client/core/session/BUILD.gn
[add] https://crrev.com/14014dc154affce8602b0c81934b8a3718abd938/blimp/client/core/session/client_network_components.cc
[add] https://crrev.com/14014dc154affce8602b0c81934b8a3718abd938/blimp/client/core/session/client_network_components.h
[add] https://crrev.com/14014dc154affce8602b0c81934b8a3718abd938/blimp/client/core/session/cross_thread_network_event_observer.cc
[add] https://crrev.com/14014dc154affce8602b0c81934b8a3718abd938/blimp/client/core/session/cross_thread_network_event_observer.h
[add] https://crrev.com/14014dc154affce8602b0c81934b8a3718abd938/blimp/client/core/session/network_event_observer.h
[modify] https://crrev.com/14014dc154affce8602b0c81934b8a3718abd938/blimp/client/session/blimp_client_session.cc
[modify] https://crrev.com/14014dc154affce8602b0c81934b8a3718abd938/blimp/client/session/blimp_client_session.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4f943953bbfaa0f4f5c0c448a2caa19df678321

commit d4f943953bbfaa0f4f5c0c448a2caa19df678321
Author: nyquist <nyquist@chromium.org>
Date: Tue Aug 02 23:08:07 2016

Add network setup code to BlimpClientContextImpl

The BlimpClientSession is only used for the shell, and it sets up
network related code for that. This CL takes the network setup code and
moves it to BlimpClientContextImpl.

The CL also moves some exposed headers related to protocol buffers
to the public_deps of those targets. This is because of the
file blimp/net/browser_connection_handler.h which exposes the use
of BlimpMessage::FeatureCase, which can not be forward declared.

BUG= 611097 

Review-Url: https://codereview.chromium.org/2190753002
Cr-Commit-Position: refs/heads/master@{#409370}

[modify] https://crrev.com/d4f943953bbfaa0f4f5c0c448a2caa19df678321/blimp/client/core/BUILD.gn
[modify] https://crrev.com/d4f943953bbfaa0f4f5c0c448a2caa19df678321/blimp/client/core/blimp_client_context_impl.cc
[modify] https://crrev.com/d4f943953bbfaa0f4f5c0c448a2caa19df678321/blimp/client/core/blimp_client_context_impl.h
[modify] https://crrev.com/d4f943953bbfaa0f4f5c0c448a2caa19df678321/blimp/client/core/blimp_client_context_impl_unittest.cc
[modify] https://crrev.com/d4f943953bbfaa0f4f5c0c448a2caa19df678321/blimp/client/core/dummy_blimp_client_context.cc
[modify] https://crrev.com/d4f943953bbfaa0f4f5c0c448a2caa19df678321/blimp/client/public/blimp_client_context.h
[modify] https://crrev.com/d4f943953bbfaa0f4f5c0c448a2caa19df678321/blimp/client/test/BUILD.gn
[modify] https://crrev.com/d4f943953bbfaa0f4f5c0c448a2caa19df678321/blimp/client/test/test_blimp_client_context_delegate.cc
[modify] https://crrev.com/d4f943953bbfaa0f4f5c0c448a2caa19df678321/blimp/client/test/test_blimp_client_context_delegate.h
[modify] https://crrev.com/d4f943953bbfaa0f4f5c0c448a2caa19df678321/blimp/common/BUILD.gn
[modify] https://crrev.com/d4f943953bbfaa0f4f5c0c448a2caa19df678321/blimp/net/BUILD.gn
[modify] https://crrev.com/d4f943953bbfaa0f4f5c0c448a2caa19df678321/chrome/browser/android/blimp/blimp_client_context_factory.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acbaf0f9f124751d7f9144d9f2725f5667f55fcf

commit acbaf0f9f124751d7f9144d9f2725f5667f55fcf
Author: nyquist <nyquist@chromium.org>
Date: Wed Aug 03 07:24:58 2016

Make the BlimpClientContextImplAndroid become a BlimpClientContextImpl

Currently the BlimpClientContextImplAndroid has-a
BlimpClientContextImpl, which makes it hard for it to provide
functionality backing a BlimpClientContext.

This CL changes the Android-version of the class to be a subclass of
the cross platform implementation.

To not make the cross platform version of the BlimpClientContext
subclass implement GetJavaObject() itself, it is now a static method
of the BlimpClientContext, and linked in as a dummy or actual version
depending on whether blimp is supported or not.

BUG= 611097 

Review-Url: https://codereview.chromium.org/2193623002
Cr-Commit-Position: refs/heads/master@{#409474}

[modify] https://crrev.com/acbaf0f9f124751d7f9144d9f2725f5667f55fcf/blimp/client/core/android/blimp_client_context_impl_android.cc
[modify] https://crrev.com/acbaf0f9f124751d7f9144d9f2725f5667f55fcf/blimp/client/core/android/blimp_client_context_impl_android.h
[modify] https://crrev.com/acbaf0f9f124751d7f9144d9f2725f5667f55fcf/blimp/client/core/android/dummy_blimp_client_context_android.cc
[modify] https://crrev.com/acbaf0f9f124751d7f9144d9f2725f5667f55fcf/blimp/client/core/android/dummy_blimp_client_context_android.h
[modify] https://crrev.com/acbaf0f9f124751d7f9144d9f2725f5667f55fcf/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
[modify] https://crrev.com/acbaf0f9f124751d7f9144d9f2725f5667f55fcf/blimp/client/core/blimp_client_context_impl.cc
[modify] https://crrev.com/acbaf0f9f124751d7f9144d9f2725f5667f55fcf/blimp/client/core/blimp_client_context_impl.h
[modify] https://crrev.com/acbaf0f9f124751d7f9144d9f2725f5667f55fcf/blimp/client/core/dummy_blimp_client_context.cc
[modify] https://crrev.com/acbaf0f9f124751d7f9144d9f2725f5667f55fcf/blimp/client/core/dummy_blimp_client_context.h
[modify] https://crrev.com/acbaf0f9f124751d7f9144d9f2725f5667f55fcf/blimp/client/public/blimp_client_context.h
[modify] https://crrev.com/acbaf0f9f124751d7f9144d9f2725f5667f55fcf/chrome/browser/android/blimp/blimp_client_context_factory_android.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/448013905e45fc47bbc4d648ad64ec81efc1392a

commit 448013905e45fc47bbc4d648ad64ec81efc1392a
Author: xingliu <xingliu@chromium.org>
Date: Thu Aug 04 00:05:55 2016

Setup the delegate in Chrome for java calls.

Previously we have some separate impelmentation to call embedder
functionality, such as BlimpSettingsCallbacks.

This CL add a new way to call embedder's s java function in
ChromeBlimpClientContextDelegate class, and add a java interface
BlimpClientContextDelegate so in Blimp we can talk to this interface to
ask the embedder to do stuff in java.

The different from previous callback mechanism is that
ChromeBlimpClientContextDelegate is also backed by native class, and it
can associate itself with certain BlimpClientContext based on certain
Profile in c++.

Under current test infrastructure, it's very hard to test this delegate
mechanism, so pure java callbacks will still in use.

BUG= 611097 

Review-Url: https://codereview.chromium.org/2191743002
Cr-Commit-Position: refs/heads/master@{#409675}

[modify] https://crrev.com/448013905e45fc47bbc4d648ad64ec81efc1392a/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
[modify] https://crrev.com/448013905e45fc47bbc4d648ad64ec81efc1392a/blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java
[modify] https://crrev.com/448013905e45fc47bbc4d648ad64ec81efc1392a/blimp/client/public/BUILD.gn
[modify] https://crrev.com/448013905e45fc47bbc4d648ad64ec81efc1392a/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java
[add] https://crrev.com/448013905e45fc47bbc4d648ad64ec81efc1392a/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContextDelegate.java
[modify] https://crrev.com/448013905e45fc47bbc4d648ad64ec81efc1392a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/448013905e45fc47bbc4d648ad64ec81efc1392a/chrome/android/java/src/org/chromium/chrome/browser/blimp/ChromeBlimpClientContextDelegate.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae227aa6323de6cef1d9289208d1a7a94aa4d83f

commit ae227aa6323de6cef1d9289208d1a7a94aa4d83f
Author: nyquist <nyquist@chromium.org>
Date: Wed Aug 10 04:46:29 2016

Add AssignmentSource to BlimpClientContextImpl

This CL adds support for using the AssignmentSource for getting
assignments for the blimp engine.

Compared to the previous implementation in BlimpClientSession, this CL
constructs the AssignmentSource lazily, for two reasons:
- Right now, we can then easily use a Java-backed preference store for
  which assigner to use.
- Later, we can easily make the change of an assigner URL just reset
  the AssignmentSource, and another call to Connect() would then
  automatically create a new one.

BUG= 611097 

Review-Url: https://codereview.chromium.org/2211613002
Cr-Commit-Position: refs/heads/master@{#410957}

[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/BUILD.gn
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/app/android/blimp_client_session_android.cc
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/app/android/blimp_client_session_android.h
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/app/android/java/src/org/chromium/blimp/session/BlimpClientSession.java
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/core/BUILD.gn
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/core/android/blimp_client_context_impl_android.cc
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/core/android/blimp_client_context_impl_android.h
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/core/blimp_client_context_impl.cc
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/core/blimp_client_context_impl.h
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/core/blimp_client_context_impl_unittest.cc
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/core/dummy_blimp_client_context.cc
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/core/dummy_blimp_client_context.h
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/core/session/BUILD.gn
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/core/session/assignment_source.cc
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/core/session/assignment_source.h
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/core/session/assignment_source_unittest.cc
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/public/BUILD.gn
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/public/blimp_client_context.h
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/public/blimp_client_context_delegate.h
[add] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/public/session/assignment.cc
[add] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/public/session/assignment.h
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/session/blimp_client_session.cc
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/session/blimp_client_session.h
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/client/test/test_blimp_client_context_delegate.h
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/blimp/engine/browser_tests/engine_browsertest.cc
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/chrome/browser/android/blimp/blimp_client_context_factory.cc
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc
[modify] https://crrev.com/ae227aa6323de6cef1d9289208d1a7a94aa4d83f/chrome/browser/android/blimp/chrome_blimp_client_context_delegate.h

nyquist@ this is fixed right?  Is there anything else we need for this?

This should be fixed now. There's still some optional follow-up to make the UI even better by listening to sign-in / sign-out events, but it's not required for this.