New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611090 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 611089



Sign in to add a comment

Incorrectly applies selectors with multiple instances of :hover and :active in quirks mode

Reported by r...@opera.com, May 11 2016

Issue description

Universal selectors for :hover and :active should only apply to links in quirks mode. We incorrectly applies selectors like :hover:hover and :active:active to all elements.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a262d51788ada7f1f9158049d3576c9b1b09b1a

commit 8a262d51788ada7f1f9158049d3576c9b1b09b1a
Author: rune <rune@opera.com>
Date: Wed May 11 22:39:42 2016

Multiple :hover/:active incorrectly matching in quirks mode.

:hover and :active should only match links when not accompanied by
other simple selectors in quirks mode. We failed to adhere for
combinations of :hover and :active. Instead of just checking there is
either a selector preceding or following in the compound, check if
there is a selector preceding or a selector following in the compound
which is neither :hover nor :active.

R=rob.buis@samsung.com
BUG= 611090 

Review-Url: https://codereview.chromium.org/1972713002
Cr-Commit-Position: refs/heads/master@{#393090}

[add] https://crrev.com/8a262d51788ada7f1f9158049d3576c9b1b09b1a/third_party/WebKit/LayoutTests/fast/css/hover-active-quirks-expected.txt
[add] https://crrev.com/8a262d51788ada7f1f9158049d3576c9b1b09b1a/third_party/WebKit/LayoutTests/fast/css/hover-active-quirks.html
[modify] https://crrev.com/8a262d51788ada7f1f9158049d3576c9b1b09b1a/third_party/WebKit/Source/core/css/SelectorChecker.cpp

Comment 2 by r...@opera.com, May 11 2016

Status: Fixed (was: Started)

Sign in to add a comment