New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 611070 link

Starred by 1 user
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: May 2016
Cc:
█ alokp@chromium.org
xhw...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Move MojoMediaApplication off gpu main thread.

Project Member Reported by xhw...@chromium.org, May 11 2016 
Today MojoMediaApplication is running on the GPU main thread on Android. Since media operations (e.g. decoding) could be slow, this may impact the performance of other GPU operations.

Note that this is new in M52, in M51 we start a new thread for MojoMediaApplicaiton in the GPU process (when using StatisLoader).

Now in M52, when we register the app, we didn't specify app.second.application_task_runner [1]. So the app will be running on the calling thread, which is the GPU main thread.

We should support running an app on a new thread, and use it for MojoMediaApplication in the GPU process.

[1] https://code.google.com/p/chromium/codesearch#chromium/src/content/gpu/gpu_process_control_impl.cc&l=31

Comment 1 by xhw...@chromium.org, May 11 2016

Labels: OS-Android
rockot: Tentatively assign to you since from last chat I remember you planned to fix this. Thanks!
Project Member

Comment 2 by bugdroid1@chromium.org, May 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/017f0ef2cd86419f22f52377c161b0296f173f5b

commit 017f0ef2cd86419f22f52377c161b0296f173f5b
Author: rockot <rockot@chromium.org>
Date: Mon May 16 17:15:52 2016

Move in-GPU mojo:media app to new thread

This app was moved to the main thread of the GPU
process when I killed shell::Loader.
See https://codereview.chromium.org/1889253002.

We want this running on its own background thread
because it does slow things.

This CL adds the option for embedded mojo apps to
be run on their own thread and uses the option
for mojo:media in the GPU process.

BUG= 611070 
TEST=watched cat videos on youtube.com with android build, which exercises in-GPU mojo:media

Review-Url: https://codereview.chromium.org/1978843003
Cr-Commit-Position: refs/heads/master@{#393852}

[modify] https://crrev.com/017f0ef2cd86419f22f52377c161b0296f173f5b/content/browser/browser_context.cc
[modify] https://crrev.com/017f0ef2cd86419f22f52377c161b0296f173f5b/content/browser/mojo/browser_shell_connection.cc
[modify] https://crrev.com/017f0ef2cd86419f22f52377c161b0296f173f5b/content/browser/mojo/browser_shell_connection.h
[modify] https://crrev.com/017f0ef2cd86419f22f52377c161b0296f173f5b/content/browser/mojo/mojo_shell_context.cc
[modify] https://crrev.com/017f0ef2cd86419f22f52377c161b0296f173f5b/content/child/process_control_impl.cc
[modify] https://crrev.com/017f0ef2cd86419f22f52377c161b0296f173f5b/content/common/mojo/embedded_application_runner.cc
[modify] https://crrev.com/017f0ef2cd86419f22f52377c161b0296f173f5b/content/common/mojo/embedded_application_runner.h
[modify] https://crrev.com/017f0ef2cd86419f22f52377c161b0296f173f5b/content/gpu/gpu_process_control_impl.cc
[modify] https://crrev.com/017f0ef2cd86419f22f52377c161b0296f173f5b/content/public/common/mojo_application_info.cc
[modify] https://crrev.com/017f0ef2cd86419f22f52377c161b0296f173f5b/content/public/common/mojo_application_info.h

Comment 3 by roc...@chromium.org, May 16 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment