blink_perf.css failing on all platforms. |
|||||
Issue descriptionhttps://build.chromium.org/p/chromium.perf/builders/Mac%2010.11%20Perf%20%285%29/builds/1726/steps/blink_perf.css/logs/stdio https://build.chromium.org/p/chromium.perf/builders/Android%20Galaxy%20S5%20Perf%20(1) Traceback (most recent call last): File "/b/build/slave/Mac_10_11_Perf__5_/build/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 84, in _RunStoryAndProcessErrorIfNeeded state.RunStory(results) File "/b/build/slave/Mac_10_11_Perf__5_/build/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 332, in RunStory self._current_page, self._current_tab, results) File "/b/build/slave/Mac_10_11_Perf__5_/build/src/tools/perf/benchmarks/blink_perf.py", line 99, in ValidateAndMeasurePage tab.WaitForJavaScriptExpression('testRunner.isDone', 600) File "/b/build/slave/Mac_10_11_Perf__5_/build/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 123, in WaitForJavaScriptExpression util.WaitFor(IsJavaScriptExpressionTrue, timeout) File "/b/build/slave/Mac_10_11_Perf__5_/build/src/third_party/catapult/telemetry/telemetry/core/util.py", line 86, in WaitFor res = condition() File "/b/build/slave/Mac_10_11_Perf__5_/build/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 116, in IsJavaScriptExpressionTrue return bool(self.EvaluateJavaScript(expr)) File "/b/build/slave/Mac_10_11_Perf__5_/build/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 187, in EvaluateJavaScript expr, context_id=None, timeout=timeout) File "/b/build/slave/Mac_10_11_Perf__5_/build/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 215, in EvaluateJavaScriptInContext expr, context_id=context_id, timeout=timeout) File "/b/build/slave/Mac_10_11_Perf__5_/build/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 32, in inner return func(inspector_backend, *args, **kwargs) File "/b/build/slave/Mac_10_11_Perf__5_/build/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 203, in EvaluateJavaScript return self._runtime.Evaluate(expr, context_id, timeout) File "/b/build/slave/Mac_10_11_Perf__5_/build/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py", line 45, in Evaluate res = self._inspector_websocket.SyncRequest(request, timeout) File "/b/build/slave/Mac_10_11_Perf__5_/build/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 110, in SyncRequest res = self._Receive(timeout) File "/b/build/slave/Mac_10_11_Perf__5_/build/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 166, in _Receive self._HandleNotification(result) File "/b/build/slave/Mac_10_11_Perf__5_/build/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 179, in _HandleNotification self._domain_handlers[domain_name](result) File "/b/build/slave/Mac_10_11_Perf__5_/build/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 288, in _HandleInspectorDomainNotification raise exception DevtoolsTargetCrashException: Devtools target crashed
,
May 11 2016
,
May 11 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Improve handling of PaintInvalidationLayer Author : wangxianzhu Commit description: Rename PaintInvalidationLayer to PaintInvalidationSubtree. In LayoutObject::setShouldDoFullPaintInvalidationIncludingNonCompositingDescendants(), instead of traverse the tree to setShouldDoFullPaintInvalidation(), set PaintInvalidationSubtree on the root of the subtree. During paint invalidation, if a LayoutObject is marked PaintInvalidationSubtree, force full paint invalidation of the subtree (within the paintInvalidationContainer). BUG= 410097 Review-Url: https://codereview.chromium.org/1950573003 Cr-Commit-Position: refs/heads/master@{#392861} Commit : 2848739b13b1f454930307439ba00ddd55bb9b40 Date : Wed May 11 05:34:55 2016 ===== TESTED REVISIONS ===== Revision Exit Code Std Dev N Good? chromium@392859 0 N/A 1 good chromium@392860 0 N/A 1 good chromium@392861 1 N/A 1 bad <-- chromium@392863 1 N/A 1 bad chromium@392866 1 N/A 1 bad Bisect job ran on: linux_perf_bisect Bug ID: 611060 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.css Test Metric: AttributeDescendantSelector/AttributeDescendantSelector Relative Change: Zero to non-zero Score: 0.0 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6490 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9012945224845263776 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5853646202339328 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
May 11 2016
wangxianzhu@chromium.org, Bisect found crrev.com/392863 as culprit for the blink_perf.css failures, could you please take a look at this?
,
May 11 2016
,
May 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a05db510a333ebcd1724213d4f7a4cbea2e73a7 commit 3a05db510a333ebcd1724213d4f7a4cbea2e73a7 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed May 11 19:16:35 2016 Fix blink_perf.css.CSSPropertySetterGetter failure LayoutBoxModelObject::styleWillChange() assumed hasLayer() when it sees StyleDifference::needsPaintInvalidationSubtree(). https://codereview.chromium.org/1950573003/ broke the assumption. Now check hasLayer(). Added a test based on blink_perf.css.CSSPropertySetterGetter. BUG= 611060 TEST=fast/css/css-property-setter-getter.html R=trchen@chromium.org Review URL: https://codereview.chromium.org/1965893007 . Cr-Commit-Position: refs/heads/master@{#393018} [add] https://crrev.com/3a05db510a333ebcd1724213d4f7a4cbea2e73a7/third_party/WebKit/LayoutTests/fast/css/css-property-setter-getter-expected.txt [add] https://crrev.com/3a05db510a333ebcd1724213d4f7a4cbea2e73a7/third_party/WebKit/LayoutTests/fast/css/css-property-setter-getter.html [modify] https://crrev.com/3a05db510a333ebcd1724213d4f7a4cbea2e73a7/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
,
May 11 2016
,
May 11 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Improve handling of PaintInvalidationLayer Author : wangxianzhu Commit description: Rename PaintInvalidationLayer to PaintInvalidationSubtree. In LayoutObject::setShouldDoFullPaintInvalidationIncludingNonCompositingDescendants(), instead of traverse the tree to setShouldDoFullPaintInvalidation(), set PaintInvalidationSubtree on the root of the subtree. During paint invalidation, if a LayoutObject is marked PaintInvalidationSubtree, force full paint invalidation of the subtree (within the paintInvalidationContainer). BUG= 410097 Review-Url: https://codereview.chromium.org/1950573003 Cr-Commit-Position: refs/heads/master@{#392861} Commit : 2848739b13b1f454930307439ba00ddd55bb9b40 Date : Wed May 11 05:34:55 2016 ===== TESTED REVISIONS ===== Revision Exit Code Std Dev N Good? chromium@392859 0 N/A 20 good chromium@392860 0 N/A 20 good chromium@392861 1 N/A 20 bad <-- chromium@392863 1 N/A 20 bad chromium@392866 1 N/A 20 bad Bisect job ran on: linux_perf_bisect Bug ID: 611060 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.css Test Metric: AttributeDescendantSelector/AttributeDescendantSelector Relative Change: Zero to non-zero Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6489 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9012946134537879648 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5893709657276416 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
May 11 2016
Issue 611175 has been merged into this issue.
,
May 12 2016
Issue 611293 has been merged into this issue.
,
May 12 2016
Issue 611354 has been merged into this issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pras...@chromium.org
, May 11 2016