New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611059 link

Starred by 2 users

Issue metadata

Status: WontFix
Merged: issue 600630
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Hidden extension icons periodically reappear in toolbar

Project Member Reported by derat@chromium.org, May 11 2016

Issue description

Google Chrome	50.0.2661.94 (Official Build) (64-bit)
Revision	0c319c380220abe3daf0277e40a2d0b22a7c4550-refs/branch-heads/2661@{#645}
OS	Linux 
Blink	537.36 (@0c319c380220abe3daf0277e40a2d0b22a7c4550)
JavaScript	V8 5.0.71.39
Flash	21.0.0.216

All of my previously-hidden extensions reappeared in my toolbar when I started Chrome this morning (probably after the upgrade to M50). This happened on two different profiles. It's happened before too.

It also seems to happen whenever I log into a new Chromebook. Are we not syncing the hidden state? (Should I file a separate bug for this?)
 
snap-092324.png
14.7 KB View Download

Comment 1 by pav...@chromium.org, May 11 2016

No, we are not syncing visibility preference for extensions. Logging into new profile will show all extensions.

Comment 2 by derat@chromium.org, May 11 2016

Is that by design, or can I file a feature request to change that?

Comment 3 by pav...@chromium.org, May 11 2016

Labels: Sync-Triaged
Owner: rdevlin....@chromium.org
rdevlin@: Could you triage this bug? Do we need to sync visibility preference?
Mergedinto: 600630
Status: Duplicate (was: Untriaged)
This is probably a dup of  issue 600630 , which is about syncing the toolbar width.  The reason we don't sync it is because there are plenty of times we wouldn't *want* to: a really easy example is when you have different size screens (users might not want 10 extensions visible on a chromebook, but do on a 30" screen).  Corp extensions or other device-specific extensions also complicate it.

I'm tentatively duping this against that issue, but feel free to re-open if there's anything else.

Comment 5 by derat@chromium.org, May 11 2016

Cc: rdevlin....@chromium.org
Components: -Services>Sync
Labels: -Sync-Triaged
Owner: ----
Status: Untriaged (was: Duplicate)
I don't think it's an unsynced toolbar width that's causing this (although I've noticed that before, too). These are extensions that I've hidden (via "Hide in Chrome menu" in their context menus), not ones that have been pushed over into the overflow menu.

I'm dropping the sync component of this, as I agree that syncing the hidden state would have other unwanted effects: for example, I hide some corp network-related extensions on my workstation but what them to be shown on a Chromebook that's usually used off the corp network. There's no way for us to infer whether the user wants the state to be synced or not in that state (barring a "Hide permanently" or "Hide everywhere" setting), and it would be frustrating if it were always synced.

So I think the real issue here is what I noticed this morning (and have seen once or twice before): extensions that I'd previously hidden _on this machine_ reappeared. Did the location where the "hidden" attribute is stored get moved somewhere else in M50, without any migration code being added?
Labels: -OS-Linux -OS-Chrome OS-All
> These are extensions that I've hidden (via "Hide in Chrome menu" in their context menus), not ones that have been pushed over into the overflow menu.

These do the same thing.

> So I think the real issue here is what I noticed this morning (and have seen once or twice before): extensions that I'd previously hidden _on this machine_ reappeared.

This would be bad.  Can you get this to repro at all?

Comment 8 by derat@chromium.org, May 11 2016

> These do the same thing.

So they do! Thanks, I wasn't aware of this. That makes it easier to hide them if they come back again. :-P

> This would be bad.  Can you get this to repro at all?

No, the width is preserved when exiting and restarting now (probably the pref, if that's what it is, got rewritten when I re-hid the extensions). If I can find a Chromebook that's still on M49, I might be able to get it to happen again. Is there anything I can capture that'd help track down the cause?
I'm really not sure... I can think of possibilities for why this would happen M49 - M50 (sync mismatches with the extension action redesign, etc), but nothing we can really address (because we wouldn't want to do a stable merge for a one-off thing like this, especially since M50 has been stable for quite awhile).  If you see it again, though, then it means it's not a one-off M49 -> M50 edge case, and should have more attention.

Comment 10 by derat@chromium.org, May 11 2016

Status: WontFix (was: Untriaged)
Thanks, I'll reopen this if it pops up again outside of 49->50.

Comment 11 by derat@chromium.org, May 13 2016

Status: Untriaged (was: WontFix)
I think that I'm continuing to see this multiple times on the same devices. I noticed it just now on:


Google Chrome	50.0.2661.91 (Official Build) (64-bit)
Platform	7978.66.0 (Official Build) stable-channel peppy

after booting and logging in to my corp account.

I _had_ made changes to the icon ordering and toolbar width on other devices since the last time I logged in to this Chromebook. Does the toolbar get reset to full width after ordering changes are synced?
Cc: -rdevlin....@chromium.org
Owner: rdevlin....@chromium.org
Status: Assigned (was: Untriaged)
No, the width should remain constant.  I'll take a look.

Comment 13 by derat@chromium.org, May 13 2016

Components: Services>Sync

Comment 14 by zea@chromium.org, Jan 17 2018

Labels: Sync-Triaged SyncHandoff2018

Comment 15 by derat@chromium.org, Jan 17 2018

Status: WontFix (was: Assigned)
I haven't seen any occurrences of an existing profile losing the width in a long time.

Sign in to add a comment