New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 611056 link

Starred by 1 user
Status: Fixed
Owner:
█ xunji...@chromium.org
Last visit > 30 days ago
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 516342



Sign in to add a comment

Avoid unnecessary array creation in cronet_bidirectional_stream_adapter.cc

Project Member Reported by xunji...@chromium.org, May 11 2016 
During CL review of https://codereview.chromium.org/1960243002/, Misha suggested that we should avoid unnecessary array creation in cronet_bidirectional_stream_adapter.cc, and directly store the java arguments passed in through WritevData. I think it is a good idea. Filing a bug to do the follow-up.
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2328a268fb12d5b99c377be5548b055c0cec9c28

commit 2328a268fb12d5b99c377be5548b055c0cec9c28
Author: xunjieli <xunjieli@chromium.org>
Date: Mon May 16 19:38:25 2016

Remove unnecessary array allocation in cronet_bidirectional_stream_adapter.cc

Save arguments passed in through WritevData directly instead
of a list of IOBufferWithByteBuffer.

This saves unnecessary array allocations to reconstruct Java
arguments for invoking onWriteCompleted.

BUG= 611056 

Review-Url: https://codereview.chromium.org/1969893002
Cr-Commit-Position: refs/heads/master@{#393901}

[modify] https://crrev.com/2328a268fb12d5b99c377be5548b055c0cec9c28/components/cronet/android/cronet_bidirectional_stream_adapter.cc
[modify] https://crrev.com/2328a268fb12d5b99c377be5548b055c0cec9c28/components/cronet/android/cronet_bidirectional_stream_adapter.h
[modify] https://crrev.com/2328a268fb12d5b99c377be5548b055c0cec9c28/net/http/bidirectional_stream.cc
[modify] https://crrev.com/2328a268fb12d5b99c377be5548b055c0cec9c28/net/http/bidirectional_stream.h
[modify] https://crrev.com/2328a268fb12d5b99c377be5548b055c0cec9c28/net/http/bidirectional_stream_impl.h
[modify] https://crrev.com/2328a268fb12d5b99c377be5548b055c0cec9c28/net/http/bidirectional_stream_unittest.cc
[modify] https://crrev.com/2328a268fb12d5b99c377be5548b055c0cec9c28/net/quic/bidirectional_stream_quic_impl.cc
[modify] https://crrev.com/2328a268fb12d5b99c377be5548b055c0cec9c28/net/quic/bidirectional_stream_quic_impl.h
[modify] https://crrev.com/2328a268fb12d5b99c377be5548b055c0cec9c28/net/quic/bidirectional_stream_quic_impl_unittest.cc
[modify] https://crrev.com/2328a268fb12d5b99c377be5548b055c0cec9c28/net/quic/quic_chromium_client_stream.cc
[modify] https://crrev.com/2328a268fb12d5b99c377be5548b055c0cec9c28/net/quic/quic_chromium_client_stream.h
[modify] https://crrev.com/2328a268fb12d5b99c377be5548b055c0cec9c28/net/quic/quic_chromium_client_stream_test.cc
[modify] https://crrev.com/2328a268fb12d5b99c377be5548b055c0cec9c28/net/spdy/bidirectional_stream_spdy_impl.cc
[modify] https://crrev.com/2328a268fb12d5b99c377be5548b055c0cec9c28/net/spdy/bidirectional_stream_spdy_impl.h

Comment 2 by xunji...@chromium.org, May 16 2016

Status: Fixed (was: Started)

Comment 3 by xunji...@chromium.org, Aug 17 2017

Blocking: 516342
►

Sign in to add a comment