New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611054 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Setup bot building with rtc_use_h264=0

Project Member Reported by kjellander@chromium.org, May 11 2016

Issue description

Now that we set rtc_use_h264=1 by default at the bots in https://build.chromium.org/p/client.webrtc/waterfall we should have a bot that also builds with it set to 0, so we don't regress at least on compilation for this build configuration.

hbos: do you think covering compilation on Linux is sufficient?
 

Comment 1 by hbos@chromium.org, May 12 2016

Cc: pbos@chromium.org
Yes, that should suffice.
Cc: ehmaldonado@chromium.org
ehmaldonado: let's look at doing this next week after GN migration.
https://codereview.webrtc.org/2228733004 was needed due to a recent breakage for this config (we should cover the default on the bots).
Status: Started (was: Assigned)
In progress finally: https://codereview.chromium.org/2460493002/
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/b061208b3f8e9f45d4c436ad19d383dfb0ee5d98

commit b061208b3f8e9f45d4c436ad19d383dfb0ee5d98
Author: kjellander <kjellander@chromium.org>
Date: Thu Oct 27 10:02:35 2016

WebRTC: Add new Linux (more configs) bots.

This new bot runs GN with a minimal amount of configurations set,
then compiles. This will give us coverage for the cases where
dcheck_always_on=false and rtc_use_h264=false.

It also re-runs GN+compile with:
* rtc_enable_intelligibility_enhancer=true
* rtc_enable_protobuf=false
* rtc_include_opus=false

If we want to test more configurations like this, we can just add
them to this bot in the future.

BUG= 652197 , 611054 

Review-Url: https://codereview.chromium.org/2460493002

[modify] https://crrev.com/b061208b3f8e9f45d4c436ad19d383dfb0ee5d98/masters/master.client.webrtc/master_linux_cfg.py
[modify] https://crrev.com/b061208b3f8e9f45d4c436ad19d383dfb0ee5d98/masters/master.client.webrtc/slaves.cfg
[modify] https://crrev.com/b061208b3f8e9f45d4c436ad19d383dfb0ee5d98/masters/master.tryserver.webrtc/master.cfg
[modify] https://crrev.com/b061208b3f8e9f45d4c436ad19d383dfb0ee5d98/masters/master.tryserver.webrtc/slaves.cfg
[modify] https://crrev.com/b061208b3f8e9f45d4c436ad19d383dfb0ee5d98/scripts/slave/recipe_modules/webrtc/chromium_config.py
[add] https://crrev.com/b061208b3f8e9f45d4c436ad19d383dfb0ee5d98/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Linux__more_configs_.json
[add] https://crrev.com/b061208b3f8e9f45d4c436ad19d383dfb0ee5d98/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_linux_more_configs.json
[add] https://crrev.com/b061208b3f8e9f45d4c436ad19d383dfb0ee5d98/scripts/slave/recipes/webrtc/more_configs.py

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/8ffc672e2003b9e5aa2f9839075ba55fd202a4be

commit 8ffc672e2003b9e5aa2f9839075ba55fd202a4be
Author: kjellander <kjellander@chromium.org>
Date: Tue Nov 01 08:40:29 2016

WebRTC: Configure more_configs recipe for new Android builders.

Fix missing recipe configs in https://codereview.chromium.org/2457423002.
Ensure they use the classic annotator_factory instead of remote_run,
to make it easier to add unit tests without having to deal with all the
boilerplate code needed for remote_run in order to get the right paths.

BUG= 652197 , 611054 

Review-Url: https://codereview.chromium.org/2466543002

[modify] https://crrev.com/8ffc672e2003b9e5aa2f9839075ba55fd202a4be/masters/master.client.webrtc/master_android_cfg.py
[modify] https://crrev.com/8ffc672e2003b9e5aa2f9839075ba55fd202a4be/masters/master.tryserver.webrtc/master.cfg

[bulk-edit : please ignore if not applicable]

Could you please set the correct milestone for this issue?

Comment 9 by hbos@chromium.org, Nov 16 2016

Labels: M-56

Sign in to add a comment