New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 611046 link

Starred by 13 users
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: May 2016
Cc:
a...@chromium.org
█ kbr@chromium.org
ajha@chromium.org
█ msten...@opera.com
abodenha@chromium.org
█ kavvaru@chromium.org
wangxianzhu@chromium.org
vmi...@chromium.org
gogerald@chromium.org
nyerramilli@chromium.org
ericrk@chromium.org
█ brian.te...@gmail.com
alex...@chromium.org
█ ashej...@chromium.org
█ durga.behera@chromium.org
chrishtr@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression

Blocked on:
issue 436198
Blocking:
issue 611462



Sign in to add a comment

Animometer repaint artifacts

Project Member Reported by fmalita@chromium.org, May 11 2016 
Version: ToT
OS: Linux/64

What steps will reproduce the problem?

(1) open https://pr.gg/animometer/developer.html
(2) resize the browser window vertically such that the "Run benchmark" button is positioned at the bottom
(3) click one of the left-menu bullets to expand a suite (e.g. "Basic canvas path suite")
(4) scroll down to reveal the "Run benchmark" button and observe repaint artifacts

This is a recent regression.  Bisect results:

You are probably looking for a change made after 392647 (known good), but no later than 392661 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/a69b588abf1afd1e37e58463a07df4da722ded02..de1993ee636b9c8a2ca0f1a817ff3d3ca5c88a6d

Pretty sure this is http://crrev.com/1929413002 (Don't include contents visual overflow into paint invalidation rect).

wangxianzhu@ PTAL
artifacts.png
91.5 KB View Download

Comment 1 by wangxianzhu@chromium.org, May 11 2016

Labels: -Type-Bug ReleaseBlock-Dev M-52 Type-Bug-Regression

Comment 2 by wangxianzhu@chromium.org, May 11 2016

Cc: wangxianzhu@chromium.org
 Issue 611212  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, May 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c053f70ee05c2dd91bf8b9da324e2a631e356bdc

commit c053f70ee05c2dd91bf8b9da324e2a631e356bdc
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Wed May 11 23:11:54 2016

Fix paint invalidation rect of LayoutView

The bug was caused by http://crrev.com/1929413002 which uses
selfVisualOverflowRect() instead of visualOverflowRect() to calculate
paint invalidation rect. It caused wrong paint invalidation rect
for LayoutView.

Before rootLayerScrolls is launched, LayoutView's overflow model is
special. We should calculate its paint invalidation rect based on its
special visualOverflowRect() for now.

BUG= 611046 

Review-Url: https://codereview.chromium.org/1971843002
Cr-Commit-Position: refs/heads/master@{#393099}

[modify] https://crrev.com/c053f70ee05c2dd91bf8b9da324e2a631e356bdc/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c053f70ee05c2dd91bf8b9da324e2a631e356bdc/third_party/WebKit/LayoutTests/fast/repaint/background-image-paint-invalidation-expected.txt
[modify] https://crrev.com/c053f70ee05c2dd91bf8b9da324e2a631e356bdc/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/c053f70ee05c2dd91bf8b9da324e2a631e356bdc/third_party/WebKit/Source/core/layout/LayoutView.h

Comment 4 by wangxianzhu@chromium.org, May 11 2016

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcca0faaf544ca2c414629e11614daed74b2a50f

commit bcca0faaf544ca2c414629e11614daed74b2a50f
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu May 12 00:27:22 2016

Auto-rebaseline for r393099

https://chromium.googlesource.com/chromium/src/+/c053f70ee

BUG= 611046 
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/1975613002 .

Cr-Commit-Position: refs/heads/master@{#393118}

[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/fast/repaint/border-radius-repaint-2-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/fast/repaint/fixed-and-absolute-position-scrolled-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/fast/repaint/full-viewport-repaint-for-background-attachment-fixed-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/fast/repaint/overflow-scroll-body-appear-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/fast/repaint/requestAnimation-translation-leave-traces-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/fast/repaint/shift-relative-positioned-container-with-image-addition-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/fast/repaint/shift-relative-positioned-container-with-image-removal-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change1-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change2-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/abspos-shift-image-incorrect-repaint-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/overflow-scroll-body-appear-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/shift-relative-positioned-container-with-image-addition-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/shift-relative-positioned-container-with-image-removal-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/table-shrink-row-repaint-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/abspos-shift-image-incorrect-repaint-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/table-shrink-row-repaint-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/platform/win/fast/repaint/abspos-shift-image-incorrect-repaint-expected.txt
[modify] https://crrev.com/bcca0faaf544ca2c414629e11614daed74b2a50f/third_party/WebKit/LayoutTests/platform/win/fast/repaint/table-shrink-row-repaint-expected.txt

Comment 6 by chrishtr@chromium.org, May 12 2016

Cc: brian.te...@gmail.com
 Issue 611252  has been merged into this issue.

Comment 7 by wangxianzhu@chromium.org, May 12 2016

Cc: gogerald@chromium.org ashej...@chromium.org alex...@chromium.org nyerramilli@chromium.org
 Issue 611289  has been merged into this issue.

Comment 8 by alex...@chromium.org, May 12 2016

Cc: durga.behera@chromium.org ajha@chromium.org msten...@opera.com kavvaru@chromium.org
 Issue 611291  has been merged into this issue.

Comment 9 by wangxianzhu@chromium.org, May 12 2016

Cc: kbr@chromium.org vmi...@chromium.org ericrk@chromium.org
 Issue 611272  has been merged into this issue.

Comment 10 by kbr@chromium.org, May 12 2016

Blockedon: 436198

Comment 11 by kbr@chromium.org, May 12 2016

Blocking: 611462

Comment 12 by chrishtr@chromium.org, May 12 2016

Cc: a...@chromium.org
 Issue 611383  has been merged into this issue.

Comment 13 by chrishtr@chromium.org, May 14 2016

Cc: abodenha@chromium.org
 Issue 611630  has been merged into this issue.
►

Sign in to add a comment