Issue metadata
Sign in to add a comment
|
4.3% regression in page_cycler.intl_es_fr_pt-BR at 392416:392449 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 11 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Make Mac swap code like other platforms Author : ccameron Commit description: Swap buffer completion is sent from the GPU process to the browser process via the IPC GpuCommandBufferMsg_SwapBuffersCompleted on all platforms except for Mac, which uses the IPC GpuHostMsg_AcceleratedSurfaceBuffersSwapped. Mac needs (for now) to send a handful of additional parameters from the gpu process at every swap. These parameters are used to display in the browser process the CALayer tree that is created in the gpu process. Add these parameters to GpuHostMsg_AcceleratedSurfaceBuffersSwapped under a platform ifdef. These parameters will be able to be removed when layer tree construction is moved to be in the browser process. Pass these parameters along to GpuBrowserCompositorOutputSurface:: SwapBuffers, where they are consumed in Mac-specific code. This wart, the gpu::GpuProcessHostedCALayerTreeParamsMac structure being passed along, will be removed when the CALayer tree is constructed in the browser process. Swaps are acknowledged by the browser process to the gpu process in the AcceleratedSurfaceMsg_BufferPresented IPC. The purpose of this IPC was to send vsync data to the gpu process to coordinate swaps, but this data is no longer used by the gpu process, is entirely dead code, and can be removed. Remove other supporting code that is no longer needed. Not all supporting code is removed in this patch. BUG=604052 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/1962493002 Cr-Commit-Position: refs/heads/master@{#392419} Commit : 433204258d41867ad95c2af17c1248dfc64032ac Date : Mon May 09 20:59:44 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@392415 626.768 8.18018 5 good chromium@392418 632.855 4.49526 5 good chromium@392419 653.744 4.49622 5 bad <-- chromium@392420 649.489 3.59356 5 bad chromium@392424 655.408 3.91789 5 bad chromium@392432 654.5 6.8313 5 bad chromium@392449 654.685 3.83038 5 bad Bisect job ran on: mac_retina_perf_bisect Bug ID: 611042 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests page_cycler.intl_es_fr_pt-BR Test Metric: cold_times/page_load_time Relative Change: 4.45% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1293 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9012953109046947776 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5787649332215808 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
May 11 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Make Mac swap code like other platforms Author : ccameron Commit description: Swap buffer completion is sent from the GPU process to the browser process via the IPC GpuCommandBufferMsg_SwapBuffersCompleted on all platforms except for Mac, which uses the IPC GpuHostMsg_AcceleratedSurfaceBuffersSwapped. Mac needs (for now) to send a handful of additional parameters from the gpu process at every swap. These parameters are used to display in the browser process the CALayer tree that is created in the gpu process. Add these parameters to GpuHostMsg_AcceleratedSurfaceBuffersSwapped under a platform ifdef. These parameters will be able to be removed when layer tree construction is moved to be in the browser process. Pass these parameters along to GpuBrowserCompositorOutputSurface:: SwapBuffers, where they are consumed in Mac-specific code. This wart, the gpu::GpuProcessHostedCALayerTreeParamsMac structure being passed along, will be removed when the CALayer tree is constructed in the browser process. Swaps are acknowledged by the browser process to the gpu process in the AcceleratedSurfaceMsg_BufferPresented IPC. The purpose of this IPC was to send vsync data to the gpu process to coordinate swaps, but this data is no longer used by the gpu process, is entirely dead code, and can be removed. Remove other supporting code that is no longer needed. Not all supporting code is removed in this patch. BUG=604052 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/1962493002 Cr-Commit-Position: refs/heads/master@{#392419} Commit : 433204258d41867ad95c2af17c1248dfc64032ac Date : Mon May 09 20:59:44 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@392415 673.638 13.3179 5 good chromium@392418 670.434 17.7651 5 good chromium@392419 772.195 5.01858 5 bad <-- chromium@392420 765.668 3.70977 5 bad chromium@392424 776.376 3.72089 5 bad chromium@392432 770.268 6.53087 5 bad chromium@392449 768.481 8.29328 5 bad Bisect job ran on: mac_retina_perf_bisect Bug ID: 611042 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests page_cycler.intl_es_fr_pt-BR Test Metric: cold_times/http___www.eltiempo.es_talavera-de-la-reina.html Relative Change: 14.08% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1294 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9012953080832769824 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5796076594921472 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by tdres...@chromium.org
, May 11 2016