New issue
Advanced search Search tips

Issue 611039 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 611151
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.3% regression in smoothness.key_silk_cases at 392649:392676

Project Member Reported by tdres...@chromium.org, May 11 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=611039

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgtL26qAkM


Bot(s) for this bug's original alert(s):

android-galaxy-s5
Cc: tdres...@chromium.org
Owner: wangxianzhu@chromium.org
Suspecting
https://chromium.googlesource.com/chromium/src/+/5cc129fdb28122d6ef55a9d201ecbbe4fb4bc449

Is this expected?
It's weird that only galaxy-s5 was affected but not any of other android phones: https://chromeperf.appspot.com/report?sid=e65da0ee8dcd9d35089ca8fb0e02238437ff0b655cd7a26dbe421ae236752174

I suspect some other change in the range affected galaxy-s5. Scheduled bisect.
Cc: wangxianzhu@chromium.org
 Issue 611151  has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, May 12 2016

Mergedinto: 611151
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Don't include contents visual overflow into paint invalidation rect
Author  : wangxianzhu
Commit description:
  
Now we always invalidate any object needing repaint, so we never need
the paint invalidation rect of an ancestor to cover descendants.

BUG= 436198 

Review-Url: https://codereview.chromium.org/1929413002
Cr-Commit-Position: refs/heads/master@{#392652}
Commit  : 638c1a24dc8fdcceb5b5f4acd9d03d3a09b9cfa3
Date    : Tue May 10 18:23:15 2016


===== TESTED REVISIONS =====
Revision         Mean  Std Dev   N  Good?
chromium@392648  46.0  0.0       5  good
chromium@392650  46.2  0.447214  5  good
chromium@392651  46.0  0.0       5  good
chromium@392652  44.8  0.447214  5  bad    <--
chromium@392655  44.8  0.447214  5  bad
chromium@392662  44.4  0.547723  5  bad
chromium@392676  44.4  0.547723  5  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 611039

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.key_silk_cases
Test Metric: avg_surface_fps/avg_surface_fps
Relative Change: 3.48%
Score: 99.8

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/660
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9012931021475707008


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5315931329265664

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, May 12 2016


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Don't include contents visual overflow into paint invalidation rect
Author  : wangxianzhu
Commit description:
  
Now we always invalidate any object needing repaint, so we never need
the paint invalidation rect of an ancestor to cover descendants.

BUG= 436198 

Review-Url: https://codereview.chromium.org/1929413002
Cr-Commit-Position: refs/heads/master@{#392652}
Commit  : 638c1a24dc8fdcceb5b5f4acd9d03d3a09b9cfa3
Date    : Tue May 10 18:23:15 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev    N  Good?
chromium@392648  20.1041  0.0588301  5  good
chromium@392650  20.1123  0.0308456  5  good
chromium@392651  20.08    0.0542314  4  good
chromium@392652  20.6219  0.0553247  5  bad    <--
chromium@392655  20.6819  0.0229228  5  bad
chromium@392662  20.6597  0.0265175  5  bad
chromium@392676  20.6789  0.0334853  5  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 611039

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.key_silk_cases
Test Metric: frame_times/frame_times
Relative Change: 2.86%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/661
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9012929131720940144


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5895639573987328

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment