New issue
Advanced search Search tips

Issue 611006 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task

Blocking:
issue 610709



Sign in to add a comment

UI metrics for the Account Chooser dialog

Project Member Reported by melandory@chromium.org, May 11 2016

Issue description

Account chooser: How many clicks on an account and on “Cancel”?
 
Labels: Merge-Request-51

Comment 3 by tin...@google.com, May 25 2016

Labels: -Merge-Request-51 Merge-Review-51 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M51, manual review required.
Labels: -Hotlist-Merge-review -Merge-Review-51
Project Member

Comment 5 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a762f9cfbd26b7ee744c81350f81310c3f0d94c3

commit a762f9cfbd26b7ee744c81350f81310c3f0d94c3
Author: melandory <melandory@chromium.org>
Date: Wed May 25 16:35:29 2016

Revert of [Smart Lock] Adds UMA Metrics for actions on Account Chooser. (patchset #4 id:60001 of https://codereview.chromium.org/1973293002/ )

Reason for revert:
Obsolete change. This CL https://codereview.chromium.org/2009773003/
does right thing.

Original issue's description:
> [Smart Lock] Adds UMA Metrics for actions on Account Chooser.
>
> Account chooser: How many clicks on an account and on “Cancel”?
>
> BUG= 611006 
>
> Committed: https://crrev.com/b3da8cc062b762d4fb9b9208405a7237dc601e89
> Cr-Commit-Position: refs/heads/master@{#395844}

TBR=vasilii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 611006 

Review-Url: https://codereview.chromium.org/2009273002
Cr-Commit-Position: refs/heads/master@{#395909}

[modify] https://crrev.com/a762f9cfbd26b7ee744c81350f81310c3f0d94c3/chrome/browser/password_manager/account_chooser_dialog_android.cc
[modify] https://crrev.com/a762f9cfbd26b7ee744c81350f81310c3f0d94c3/components/password_manager/core/browser/password_manager_metrics_util.cc
[modify] https://crrev.com/a762f9cfbd26b7ee744c81350f81310c3f0d94c3/components/password_manager/core/browser/password_manager_metrics_util.h

Project Member

Comment 6 by bugdroid1@chromium.org, May 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a08dfb353a0d877f974a9bbf0eb489dbe0a18bb

commit 2a08dfb353a0d877f974a9bbf0eb489dbe0a18bb
Author: melandory <melandory@chromium.org>
Date: Mon May 30 08:51:48 2016

[Smart Lock] Adds UMA Metrics for actions on Account Chooser.

One account, many accounts case.

BUG= 611006 

Review-Url: https://codereview.chromium.org/2009773003
Cr-Commit-Position: refs/heads/master@{#396696}

[modify] https://crrev.com/2a08dfb353a0d877f974a9bbf0eb489dbe0a18bb/chrome/browser/password_manager/account_chooser_dialog_android.cc

Labels: Merge-Request-52

Comment 8 by tin...@google.com, May 30 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 9 by bugdroid1@chromium.org, May 31 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17d0044d03e39f78028b40a1ca52a5cc48ce21e0

commit 17d0044d03e39f78028b40a1ca52a5cc48ce21e0
Author: Tatiana Gornak <melandory@chromium.org>
Date: Tue May 31 08:54:19 2016

[Smart Lock] Adds UMA Metrics for actions on Account Chooser.

One account, many accounts case.

BUG= 611006 

Review-Url: https://codereview.chromium.org/2009773003
Cr-Commit-Position: refs/heads/master@{#396696}
(cherry picked from commit 2a08dfb353a0d877f974a9bbf0eb489dbe0a18bb)

Review URL: https://codereview.chromium.org/2024093002 .

Cr-Commit-Position: refs/branch-heads/2743@{#135}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/17d0044d03e39f78028b40a1ca52a5cc48ce21e0/chrome/browser/password_manager/account_chooser_dialog_android.cc

Comment 10 by vabr@chromium.org, May 2 2017

Components: UI>Browser>Passwords

Comment 11 by vabr@chromium.org, May 2 2017

Labels: -tracking_work Type-Task
Status: Fixed (was: Started)

Sign in to add a comment