exclude_unwind_tables should not depend on is_chrome_branded |
|||||||||||||||
Issue descriptionFrom BUILD.gn # Omit unwind support in official builds to save space. # We can use breakpad for these builds. exclude_unwind_tables = is_chrome_branded && is_official_build Feels weird to me that the presence of unwind tables depends on the branding. IMHO official build should reflect what we ship. We typically assume that the binary produces with official=true is representative of size and performance of the real one. This one makes it diverge, a non-chrome-branded binary is going to be << official one on android, where unwind tables contribute a lot. In other words I think that we should just exclude_unwind_tables = is_official_build
,
May 11 2016
https://codereview.chromium.org/1967103002 to turn that into action.
,
Jul 18 2016
,
Aug 30 2016
,
Feb 13 2017
Note: this makes our apk size graphs show libchrome.so as bigger than it actually is (due to unwind information not being excluded)
,
Feb 13 2017
,
Feb 13 2017
,
Feb 14 2017
Not sure I understand #5, the problem today is all about NON-official builds? How can this make any difference for the real binary? Are you suggesting that we are tracking a non-official binary in the size graphs? That sounds wrong regardless, as there are other build optimizations tied to is_official_build.
,
Feb 14 2017
I agree is_chrome_branded should not be relevant.
,
Feb 27 2017
I was wrong in #5. Turns out perf bots already build with is_chrome_branded=true, so this isn't hurting measurements at all. Is there any reason not to fix this now then?
,
Feb 27 2017
Re #10: I am super swamped. Would be great if somebody could take over my CL. thanks! >Is there any reason not to fix this now then? Don't think so.
,
Feb 27 2017
,
Feb 28 2017
Actually, assigning to mikecase@, since I think there are actually still some bots that require the microdump step (see blocking bug).
,
May 9 2017
,
May 10 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
,
Jan 21
(2 days ago)
,
Jan 21
(2 days ago)
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by yfried...@chromium.org
, May 11 2016