New issue
Advanced search Search tips

Issue 610989 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in content::PermissionServiceImpl::CancelPendingOperations

Project Member Reported by ClusterFuzz, May 11 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6405346175746048

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x60e000080880
Crash State:
  content::PermissionServiceImpl::CancelPendingOperations
  content::PermissionServiceImpl::OnConnectionError
  mojo::internal::Router::OnConnectionError
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_content_shell_drt&range=391931:391971

Minimized Testcase (22.16 Kb): https://cluster-fuzz.appspot.com/download/AMIfv951JSTdCj10hQXTE9PAgocWOBhOc5_fXxQrFOCvX4taISLP6sXObf0rRZOHIDyuaiYgQfLKMfyLfNeJU2QuI_Z0sNrmdKrlKnu9LaabbKlaIthQmEjtIt39R4YN0TD8U3EimFYsqM_ylWUEDN3bCu1rKD9AKzTctZwvAQt_6Mc85ajtBEI

Filer: mmoroz

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by mmoroz@chromium.org, May 11 2016

Components: Internals>Core
Labels: Pri-1
Owner: sa...@chromium.org

Comment 2 by mmoroz@chromium.org, May 11 2016

sammc@, could you please take a look?

Your CL is suspected as a culprit:

Author: sammc
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/f458adf68e9e3a394a3903ca8d52a3b508d87a61
Time: Fri May 06 00:30:27 2016
Lines 110 of file permission_service_impl.cc which potentially caused crash are changed in this cl (frame #1, "content::PermissionServiceImpl::OnConnectionError").
Minimum distance from crash line to modified line: 0. (file: permission_service_impl.cc, crashed on: 110, modified: 110).

Project Member

Comment 3 by ClusterFuzz, May 11 2016

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6675651645407232

Fuzzer: inferno_twister
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  content::PermissionServiceImpl::CancelPendingOperations
  content::PermissionServiceImpl::OnConnectionError
  mojo::internal::Connector::HandleError
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_content_shell_drt&range=391941:391970

Minimized Testcase (22.19 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95qeNecWN799GmXJhviNapLQhA3WCgA38MdKC2_BQo5sMJlGds-LcKAbVPwFCWhykYk4CQjbDB8y6ABb_B_kBol3ADz-UmohetSFvFiv0xd1cWhwYDx-gv_ELnASDZuqFfH8C3fD03ogGGzFAXfMljXtxOg2KKBvQGrfd6ik7O_5Dp-evc

Filer: mmoroz

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

Comment 4 by mmoroz@chromium.org, May 11 2016

The second crash looks similar to the first one.
Project Member

Comment 5 by ClusterFuzz, May 11 2016

Status: Assigned (was: Available)
Project Member

Comment 6 by sheriffbot@chromium.org, May 11 2016

Labels: M-52
Project Member

Comment 7 by sheriffbot@chromium.org, May 11 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8514447d66180f24e25713aea4445f80a9f4d6e

commit d8514447d66180f24e25713aea4445f80a9f4d6e
Author: sammc <sammc@chromium.org>
Date: Thu May 12 07:54:05 2016

Run queued tasks before shutting down after running a layout test.

Currently, when a layout test run finishes, the BlinkTestController
falls out of scope, which triggers shutdown of the RenderProcessHostImpl
used by the test. However, RenderProcessHostImpl posts a task to delete
itself, which is currently never run; this results in a
RenderProcessHostImpl outliving the UI MessageLoop and its
BrowserContext, inviting use-after-frees. This CL fixes this issue by
running queued tasks before shutting down the main runner.

BUG= 610989 

Review-Url: https://codereview.chromium.org/1975593003
Cr-Commit-Position: refs/heads/master@{#393204}

[modify] https://crrev.com/d8514447d66180f24e25713aea4445f80a9f4d6e/content/shell/browser/layout_test/layout_test_browser_main.cc

Project Member

Comment 9 by ClusterFuzz, May 12 2016

ClusterFuzz has detected this issue as fixed in range 393199:393222.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6405346175746048

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x60e000080880
Crash State:
  content::PermissionServiceImpl::CancelPendingOperations
  content::PermissionServiceImpl::OnConnectionError
  mojo::internal::Router::OnConnectionError
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_content_shell_drt&range=391931:391971
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_content_shell_drt&range=393199:393222

Minimized Testcase (22.16 Kb): https://cluster-fuzz.appspot.com/download/AMIfv951JSTdCj10hQXTE9PAgocWOBhOc5_fXxQrFOCvX4taISLP6sXObf0rRZOHIDyuaiYgQfLKMfyLfNeJU2QuI_Z0sNrmdKrlKnu9LaabbKlaIthQmEjtIt39R4YN0TD8U3EimFYsqM_ylWUEDN3bCu1rKD9AKzTctZwvAQt_6Mc85ajtBEI

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Comment 10 by sa...@chromium.org, May 13 2016

Status: Fixed (was: Assigned)
Project Member

Comment 11 by ClusterFuzz, May 13 2016

ClusterFuzz has detected this issue as fixed in range 393199:393215.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6675651645407232

Fuzzer: inferno_twister
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  content::PermissionServiceImpl::CancelPendingOperations
  content::PermissionServiceImpl::OnConnectionError
  mojo::internal::Connector::HandleError
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_content_shell_drt&range=391941:391970
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_content_shell_drt&range=393199:393215

Minimized Testcase (22.19 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95qeNecWN799GmXJhviNapLQhA3WCgA38MdKC2_BQo5sMJlGds-LcKAbVPwFCWhykYk4CQjbDB8y6ABb_B_kBol3ADz-UmohetSFvFiv0xd1cWhwYDx-gv_ELnASDZuqFfH8C3fD03ogGGzFAXfMljXtxOg2KKBvQGrfd6ik7O_5Dp-evc

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by sheriffbot@chromium.org, May 13 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 13 by ClusterFuzz, May 13 2016

Labels: Merge-NA
Project Member

Comment 14 by sheriffbot@chromium.org, Aug 19 2016

Labels: -Restrict-View-SecurityNotify
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 15 by sheriffbot@chromium.org, Oct 1 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by sheriffbot@chromium.org, Oct 2 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: allpublic

Sign in to add a comment