Issue metadata
Sign in to add a comment
|
Heap-use-after-free in v8::Isolate::VisitHandlesWithClassIds |
||||||||||||||||||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=4623653819383808 Fuzzer: therealholden_worker Job Type: windows_asan_content_shell Platform Id: windows Crash Type: Heap-use-after-free READ 4 Crash Address: 0x1c80b204 Crash State: v8::Isolate::VisitHandlesWithClassIds blink::V8GCController::traceDOMWrappers blink::ThreadState::visitPersistents Recommended Security Severity: High Regressed: https://cluster-fuzz.appspot.com/revisions?job=windows_asan_content_shell&range=390670:390734 Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv97Aw1lfci1FFnutmP8We0DwPKeAH6CUywwsPVqDzaBMBYAncywkN3ZgLilwvDGCuBIguRNDEOdHH42SxItWm52-vyxTPbBfRI3rFVKBdK6T_FaNYvtPtH6wCh3Xigr00_DggzTRq4SBgu1xytZ2ILDNMyArtQ Additional requirements: Requires HTTP Filer: mmoroz See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
May 11 2016
worker thread executing stuff after blink's main thread was shut down. kinuko because worker assigning to haraken as he recently changed handling of shutdown
,
May 11 2016
This is a bug of Oilpan. 1) The main thread calls blink::shutdown(). 2) The main thread destroys the V8 isolate. 3) Worker threads are still running and can trigger Oilpan's GC (<== this causes the crash). 4) The main thread calls modulesInitializer().shutdown() and joins all workers. A right fix would be to move 4) to between 1) and 2).
,
May 11 2016
Overlap with issue 459380 and/or issue 610340 ?
,
May 11 2016
I don't think so, since both issue 459380 and issue 610340 are happening during V8 GC, not Oilpan's GC.
,
May 11 2016
,
May 11 2016
,
May 11 2016
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c35abf17d76b2e4fe491a703b68b17c48725eeb commit 3c35abf17d76b2e4fe491a703b68b17c48725eeb Author: haraken <haraken@chromium.org> Date: Wed May 11 14:06:54 2016 All worker threads should be joined before main thread's V8 isolate is destroyed Currently the following scenario can happen: 1) The main thread calls blink::shutdown(). 2) The main thread calls V8Initializer::shutdown(), which destroys the V8 isolate. 3) Worker threads are still running and can trigger Oilpan's GC (<== this accesses the isolate and causes crash). 4) The main thread calls modulesInitializer().shutdown() and joins all workers. To address the issue, this CL moves 4) to between 1) and 2). BUG= 610987 Review-Url: https://codereview.chromium.org/1969673004 Cr-Commit-Position: refs/heads/master@{#392913} [modify] https://crrev.com/3c35abf17d76b2e4fe491a703b68b17c48725eeb/third_party/WebKit/Source/web/WebKit.cpp
,
May 11 2016
,
May 12 2016
,
May 12 2016
,
May 13 2016
,
Jun 9 2016
ClusterFuzz has detected this testcase as flaky and is unable to reproduce it in the original crash revision. Skipping fixed testing check and marking it as potentially fixed. Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4623653819383808 Fuzzer: therealholden_worker Job Type: windows_asan_content_shell Platform Id: windows Crash Type: Heap-use-after-free READ 4 Crash Address: 0x1c80b204 Crash State: v8::Isolate::VisitHandlesWithClassIds blink::V8GCController::traceDOMWrappers blink::ThreadState::visitPersistents Recommended Security Severity: High Regressed: https://cluster-fuzz.appspot.com/revisions?job=windows_asan_content_shell&range=390670:390734 Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv97Aw1lfci1FFnutmP8We0DwPKeAH6CUywwsPVqDzaBMBYAncywkN3ZgLilwvDGCuBIguRNDEOdHH42SxItWm52-vyxTPbBfRI3rFVKBdK6T_FaNYvtPtH6wCh3Xigr00_DggzTRq4SBgu1xytZ2ILDNMyArtQ Additional requirements: Requires HTTP See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Jul 20 2016
Congratulations - $3,500 for this bug!
,
Aug 4 2016
,
Aug 4 2016
,
Aug 18 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 1 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by mmoroz@chromium.org
, May 11 2016Labels: Pri-1
Owner: jochen@chromium.org