New issue
Advanced search Search tips

Issue 610985 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in blink::LayoutTextFragment::setTextFragment

Project Member Reported by ClusterFuzz, May 11 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6197335041769472

Fuzzer: marty_html_twiddler
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Heap-use-after-free WRITE 4
Crash Address: 0x60f000091028
Crash State:
  blink::LayoutTextFragment::setTextFragment
  blink::FirstLetterPseudoElement::detach
  blink::PseudoElement::dispose
  
Recommended Security Severity: High


Minimized Testcase (1.71 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97DEtTKLZEe6kU45u20BMSgIJe2cjp2Hlag8kn9I-VwI_V5vWwtGYVJ5qTwPdZNWufHKk_UJEBf0BKWpnYcHenAKqnc8fdcd13I_wF8DyoYW_Oq2kZEStOXR-47_-zYkHS3fUgPVguFaFLW3CqAEKEBVGSocA

Filer: mmoroz

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by mmoroz@chromium.org, May 11 2016

Cc: dsinclair@chromium.org esprehn@chromium.org
Components: Blink>DOM
Labels: M-51
Owner: e...@chromium.org
eae@, could you please help to find an owner for that?

Comment 2 by mmoroz@chromium.org, May 11 2016

Cc: mmoroz@chromium.org
Project Member

Comment 3 by ClusterFuzz, May 11 2016

Status: Assigned (was: Available)
Project Member

Comment 4 by sheriffbot@chromium.org, May 11 2016

Labels: Pri-1
Project Member

Comment 5 by sheriffbot@chromium.org, May 25 2016

eae: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by mmoroz@chromium.org, May 27 2016

I've tried to do some investigation. Since there is UaF while accessing:
|m_start| member of |LayoutTextFragment|, it looks like |~LayoutTextFragment()| had been previously executed. But the object wasn't fully deallocated. Otherwise shouldn't we detect UaF earlier when accessing some members of a parent class |LayoutText|?

Is it possible or am I totally wrong?

Also I cannot reproduce the issue locally... I could suppose a race condition, but everything happens in one thread (looking into the log).
Project Member

Comment 7 by ClusterFuzz, Jun 1 2016

ClusterFuzz has detected this issue as fixed in range 391535:391649.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6197335041769472

Fuzzer: marty_html_twiddler
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Heap-use-after-free WRITE 4
Crash Address: 0x60f00008f4f8
Crash State:
  blink::LayoutTextFragment::setTextFragment
  blink::FirstLetterPseudoElement::detach
  blink::PseudoElement::dispose
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_content_shell_drt&range=384460:384473
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_content_shell_drt&range=391535:391649

Minimized Testcase (2.67 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95Zr4y6jFm6segoLIFxxq3RKx8Et6djwJmcobB_Ecbv7PULVKMZ8sJP2TCRyW3Z2YxUprYFmCQkIp87-k5i9XSsmkUj-DzEUbW1K0_0dWm6kK_G2iqkbXsc8L5VZD5EI1WpVqjR30BJwBIfdQjLIA9RLWABeg

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Status: Fixed (was: Assigned)
As per #7, marking this Fixed. Probably it is an unrelated fix.


Labels: -M-51 Release-NA merge-na
Project Member

Comment 10 by ClusterFuzz, Jun 1 2016

ClusterFuzz has detected this issue as fixed in range 395074:395128.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6197335041769472

Fuzzer: marty_html_twiddler
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Heap-use-after-free WRITE 4
Crash Address: 0x60f00008f4f8
Crash State:
  blink::LayoutTextFragment::setTextFragment
  blink::FirstLetterPseudoElement::detach
  blink::PseudoElement::dispose
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_content_shell_drt&range=384460:384473
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_content_shell_drt&range=395074:395128

Minimized Testcase (2.67 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95Zr4y6jFm6segoLIFxxq3RKx8Et6djwJmcobB_Ecbv7PULVKMZ8sJP2TCRyW3Z2YxUprYFmCQkIp87-k5i9XSsmkUj-DzEUbW1K0_0dWm6kK_G2iqkbXsc8L5VZD5EI1WpVqjR30BJwBIfdQjLIA9RLWABeg

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by sheriffbot@chromium.org, Jun 1 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 8 2016

Labels: -Restrict-View-SecurityNotify
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Oct 1 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by sheriffbot@chromium.org, Oct 2 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: allpublic

Sign in to add a comment