New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610982 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Pinned tabs no more glowing on site changes

Reported by parkkiva...@gmail.com, May 11 2016

Issue description

Chrome Version       : 50.0.2661.94
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5:
  Firefox 4.x:
     IE 7/8/9:

What steps will reproduce the problem?
1. Open a page which has a support for topic change in event of page change. For example Facebook or Twitter.
2. Pin tab.
3. Wait for event.

What is the expected result?
Glowing tab.

What happens instead of that?
Tab does not glow.

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.94 Safari/537.36



 

Comment 1 by sadrul@chromium.org, May 11 2016

Components: UI>Browser>TabStrip

Comment 2 by sadrul@chromium.org, May 11 2016

Cc: tdander...@chromium.org pkasting@chromium.org sky@chromium.org sadrul@chromium.org est...@chromium.org
Labels: Needs-Bisect
Scott, do you know if there's something we can do deterministically to force this UI change to (try to) occur?

It would be good to get a bisect for any regression here.

Comment 4 by sadrul@chromium.org, May 11 2016

I see this working correctly on Linux (version 50.0.2661.94 (64-bit)).

To test, pin any tab, then cause something to change the title while the tab is foreground (I ran this in the console "window.setTimeout(function() { document.title = 'zzz'; }, 1000);" and switched tab before it ran. It did cause the tab to glow until the tab was focused.
Labels: Needs-Feedback
Reporter, can you try the steps in comment 4 and see if you see a glow?

If not, are you using a custom theme?
Tested it multiple times, on multiple tabs. The tab does not glow.
Also tested with multiple sites with changing title, does not glow.

Using default theme.
Cc: -pkasting@chromium.org
Labels: -Type-Bug -Pri-3 -Needs-Feedback M-53 Pri-2 Type-Bug-Regression
Owner: pkasting@chromium.org
Status: Untriaged (was: Unconfirmed)
I also don't see the glow animation on Windows Dev.

Odd that this would differ between Linux and Windows.  They basically use the same tabstrip code.

If anyone broke this, it's likely me.
Labels: -Needs-Bisect hasbisect
Status: Assigned (was: Untriaged)
Able to reproduce the issue on windows 7 using chrome version stable 50.0.2661.102 and canary 52.0.2734.0 with the below steps

1. Pin the tab
2.Executed the command "window.setTimeout(function() { document.title = 'zzz'; }, 1000);" in console
3.Switch to another tab 
4.Observed the there is no glow in pinned tab when theme is windows default theme.Able to see the glow when using dark theme.

This is regression issue broken in M50.Please find the bisect information as below
Good :50.0.2658.0  --   (official build 377177)
Bad:: 50.0.2659.0  --   (official build 377466)

CHANGELOG URL:  https://chromium.googlesource.com/chromium/src/+log/b515424de0aa3d62c4d64f4a73cf0bff137539c8..1f84a577db6da22b4e0e401f357a6299d4fa67a1

Possible suspect::
https://codereview.chromium.org/1711233002

Note:: This issue is working fine on Linux Ubuntu 14.04 and Mac 10.11.4.

Thnaks,

Comment 9 by sky@chromium.org, Jul 8 2016

Status: WontFix (was: Assigned)
473898 changed the effect from a glow to a static image, so this isn't relevant anymore.
Do we actually get the image?

Comment 11 by sky@chromium.org, Jul 8 2016

I certainly see it on tip of tree with my pinned gmail tab.
Can you check the steps in comment 8?  Hopefully this is fixed but I want to be careful.

Comment 13 by sky@chromium.org, Jul 8 2016

Yes, 8 works. The problem with the js in #8 is that you have to switch tabs before 1 second, otherwise we won't show the badge (the badge is only shown if the title changes *and* the tab is not active). It's easier to see the behavior with something like:

window.setInterval(function() { document.title = document.title + 'z'; }, 1000);

This way the title continuously changes every second.

Comment 14 by sky@chromium.org, Jul 8 2016

And for the record I am trying this on windows too.

Comment 15 by vik...@gmail.com, Sep 8 2016

Any further progress on fixing this issue?

Comment 16 by sky@chromium.org, Sep 8 2016

vike91@gmail.com, this bug was closed as wontfix as the glow animation has been nuked in favor of a badge. See 473898 for details.

Sign in to add a comment