This will help identifying causes for echo or crackling audio. Both input and output should be added. To be able to do this, a path to forward the data (be it a string+number or just a log string) from //media to //content must be added.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b2114872f08a1fcfe2a6fb284b645a8152da85c commit 2b2114872f08a1fcfe2a6fb284b645a8152da85c Author: grunell <grunell@chromium.org> Date: Mon May 30 13:50:48 2016 Forward output glitch information from stream WebRTC log * A callback is added as input parameter on AudioManager create stream functions. * OnLogMessage() function is added to the AudioLog interface. * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback when creating an output stream. * AudioInputController gives AudioInputController::LogMessage() (new function) as callback when creating an input stream. In this function, the message is passed to AudioInputRendererHost::OnLog(). * In both input and output cases, the message is then passed to the WebRTC log. * The Mac input and output streams inform about OS glitches via the callback. BUG= 610967 Review-Url: https://codereview.chromium.org/1864483002 Cr-Commit-Position: refs/heads/master@{#396722} [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/chromecast/media/audio/cast_audio_manager.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/chromecast/media/audio/cast_audio_manager.h [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/chromecast/media/audio/cast_audio_output_stream_unittest.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/components/audio_modem/audio_recorder_impl.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/content/browser/media/media_internals.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/content/browser/renderer_host/media/video_capture_manager.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/alsa/alsa_output_unittest.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/alsa/audio_manager_alsa.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/alsa/audio_manager_alsa.h [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/android/audio_android_unittest.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/android/audio_manager_android.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/android/audio_manager_android.h [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/audio_input_controller.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/audio_input_controller.h [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/audio_input_unittest.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/audio_logging.h [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/audio_low_latency_input_output_unittest.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/audio_manager.h [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/audio_manager_base.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/audio_manager_base.h [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/audio_output_dispatcher_impl.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/audio_output_proxy_unittest.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/cras/audio_manager_cras.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/cras/audio_manager_cras.h [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/fake_audio_log_factory.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/fake_audio_manager.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/fake_audio_manager.h [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/mac/audio_auhal_mac.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/mac/audio_auhal_mac.h [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/mac/audio_auhal_mac_unittest.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/mac/audio_low_latency_input_mac.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/mac/audio_low_latency_input_mac.h [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/mac/audio_low_latency_input_mac_unittest.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/mac/audio_manager_mac.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/mac/audio_manager_mac.h [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/mock_audio_manager.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/mock_audio_manager.h [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/pulse/audio_manager_pulse.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/pulse/audio_manager_pulse.h [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/win/audio_low_latency_input_win_unittest.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/win/audio_low_latency_output_win_unittest.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/win/audio_manager_win.cc [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/win/audio_manager_win.h [modify] https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c/media/audio/win/audio_output_win_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/300d26fd54c04a333186c43a9de4d67695c82165 commit 300d26fd54c04a333186c43a9de4d67695c82165 Author: ericrk <ericrk@chromium.org> Date: Mon May 30 18:14:34 2016 Revert of Forward output glitch information from stream WebRTC log (patchset #14 id:320001 of https://codereview.chromium.org/1864483002/ ) Reason for revert: This change broke AudioInputTest.Record on the GPU FYI bots. For example, see https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Debug/builds/5928/steps/audio_unittests%20on%20NVIDIA%20GPU%20on%20Mac%20Retina%20on%20Mac/logs/stdio Confirmed locally that the revert fixes the test failure. Original issue's description: > Forward output glitch information from stream WebRTC log > > * A callback is added as input parameter on AudioManager create stream functions. > * OnLogMessage() function is added to the AudioLog interface. > * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback when creating an output stream. > * AudioInputController gives AudioInputController::LogMessage() (new function) as callback when creating an input stream. In this function, the message is passed to AudioInputRendererHost::OnLog(). > * In both input and output cases, the message is then passed to the WebRTC log. > * The Mac input and output streams inform about OS glitches via the callback. > > BUG= 610967 > > Committed: https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c > Cr-Commit-Position: refs/heads/master@{#396722} TBR=dalecurtis@chromium.org,olka@chromium.org,sievers@chromium.org,slan@chromium.org,xiyuan@chromium.org,grunell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 610967 Review-Url: https://codereview.chromium.org/2023943002 Cr-Commit-Position: refs/heads/master@{#396747} [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/chromecast/media/audio/cast_audio_manager.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/chromecast/media/audio/cast_audio_manager.h [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/chromecast/media/audio/cast_audio_output_stream_unittest.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/components/audio_modem/audio_recorder_impl.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/content/browser/media/media_internals.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/content/browser/renderer_host/media/video_capture_manager.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/alsa/alsa_output_unittest.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/alsa/audio_manager_alsa.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/alsa/audio_manager_alsa.h [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/android/audio_android_unittest.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/android/audio_manager_android.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/android/audio_manager_android.h [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/audio_input_controller.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/audio_input_controller.h [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/audio_input_unittest.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/audio_logging.h [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/audio_low_latency_input_output_unittest.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/audio_manager.h [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/audio_manager_base.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/audio_manager_base.h [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/audio_output_dispatcher_impl.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/audio_output_proxy_unittest.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/cras/audio_manager_cras.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/cras/audio_manager_cras.h [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/fake_audio_log_factory.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/fake_audio_manager.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/fake_audio_manager.h [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/mac/audio_auhal_mac.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/mac/audio_auhal_mac.h [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/mac/audio_auhal_mac_unittest.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/mac/audio_low_latency_input_mac.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/mac/audio_low_latency_input_mac.h [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/mac/audio_low_latency_input_mac_unittest.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/mac/audio_manager_mac.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/mac/audio_manager_mac.h [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/mock_audio_manager.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/mock_audio_manager.h [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/pulse/audio_manager_pulse.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/pulse/audio_manager_pulse.h [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/win/audio_low_latency_input_win_unittest.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/win/audio_low_latency_output_win_unittest.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/win/audio_manager_win.cc [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/win/audio_manager_win.h [modify] https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165/media/audio/win/audio_output_win_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee6953c1c54a56cd277074e6945ae251e6e1240d commit ee6953c1c54a56cd277074e6945ae251e6e1240d Author: grunell <grunell@chromium.org> Date: Tue May 31 12:45:35 2016 Forward output glitch information from stream WebRTC log * A callback is added as input parameter on AudioManager create stream functions. * OnLogMessage() function is added to the AudioLog interface. * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback when creating an output stream. * AudioInputController gives AudioInputController::LogMessage() (new function) as callback when creating an input stream. In this function, the message is passed to AudioInputRendererHost::OnLog(). * In both input and output cases, the message is then passed to the WebRTC log. * The Mac input and output streams inform about OS glitches via the callback. This relands https://codereview.chromium.org/1864483002 BUG= 610967 TBR=slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org (for unchanged files from original CL) Review-Url: https://codereview.chromium.org/2022023002 Cr-Commit-Position: refs/heads/master@{#396818} [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/chromecast/media/audio/cast_audio_manager.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/chromecast/media/audio/cast_audio_manager.h [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/chromecast/media/audio/cast_audio_output_stream_unittest.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/components/audio_modem/audio_recorder_impl.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/content/browser/media/media_internals.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/content/browser/renderer_host/media/video_capture_manager.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/alsa/alsa_output_unittest.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/alsa/audio_manager_alsa.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/alsa/audio_manager_alsa.h [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/android/audio_android_unittest.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/android/audio_manager_android.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/android/audio_manager_android.h [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/audio_input_controller.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/audio_input_controller.h [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/audio_input_unittest.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/audio_logging.h [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/audio_low_latency_input_output_unittest.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/audio_manager.h [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/audio_manager_base.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/audio_manager_base.h [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/audio_output_dispatcher_impl.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/audio_output_proxy_unittest.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/cras/audio_manager_cras.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/cras/audio_manager_cras.h [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/fake_audio_log_factory.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/fake_audio_manager.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/fake_audio_manager.h [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/mac/audio_auhal_mac.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/mac/audio_auhal_mac.h [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/mac/audio_auhal_mac_unittest.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/mac/audio_low_latency_input_mac.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/mac/audio_low_latency_input_mac.h [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/mac/audio_low_latency_input_mac_unittest.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/mac/audio_manager_mac.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/mac/audio_manager_mac.h [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/mock_audio_manager.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/mock_audio_manager.h [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/pulse/audio_manager_pulse.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/pulse/audio_manager_pulse.h [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/win/audio_low_latency_input_win_unittest.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/win/audio_low_latency_output_win_unittest.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/win/audio_manager_win.cc [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/win/audio_manager_win.h [modify] https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d/media/audio/win/audio_output_win_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f28c7f2bd207ab104cb26877da069f634e63872 commit 7f28c7f2bd207ab104cb26877da069f634e63872 Author: guidou <guidou@chromium.org> Date: Wed Jun 01 15:14:23 2016 Revert of Reland: Forward output glitch information from stream WebRTC log (patchset #3 id:60001 of https://codereview.chromium.org/2022023002/ ) Reason for revert: This is a speculative revert, as this CL is suspect of breaking the WebRTC Linux Tester bot. See: https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/17602 If the revert doesn't work, I'll reland. Original issue's description: > Forward output glitch information from stream WebRTC log > > * A callback is added as input parameter on AudioManager create stream functions. > * OnLogMessage() function is added to the AudioLog interface. > * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback when creating an output stream. > * AudioInputController gives AudioInputController::LogMessage() (new function) as callback when creating an input stream. In this function, the message is passed to AudioInputRendererHost::OnLog(). > * In both input and output cases, the message is then passed to the WebRTC log. > * The Mac input and output streams inform about OS glitches via the callback. > > This relands https://codereview.chromium.org/1864483002 > > BUG= 610967 > TBR=slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org (for unchanged files from original CL) > > Committed: https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d > Cr-Commit-Position: refs/heads/master@{#396818} TBR=tommi@chromium.org,slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org,grunell@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 610967 NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2028053002 Cr-Commit-Position: refs/heads/master@{#397145} [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/chromecast/media/audio/cast_audio_manager.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/chromecast/media/audio/cast_audio_manager.h [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/chromecast/media/audio/cast_audio_output_stream_unittest.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/components/audio_modem/audio_recorder_impl.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/content/browser/media/media_internals.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/content/browser/renderer_host/media/video_capture_manager.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/alsa/alsa_output_unittest.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/alsa/audio_manager_alsa.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/alsa/audio_manager_alsa.h [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/android/audio_android_unittest.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/android/audio_manager_android.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/android/audio_manager_android.h [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/audio_input_controller.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/audio_input_controller.h [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/audio_input_unittest.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/audio_logging.h [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/audio_low_latency_input_output_unittest.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/audio_manager.h [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/audio_manager_base.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/audio_manager_base.h [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/audio_output_dispatcher_impl.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/audio_output_proxy_unittest.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/cras/audio_manager_cras.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/cras/audio_manager_cras.h [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/fake_audio_log_factory.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/fake_audio_manager.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/fake_audio_manager.h [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/mac/audio_auhal_mac.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/mac/audio_auhal_mac.h [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/mac/audio_auhal_mac_unittest.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/mac/audio_low_latency_input_mac.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/mac/audio_low_latency_input_mac.h [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/mac/audio_low_latency_input_mac_unittest.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/mac/audio_manager_mac.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/mac/audio_manager_mac.h [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/mock_audio_manager.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/mock_audio_manager.h [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/pulse/audio_manager_pulse.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/pulse/audio_manager_pulse.h [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/win/audio_low_latency_input_win_unittest.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/win/audio_low_latency_output_win_unittest.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/win/audio_manager_win.cc [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/win/audio_manager_win.h [modify] https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872/media/audio/win/audio_output_win_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7 commit 50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7 Author: guidou <guidou@chromium.org> Date: Wed Jun 01 17:12:17 2016 Reland of land: Forward output glitch information from stream WebRTC log (patchset #1 id:1 of https://codereview.chromium.org/2028053002/ ) Reason for revert: The WebRTC Linux Tests bot is still broken after the revert, so relanding. Original issue's description: > Revert of Reland: Forward output glitch information from stream WebRTC log (patchset #3 id:60001 of https://codereview.chromium.org/2022023002/ ) > > Reason for revert: > This is a speculative revert, as this CL is suspect of breaking the WebRTC Linux Tester bot. > > See: https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/17602 > > If the revert doesn't work, I'll reland. > > Original issue's description: > > Forward output glitch information from stream WebRTC log > > > > * A callback is added as input parameter on AudioManager create stream functions. > > * OnLogMessage() function is added to the AudioLog interface. > > * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback when creating an output stream. > > * AudioInputController gives AudioInputController::LogMessage() (new function) as callback when creating an input stream. In this function, the message is passed to AudioInputRendererHost::OnLog(). > > * In both input and output cases, the message is then passed to the WebRTC log. > > * The Mac input and output streams inform about OS glitches via the callback. > > > > This relands https://codereview.chromium.org/1864483002 > > > > BUG= 610967 > > TBR=slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org (for unchanged files from original CL) > > > > Committed: https://crrev.com/ee6953c1c54a56cd277074e6945ae251e6e1240d > > Cr-Commit-Position: refs/heads/master@{#396818} > > TBR=tommi@chromium.org,slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org,grunell@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG= 610967 > NOPRESUBMIT=true > > Committed: https://crrev.com/7f28c7f2bd207ab104cb26877da069f634e63872 > Cr-Commit-Position: refs/heads/master@{#397145} TBR=tommi@chromium.org,slan@chromium.org,sievers@chromium.org,xiyuan@chromium.org,grunell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 610967 Review-Url: https://codereview.chromium.org/2021403003 Cr-Commit-Position: refs/heads/master@{#397166} [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/chromecast/media/audio/cast_audio_manager.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/chromecast/media/audio/cast_audio_manager.h [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/chromecast/media/audio/cast_audio_output_stream_unittest.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/components/audio_modem/audio_recorder_impl.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/content/browser/media/media_internals.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/content/browser/renderer_host/media/video_capture_manager.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/alsa/alsa_output_unittest.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/alsa/audio_manager_alsa.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/alsa/audio_manager_alsa.h [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/android/audio_android_unittest.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/android/audio_manager_android.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/android/audio_manager_android.h [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/audio_input_controller.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/audio_input_controller.h [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/audio_input_unittest.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/audio_logging.h [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/audio_low_latency_input_output_unittest.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/audio_manager.h [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/audio_manager_base.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/audio_manager_base.h [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/audio_output_dispatcher_impl.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/audio_output_proxy_unittest.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/cras/audio_manager_cras.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/cras/audio_manager_cras.h [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/fake_audio_log_factory.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/fake_audio_manager.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/fake_audio_manager.h [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/mac/audio_auhal_mac.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/mac/audio_auhal_mac.h [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/mac/audio_auhal_mac_unittest.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/mac/audio_low_latency_input_mac.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/mac/audio_low_latency_input_mac.h [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/mac/audio_low_latency_input_mac_unittest.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/mac/audio_manager_mac.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/mac/audio_manager_mac.h [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/mock_audio_manager.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/mock_audio_manager.h [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/pulse/audio_manager_pulse.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/pulse/audio_manager_pulse.h [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/win/audio_low_latency_input_win_unittest.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/win/audio_low_latency_output_win_unittest.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/win/audio_manager_win.cc [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/win/audio_manager_win.h [modify] https://crrev.com/50db1a6332b3ac4e3a8c1bcc850a88b4f16c6dc7/media/audio/win/audio_output_win_unittest.cc
Comment 1 by grunell@chromium.org
, May 11 2016